compiler: check number of arguments.

We implement rudimentary compile-time checking beween function
calls and function definitions.

* share/txr/stdlib/compiler.tl (dstruct frag): We add one more
optional BOA parameter, corresponding to a new slot.
This is used when compiling a lambda. A lambda fragment is
annotated with the parameter parser object which gives
information about its arguments.
(struct fbinding): New slot, pars. When processing a sys:fbind
or sys:lbind form, we decorate the lexical function bindings
with the parameter object pulled from the lambda fragment
that is compiled for each function binding.
(*unchecked-calls*): New special variable. This is used for
checking, at the end of the compilation unit, the arguments of
calls to functions that were not defined at the time of the
call.
(compiler comp-fbind): When processing the lambda expressions,
propagate the parameter object from the compiled lambda
fragment to the function binding.
(compiler comp-fun-form): On entry, look up the function being
called and if it is lexical or has a global definition, check
the arguments. If it has no definition, push information into
the *unchecked-calls* list to do the check later, if possible.
Also, there is a behavior change here now: optimizations are
now applied here only to functions that don't have a lexical
binding. Thus if the application lexically redefines a
standard function, and calls it, we won't try to optimize it.
(param-check): New function.

* share/txr/stdlib/param.tl (param-info): New struct. This
presents information about a global function in a similar way
to param-parser, using some of the same fields. With this
object we can check the call to a lexical function or global
function in a uniform way, using the same code.

1 files changed, 15 insertions, 1 deletions

diff --git a/share/txr/stdlib/param.tl b/share/txr/stdlib/param.tl
index 5f3c1b42..c04325c9 100644
--- a/share/txr/stdlib/param.tl
+++ b/share/txr/stdlib/param.tl
@@ -67,4 +67,18 @@
     (mac-param-p nil))
 
   (defstruct (mac-param-parser syntax form) param-parser-base
-    (mac-param-p t)))
+    (mac-param-p t))
+
+  (defstruct (param-info symbol) nil
+    symbol
+    nreq nopt nfix rest
+    (:postinit (me)
+      (let* ((fun (or (symbol-function me.symbol)
+                      (error "~s: no such function: ~s"
+                             'param-info me.symbol)))
+             (fix (fun-fixparam-count fun))
+             (opt (fun-optparam-count fun)))
+        (set me.nreq (- fix opt)
+             me.nopt opt
+             me.nfix fix
+             me.rest (fun-variadic fun))))))