warning cleanup: missing member initializers.

This is the sixth round of an effort to enable GCC's -Wextra
option. Warnings about uninitialized members are addressed.

I am not happy with what had to be done in linenoise.c.
We just need a dummy circular list node for the lino_list,
which we achieved with a dummy all zero struture, with
statially initialized next and prev pointers. There are way
too many members to initialize, including one that has struct
termios type containing a nonportable set of members.
On the plus size, the lino_list structure now moves into the
BSS section, reducing the executable size slightly.

* lib.c (cptr_ops): Initialize using cobj_ops_init, which has
all the initializers already, and should have been used for
this in the first place.

* linenoise/linenoise.c (lino_list): Remove initializer,
which eliminates the warning about some members not being
initialized.
(lino_init): Initialize the next and prev pointers here.

* parser.c (parser_ops): Initialize with cobj_ops_init.

* stream.h (stdio_mode_init_blank, stdio_mode_init_r,
stdio_mode_init_rpb): Add initializer corresponding to redir
array member of struct stdio_mode.

* sysif.c (cptr_dl_ops): Use cobj_ops_init.

* tree.c (tree_iter_init): Add initializer for the path
array member of struct tree_iter.
(tr_rebuild): Initialize all fields of the dummy object.
Since it's a union, we just have to deal with the any
member. There are two layouts for the obj_common fields
based on whether CONFIG_GEN_GC is enabled. This is ugly, but
occurs in one place only.

1 files changed, 5 insertions, 7 deletions

diff --git a/parser.c b/parser.c
index 6372032c..c6699988 100644
--- a/parser.c
+++ b/parser.c
@@ -107,13 +107,11 @@ static void parser_destroy(val obj)
   free(p);
 }
 
-static struct cobj_ops parser_ops = {
-  eq,
-  cobj_print_op,
-  parser_destroy,
-  parser_mark,
-  cobj_eq_hash_op,
-};
+static struct cobj_ops parser_ops = cobj_ops_init(eq,
+                                                  cobj_print_op,
+                                                  parser_destroy,
+                                                  parser_mark,
+                                                  cobj_eq_hash_op);
 
 void parser_common_init(parser_t *p)
 {