Add comment to extension/filefuncs.c discussing unref on value from assoc_lookup.

1 files changed, 7 insertions, 0 deletions

diff --git a/extension/filefuncs.c b/extension/filefuncs.c
index 9758ba8e..01f3fce2 100644
--- a/extension/filefuncs.c
+++ b/extension/filefuncs.c
@@ -220,6 +220,13 @@ array_set(NODE *array, const char *sub, NODE *value)
 	tmp = make_string(sub, strlen(sub));
 	aptr = assoc_lookup(array, tmp);
 	unref(tmp);
+	/* 
+	 * Note: since we initialized with assoc_clear, we know that aptr
+	 * has been initialized with Nnull_string.  Thus, the call to
+	 * unref(*aptr) is not strictly necessary.  However, I think it is
+	 * generally more correct to call unref to maintain the proper
+	 * reference count.
+	 */
 	unref(*aptr);
 	*aptr = value;
 }