aboutsummaryrefslogtreecommitdiffstats
path: root/builtin.c
diff options
context:
space:
mode:
authorArnold D. Robbins <arnold@skeeve.com>2015-04-16 13:14:06 +0300
committerArnold D. Robbins <arnold@skeeve.com>2015-04-16 13:14:06 +0300
commit5d781d9d27f2ab30679853317df3f5e9ad94be80 (patch)
treeb39845176c56c279d8218618d0a52f478656e77a /builtin.c
parent3fc38ff001d5a4345def6ce960918612ed209518 (diff)
downloadegawk-5d781d9d27f2ab30679853317df3f5e9ad94be80.tar.gz
egawk-5d781d9d27f2ab30679853317df3f5e9ad94be80.tar.bz2
egawk-5d781d9d27f2ab30679853317df3f5e9ad94be80.zip
Additional checking for strftime.
Diffstat (limited to 'builtin.c')
-rw-r--r--builtin.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/builtin.c b/builtin.c
index fc670946..804bd60a 100644
--- a/builtin.c
+++ b/builtin.c
@@ -1864,7 +1864,7 @@ do_strftime(int nargs)
NODE *t1, *t2, *t3, *ret;
struct tm *tm;
time_t fclock;
- long clock_val;
+ double clock_val;
char *bufp;
size_t buflen, bufsize;
char buf[BUFSIZ];
@@ -1873,6 +1873,8 @@ do_strftime(int nargs)
int do_gmt;
NODE *val = NULL;
NODE *sub = NULL;
+ static const time_t time_t_min = TYPE_MINIMUM(time_t);
+ static const time_t time_t_max = TYPE_MAXIMUM(time_t);
/* set defaults first */
format = def_strftime_format; /* traditional date format */
@@ -1912,7 +1914,7 @@ do_strftime(int nargs)
if (do_lint && (t2->flags & (NUMCUR|NUMBER)) == 0)
lintwarn(_("strftime: received non-numeric second argument"));
(void) force_number(t2);
- clock_val = get_number_si(t2);
+ clock_val = get_number_d(t2);
fclock = (time_t) clock_val;
/*
* 4/2015: Protect against negative value being assigned
@@ -1920,6 +1922,11 @@ do_strftime(int nargs)
*/
if (clock_val < 0 && fclock > 0)
fatal(_("strftime: second argument less than 0 or too big for time_t"));
+
+ /* And check that the value is in range */
+ if (clock_val < time_t_min || clock_val > time_t_max)
+ fatal(_("strftime: second argument out of range for time_t"));
+
DEREF(t2);
}