aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnold D. Robbins <arnold@skeeve.com>2013-12-05 20:52:50 +0200
committerArnold D. Robbins <arnold@skeeve.com>2013-12-05 20:52:50 +0200
commitda923f91d9bd8ade673a4f2f15be3d78a36b759e (patch)
tree1e1c9dcd0f0d56e95457c9af338bdbd6fb27806f
parentc084ecfb72609150bdfdce04831e83bb0e4e5cb6 (diff)
downloadegawk-da923f91d9bd8ade673a4f2f15be3d78a36b759e.tar.gz
egawk-da923f91d9bd8ade673a4f2f15be3d78a36b759e.tar.bz2
egawk-da923f91d9bd8ade673a4f2f15be3d78a36b759e.zip
Add a FIXME comment.
-rw-r--r--ChangeLog4
-rw-r--r--debug.c5
2 files changed, 9 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index dbf25242..c3017b23 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -6,6 +6,10 @@
* dfa.c (parse_bracket_exp): Add a cast to quiet a warning.
* regex.c: Correctly bracket include of <sys/param.h>.
+ Unrelated:
+
+ * debug.c (find_rule): Add a FIXME comment.
+
2013-12-03 John E. Malmberg <wb8tyw@qsl.net>
* io.c (redirect): Add additional VMS error code to check.
diff --git a/debug.c b/debug.c
index 357ce725..8df9ed0d 100644
--- a/debug.c
+++ b/debug.c
@@ -2068,6 +2068,11 @@ find_rule(char *src, long lineno)
{
INSTRUCTION *rp;
+ /*
+ * FIXME: The check for zero and code that goes with it
+ * are probably fragile. A break with no arguments can
+ * cause this in certain cases. Try to review how this works.
+ */
if (lineno == 0) {
for (rp = rule_list->nexti; rp != NULL; rp = rp->nexti) {
if ((rp - 1)->source_file == src && (rp - 1)->source_line > 0)