Change return type on some functions from int to bool.

4 files changed, 11 insertions, 4 deletions

diff --git a/ChangeLog b/ChangeLog
index a7da9987..8b877467 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2017-02-23         Arnold D. Robbins     <arnold@skeeve.com>
+
+	* awk.h (boolval): Return bool instead of int.
+	* eval.c (eval_condition): Same.
+	* io.c (pty_vs_pipe): Same
+	Thanks to Andrew Schorr for pointing these out.
+
 2017-02-21         Andrew J. Schorr     <aschorr@telemetry-investments.com>
 
 	* NEWS: Document that mktime now takes an optional utc-flag argument.
diff --git a/awk.h b/awk.h
index 199aba38..aae5e7ec 100644
--- a/awk.h
+++ b/awk.h
@@ -1914,7 +1914,7 @@ fixtype(NODE *n)
  * non-null. Otherwise, the value is false.
  */
 
-static inline int
+static inline bool
 boolval(NODE *t)
 {
 	(void) fixtype(t);
diff --git a/eval.c b/eval.c
index ab77016d..73bd7fc9 100644
--- a/eval.c
+++ b/eval.c
@@ -1510,7 +1510,7 @@ unwind_stack(long n)
 #define pop_stack()	(void) unwind_stack(0)
 
 
-static inline int
+static inline bool
 eval_condition(NODE *t)
 {
 	if (t == node_Boolean[false])
diff --git a/io.c b/io.c
index d65f2aaa..cced126e 100644
--- a/io.c
+++ b/io.c
@@ -275,7 +275,7 @@ static IOBUF *iop_finish(IOBUF *iop);
 static int gawk_pclose(struct redirect *rp);
 static int str2mode(const char *mode);
 static int two_way_open(const char *str, struct redirect *rp, int extfd);
-static int pty_vs_pipe(const char *command);
+static bool pty_vs_pipe(const char *command);
 static void find_input_parser(IOBUF *iop);
 static bool find_output_wrapper(awk_output_buf_t *outbuf);
 static void init_output_wrapper(awk_output_buf_t *outbuf);
@@ -3915,7 +3915,7 @@ set_FS:
  * This works by checking if PROCINFO["command", "pty"] exists and is true.
  */
 
-static int
+static bool
 pty_vs_pipe(const char *command)
 {
 #ifdef HAVE_TERMIOS_H