diff options
-rwxr-xr-x | ChangeLog | 131 | ||||
-rw-r--r-- | NEWS | 4 | ||||
-rw-r--r-- | awk.h | 13 | ||||
-rw-r--r-- | awkgram.c | 1572 | ||||
-rw-r--r-- | awkgram.y | 759 | ||||
-rw-r--r-- | debug.c | 56 | ||||
-rw-r--r-- | doc/ChangeLog | 6 | ||||
-rw-r--r-- | doc/gawk.info | 463 | ||||
-rw-r--r-- | doc/gawk.texi | 4 | ||||
-rw-r--r-- | doc/gawktexi.in | 4 | ||||
-rw-r--r-- | profile.c | 206 | ||||
-rw-r--r-- | test/ChangeLog | 4 | ||||
-rw-r--r-- | test/profile0.ok | 2 |
13 files changed, 1990 insertions, 1234 deletions
@@ -6,11 +6,121 @@ * config.sub: Updated from GNULIB. +2018-10-20 Arnold D. Robbins <arnold@skeeve.com> + + * awk.h (SRCFILE): Add comment field for comments on @load statements. + * awkgram.y (include_source): Type change to boolean. + (load_library): Type change to boolean, additiona parameter to + bring the SRCFILE struct up to where we can add the comment into it. + (make_include_comment): New function. Not used yet. + (Grammar): Add comment for @load statements. Start on preserving + @include statements and their comments for eventual inclusion + into the pretty-printed code. + * profile.c (print_lib_list): Made a little smarter about printing + the header and indentation. Print the comment if there is one. + +2018-10-17 Arnold D. Robbins <arnold@skeeve.com> + + * awk.h (commenttype): Add FOR_COMMENT. + * awkgram.y (Grammar): Handle all the opt_nls cases in + regular for statements. + * debug.c (print_instruction): Print the comments in Op_K_for. + * profile.c (pprint): Handle printing comments. + +2018-10-17 Arnold D. Robbins <arnold@skeeve.com> + + * NEWS: Updated. + * awkgram.y (Grammar): Distinguish `print' and `print $0' in + what gets profiled / pretty-printed. + * profile.c (pprint): For case and default, add final newline + if there is no comment to print. + +2018-10-16 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y (Grammar): Improve comment handling for many plain + statements. Improve handling for case and default. + Handle comments in `for (iggy in foo)' loops. + (yylex): After a colon, only allow newline if was part of ?:. + (merge_comments): Improve coding so we don't get two newlines + at the end of a merged comment. + * debug.c (print_instruction): Handle comments for case and default. + Simplify printing of comments. + * profile.c (pprint): Handle comments for case and default. + Remove compiler warning in Op_and/Op_or handling. + +2018-10-14 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y (Grammar): Add comment handling for do...while. + Regularize comments about `else ...'. + * debug.c (print_instruction): Improve handling of comments for + do-while and switch, and in general. + * profile.c (pprint): Revise for do...while. + +2018-10-10 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y (make_braced_statements): New function. + (Grammar): Use it in the right places instead of inline code. + * debug.c (print_instruction): For Op_comment, fix type string. + * profile.c (pprint): Move tabs and tabs_len to top of function. + For Op_and and Op_or, handle comments. Use new check_indent_level + for Op_and, Op_or and Op_cond_exp. + 2018-10-10 Arnold D. Robbins <arnold@skeeve.com> * debug.c (print_instruction): For Op_comment, use print_func instead of fprintf to print the comment type. +2018-10-10 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y (Grammar): For statement -> { statements }, fix comment + handling. For `if' statement add comment support. + * profile.c (pp_print): Print comments associated with `if' and `else'. + +2018-10-09 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y (Grammar): Fix handling of empty statement (just a semi- + colon). + (merge_comments): If no chained comment and no second comment, + just return early. + +2018-10-09 Arnold D. Robbins <arnold@skeeve.com> + + * awk.h (enum commenttype): New enum. + (NODE): Add it to sub.val. + (EOL_COMMENT, FULL_COMMENT): Replaced with above enum values. + * awkgram.y (Grammar): Finish up handling comments in function headers + and bodies. Get trailing comments at end of program + (get_comment): When doing comments, if we got EOF, push it back so that + multiple comments get merged together. + (merge_comments): Allow second parameter to be NULL. + * profile.c (pp_print): Change to use above enum everywhere. For + Op_K_print_rec produce plain `print' instead of `print $0'. Handle + comments in ?:. Handle printing function comments. + (print_comment): Simplify `after_newline' assignment. Add assertion + that chaining is only two deep. + +2018-10-06 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y (action): Improve handling of comments attached + to braces. Helps with function bodies. + +2018-10-04 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y (merge_comments): Change return type to void. Adjust calls. + (Grammar): For action, pull comments out of braces and stick + into the list. For function_prologue, get comments from parameters + and ending newline, merge, and save. Wherever nls and opt_nls + are used, be sure to pass their values up via $$. For various + cases that can be empty, explicitly set $$ = NULL. + * profile.c (pprint): Get switch working. Get ?: working. + (print_comment): Print any chained comment. + (pp_func): Start revising. + +2018-10-03 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y: Range expressions, enable comment stuff. + Switch statement: start on comment handling. + 2018-10-01 Nelson H.F. Beebe <beebe@math.utah.edu> * custom.h (__builtin_expect): Define for non-GNU compilers. @@ -40,6 +150,23 @@ 2018-09-21 Arnold D. Robbins <arnold@skeeve.com> + * awk.h (INSTRUCTION): Add comment field to carry + comment around during parsing. + * awkgram.y (merge_comments): New function. + (split_comment, check_comment, comment, prior_comment, + comment_to_save, program_comment, function_comment, + block_comment): Removed. + (grammar): Remove old code and start passing the comment + up via yylval and the newlines in the grammar. + +2018-09-21 Arnold D. Robbins <arnold@skeeve.com> + + * awkgram.y: Undo change of 2016-11-28 to make switch + head a separate production, in preparation for revamping + comment handling. + +2018-09-21 Arnold D. Robbins <arnold@skeeve.com> + * re.c (make_regexp): Handle backslash at end of input string. Thanks to Anatoly Trosinenko <anatoly.trosinenko@gmail.com> for the report. @@ -1719,6 +1846,10 @@ * dfa.c: Sync with GNULIB. Twice in one day. + Unrelated: Start improving profiling comments for switch/case. + + * awkgram.y (switch_head): New production. + 2016-11-21 Arnold D. Robbins <arnold@skeeve.com> * dfa.c: Sync with GNULIB. @@ -15,6 +15,10 @@ Changes from 4.2.x to 5.0.0 3. The code now makes some stronger assumptions about a C99 environment. +4. Comment handling in the pretty-printer has been reworked almost completely +from scratch. As a result, comments in many corner cases that were previously +lost are now included in the formatted output. + Changes from 4.2.1 to 4.2.2 --------------------------- @@ -296,6 +296,12 @@ typedef union bucket_item { } hi; } BUCKET; +enum commenttype { + EOL_COMMENT = 1, + BLOCK_COMMENT, + FOR_COMMENT // special case +}; + /* string hash table */ #define ahnext hs.next #define ahname hs.name /* a string index node */ @@ -368,6 +374,7 @@ typedef struct exp_node { wchar_t *wsp; size_t wslen; struct exp_node *typre; + enum commenttype comtype; } val; } sub; NODETYPE type; @@ -565,9 +572,7 @@ typedef struct exp_node { #define alevel sub.nodep.x.xl /* Op_comment */ -#define comment_type sub.val.idx -#define EOL_COMMENT 1 -#define FULL_COMMENT 2 +#define comment_type sub.val.comtype /* --------------------------------lint warning types----------------------------*/ typedef enum lintvals { @@ -764,6 +769,7 @@ typedef struct exp_instruction { awk_ext_func_t *exf; } x; + struct exp_instruction *comment; short source_line; short pool_size; // memory management in symbol.c OPCODE opcode; @@ -1009,6 +1015,7 @@ typedef struct srcfile { char *lexeme; char *lexptr_begin; int lasttok; + INSTRUCTION *comment; /* comment on @load line */ } SRCFILE; // structure for INSTRUCTION pool, needed mainly for debugger @@ -62,7 +62,7 @@ /* Copy the first part of user declarations. */ -#line 26 "awkgram.y" /* yacc.c:339 */ +#line 44 "awkgram.y" /* yacc.c:339 */ #ifdef GAWKDEBUG #define YYDEBUG 12 @@ -93,8 +93,8 @@ static int isnoeffect(OPCODE type); static INSTRUCTION *make_assignable(INSTRUCTION *ip); static void dumpintlstr(const char *str, size_t len); static void dumpintlstr2(const char *str1, size_t len1, const char *str2, size_t len2); -static int include_source(INSTRUCTION *file); -static int load_library(INSTRUCTION *file); +static bool include_source(INSTRUCTION *file); +static bool load_library(INSTRUCTION *file, void **comment_p); static void next_sourcefile(void); static char *tokexpand(void); static NODE *set_profile_text(NODE *n, const char *str, size_t len); @@ -124,8 +124,9 @@ static void check_funcs(void); static ssize_t read_one_line(int fd, void *buffer, size_t count); static int one_line_close(int fd); -static void split_comment(void); -static void check_comment(void); +static void merge_comments(INSTRUCTION *c1, INSTRUCTION *c2); +static INSTRUCTION *make_include_comment(const char *filename); +static INSTRUCTION *make_braced_statements(INSTRUCTION *lbrace, INSTRUCTION *stmts, INSTRUCTION *rbrace); static void add_sign_to_num(NODE *n, char sign); static bool at_seen = false; @@ -192,27 +193,19 @@ static INSTRUCTION *ip_endfile; static INSTRUCTION *ip_beginfile; INSTRUCTION *main_beginfile; -static INSTRUCTION *comment = NULL; -static INSTRUCTION *prior_comment = NULL; -static INSTRUCTION *comment_to_save = NULL; -static INSTRUCTION *program_comment = NULL; -static INSTRUCTION *function_comment = NULL; -static INSTRUCTION *block_comment = NULL; - -static bool func_first = true; +static bool func_first = true; // can nuke static bool first_rule = true; static inline INSTRUCTION *list_create(INSTRUCTION *x); static inline INSTRUCTION *list_append(INSTRUCTION *l, INSTRUCTION *x); static inline INSTRUCTION *list_prepend(INSTRUCTION *l, INSTRUCTION *x); static inline INSTRUCTION *list_merge(INSTRUCTION *l1, INSTRUCTION *l2); -static inline INSTRUCTION *add_pending_comment(INSTRUCTION *stmt); extern double fmod(double x, double y); #define YYSTYPE INSTRUCTION * -#line 216 "awkgram.c" /* yacc.c:339 */ +#line 209 "awkgram.c" /* yacc.c:339 */ # ifndef YY_NULLPTR # if defined __cplusplus && 201103L <= __cplusplus @@ -368,7 +361,7 @@ int yyparse (void); /* Copy the second part of user declarations. */ -#line 372 "awkgram.c" /* yacc.c:358 */ +#line 365 "awkgram.c" /* yacc.c:358 */ #ifdef short # undef short @@ -670,27 +663,27 @@ static const yytype_uint8 yytranslate[] = /* YYRLINE[YYN] -- Source line where rule number YYN was defined. */ static const yytype_uint16 yyrline[] = { - 0, 215, 215, 217, 222, 223, 227, 239, 244, 255, - 262, 268, 277, 285, 287, 292, 300, 302, 308, 316, - 326, 356, 370, 384, 392, 403, 415, 417, 419, 425, - 433, 434, 438, 438, 484, 483, 517, 532, 534, 539, - 549, 596, 601, 602, 606, 608, 610, 617, 707, 749, - 791, 904, 911, 918, 929, 939, 949, 959, 971, 988, - 987, 1001, 1013, 1013, 1112, 1112, 1146, 1177, 1186, 1187, - 1193, 1194, 1201, 1206, 1218, 1232, 1234, 1242, 1249, 1251, - 1259, 1268, 1270, 1279, 1280, 1288, 1293, 1293, 1306, 1310, - 1318, 1319, 1322, 1324, 1329, 1330, 1339, 1340, 1345, 1350, - 1359, 1361, 1363, 1370, 1371, 1377, 1378, 1383, 1385, 1390, - 1392, 1400, 1405, 1414, 1415, 1420, 1422, 1427, 1429, 1437, - 1442, 1450, 1451, 1456, 1463, 1467, 1469, 1471, 1484, 1501, - 1511, 1518, 1520, 1525, 1527, 1529, 1537, 1539, 1544, 1546, - 1551, 1553, 1555, 1612, 1614, 1616, 1618, 1620, 1622, 1624, - 1626, 1640, 1645, 1650, 1675, 1681, 1683, 1685, 1687, 1689, - 1691, 1696, 1700, 1732, 1740, 1746, 1752, 1765, 1766, 1767, - 1772, 1777, 1781, 1785, 1800, 1821, 1826, 1863, 1892, 1893, - 1899, 1900, 1905, 1907, 1914, 1931, 1948, 1950, 1957, 1962, - 1970, 1980, 1992, 2001, 2005, 2009, 2013, 2017, 2021, 2024, - 2026, 2030, 2034, 2038 + 0, 228, 228, 229, 234, 242, 246, 258, 263, 277, + 284, 315, 328, 340, 342, 347, 357, 359, 365, 369, + 374, 404, 417, 430, 437, 447, 459, 461, 463, 469, + 477, 478, 482, 482, 516, 515, 549, 564, 566, 571, + 572, 586, 591, 592, 596, 607, 611, 618, 726, 777, + 827, 953, 974, 995, 1005, 1015, 1025, 1036, 1049, 1067, + 1066, 1080, 1098, 1098, 1196, 1196, 1229, 1259, 1267, 1268, + 1274, 1275, 1282, 1287, 1300, 1315, 1317, 1325, 1332, 1334, + 1342, 1351, 1353, 1362, 1363, 1371, 1376, 1376, 1389, 1395, + 1407, 1408, 1430, 1431, 1437, 1438, 1447, 1448, 1453, 1458, + 1475, 1477, 1479, 1486, 1487, 1493, 1494, 1499, 1501, 1506, + 1508, 1516, 1521, 1530, 1531, 1536, 1538, 1543, 1545, 1553, + 1558, 1566, 1567, 1572, 1579, 1583, 1585, 1587, 1600, 1617, + 1627, 1634, 1636, 1641, 1643, 1645, 1653, 1655, 1660, 1662, + 1667, 1669, 1671, 1728, 1730, 1732, 1734, 1736, 1738, 1740, + 1742, 1756, 1761, 1766, 1791, 1797, 1799, 1801, 1803, 1805, + 1807, 1812, 1816, 1848, 1856, 1862, 1868, 1881, 1882, 1883, + 1888, 1893, 1897, 1901, 1916, 1937, 1942, 1979, 2008, 2009, + 2015, 2016, 2021, 2023, 2030, 2047, 2064, 2066, 2073, 2078, + 2086, 2096, 2108, 2117, 2121, 2126, 2130, 2134, 2138, 2143, + 2144, 2148, 2152, 2156 }; #endif @@ -1888,25 +1881,43 @@ yyreduce: YY_REDUCE_PRINT (yyn); switch (yyn) { - case 3: -#line 218 "awkgram.y" /* yacc.c:1651 */ + case 2: +#line 228 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = NULL; } +#line 1888 "awkgram.c" /* yacc.c:1651 */ + break; + + case 3: +#line 230 "awkgram.y" /* yacc.c:1651 */ { rule = 0; yyerrok; } -#line 1898 "awkgram.c" /* yacc.c:1651 */ +#line 1897 "awkgram.c" /* yacc.c:1651 */ + break; + + case 4: +#line 235 "awkgram.y" /* yacc.c:1651 */ + { + if ((yyvsp[0]) != NULL) { + merge_comments((yyvsp[0]), NULL); + (yyval) = list_append(rule_list, (yyvsp[0])); + } else + (yyval) = (yyvsp[-1]); + } +#line 1909 "awkgram.c" /* yacc.c:1651 */ break; case 5: -#line 224 "awkgram.y" /* yacc.c:1651 */ +#line 243 "awkgram.y" /* yacc.c:1651 */ { next_sourcefile(); } -#line 1906 "awkgram.c" /* yacc.c:1651 */ +#line 1917 "awkgram.c" /* yacc.c:1651 */ break; case 6: -#line 228 "awkgram.y" /* yacc.c:1651 */ +#line 247 "awkgram.y" /* yacc.c:1651 */ { rule = 0; /* @@ -1915,20 +1926,20 @@ yyreduce: */ /* yyerrok; */ } -#line 1919 "awkgram.c" /* yacc.c:1651 */ +#line 1930 "awkgram.c" /* yacc.c:1651 */ break; case 7: -#line 240 "awkgram.y" /* yacc.c:1651 */ +#line 259 "awkgram.y" /* yacc.c:1651 */ { (void) append_rule((yyvsp[-1]), (yyvsp[0])); first_rule = false; } -#line 1928 "awkgram.c" /* yacc.c:1651 */ +#line 1939 "awkgram.c" /* yacc.c:1651 */ break; case 8: -#line 245 "awkgram.y" /* yacc.c:1651 */ +#line 264 "awkgram.y" /* yacc.c:1651 */ { if (rule != Rule) { msg(_("%s blocks must have an action part"), ruletab[rule]); @@ -1936,119 +1947,148 @@ yyreduce: } else if ((yyvsp[-1]) == NULL) { msg(_("each rule must have a pattern or an action part")); errcount++; - } else /* pattern rule with non-empty pattern */ + } else { /* pattern rule with non-empty pattern */ + if ((yyvsp[0]) != NULL) + list_append((yyvsp[-1]), (yyvsp[0])); (void) append_rule((yyvsp[-1]), NULL); + } } -#line 1943 "awkgram.c" /* yacc.c:1651 */ +#line 1957 "awkgram.c" /* yacc.c:1651 */ break; case 9: -#line 256 "awkgram.y" /* yacc.c:1651 */ +#line 278 "awkgram.y" /* yacc.c:1651 */ { in_function = NULL; (void) mk_function((yyvsp[-1]), (yyvsp[0])); want_param_names = DONT_CHECK; yyerrok; } -#line 1954 "awkgram.c" /* yacc.c:1651 */ +#line 1968 "awkgram.c" /* yacc.c:1651 */ break; case 10: -#line 263 "awkgram.y" /* yacc.c:1651 */ +#line 285 "awkgram.y" /* yacc.c:1651 */ { want_source = false; at_seen = false; +#if 1 + if ((yyvsp[0]) != NULL) { + assert((yyvsp[0])->opcode == Op_comment); + warning(_("comments on `@include' statements will be lost")); + unref((yyvsp[0])->memory); + bcfree((yyvsp[0])); + } +#else + if ((yyvsp[-1]) != NULL && (yyvsp[0]) != NULL) { + size_t end; + + // remove trailing newline + end = --((yyvsp[-1])->memory->stlen); + (yyvsp[-1])->memory->stptr[end] = '\0'; + + merge_comments((yyvsp[-1]), (yyvsp[0])); + + // tweak embedded newline + (yyvsp[-1])->memory->stptr[end] = '\t'; + + // FIXME: how to get this into the program? + // list_append(rule_list, $3); + // rule_list = list_prepend(rule_list, list_create($3)); + } +#endif yyerrok; } -#line 1964 "awkgram.c" /* yacc.c:1651 */ +#line 2003 "awkgram.c" /* yacc.c:1651 */ break; case 11: -#line 269 "awkgram.y" /* yacc.c:1651 */ +#line 316 "awkgram.y" /* yacc.c:1651 */ { want_source = false; at_seen = false; + if ((yyvsp[-1]) != NULL && (yyvsp[0]) != NULL) { + SRCFILE *s = (SRCFILE *) (yyvsp[-1]); + s->comment = (yyvsp[0]); + } yyerrok; } -#line 1974 "awkgram.c" /* yacc.c:1651 */ +#line 2017 "awkgram.c" /* yacc.c:1651 */ break; case 12: -#line 278 "awkgram.y" /* yacc.c:1651 */ +#line 329 "awkgram.y" /* yacc.c:1651 */ { - if (include_source((yyvsp[0])) < 0) + if (! include_source((yyvsp[0]))) YYABORT; + if (do_pretty_print) { + (yyval) = make_include_comment((yyvsp[0])->lextok); + } else { + (yyval) = NULL; + } efree((yyvsp[0])->lextok); bcfree((yyvsp[0])); - (yyval) = NULL; } -#line 1986 "awkgram.c" /* yacc.c:1651 */ +#line 2033 "awkgram.c" /* yacc.c:1651 */ break; case 13: -#line 286 "awkgram.y" /* yacc.c:1651 */ +#line 341 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 1992 "awkgram.c" /* yacc.c:1651 */ +#line 2039 "awkgram.c" /* yacc.c:1651 */ break; case 14: -#line 288 "awkgram.y" /* yacc.c:1651 */ +#line 343 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 1998 "awkgram.c" /* yacc.c:1651 */ +#line 2045 "awkgram.c" /* yacc.c:1651 */ break; case 15: -#line 293 "awkgram.y" /* yacc.c:1651 */ +#line 348 "awkgram.y" /* yacc.c:1651 */ { - if (load_library((yyvsp[0])) < 0) + void *srcfile; + + if (! load_library((yyvsp[0]), & srcfile)) YYABORT; efree((yyvsp[0])->lextok); bcfree((yyvsp[0])); - (yyval) = NULL; + (yyval) = (INSTRUCTION *) srcfile; } -#line 2010 "awkgram.c" /* yacc.c:1651 */ +#line 2059 "awkgram.c" /* yacc.c:1651 */ break; case 16: -#line 301 "awkgram.y" /* yacc.c:1651 */ +#line 358 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 2016 "awkgram.c" /* yacc.c:1651 */ +#line 2065 "awkgram.c" /* yacc.c:1651 */ break; case 17: -#line 303 "awkgram.y" /* yacc.c:1651 */ +#line 360 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 2022 "awkgram.c" /* yacc.c:1651 */ +#line 2071 "awkgram.c" /* yacc.c:1651 */ break; case 18: -#line 308 "awkgram.y" /* yacc.c:1651 */ +#line 365 "awkgram.y" /* yacc.c:1651 */ { rule = Rule; - if (comment != NULL) { - (yyval) = list_create(comment); - comment = NULL; - } else - (yyval) = NULL; + (yyval) = NULL; } -#line 2035 "awkgram.c" /* yacc.c:1651 */ +#line 2080 "awkgram.c" /* yacc.c:1651 */ break; case 19: -#line 317 "awkgram.y" /* yacc.c:1651 */ +#line 370 "awkgram.y" /* yacc.c:1651 */ { rule = Rule; - if (comment != NULL) { - (yyval) = list_prepend((yyvsp[0]), comment); - comment = NULL; - } else - (yyval) = (yyvsp[0]); } -#line 2048 "awkgram.c" /* yacc.c:1651 */ +#line 2088 "awkgram.c" /* yacc.c:1651 */ break; case 20: -#line 327 "awkgram.y" /* yacc.c:1651 */ +#line 375 "awkgram.y" /* yacc.c:1651 */ { INSTRUCTION *tp; @@ -2071,18 +2111,18 @@ yyreduce: ((yyvsp[-3])->nexti + 1)->condpair_left = (yyvsp[-3])->lasti; ((yyvsp[-3])->nexti + 1)->condpair_right = (yyvsp[0])->lasti; } - if (comment != NULL) { - (yyval) = list_append(list_merge(list_prepend((yyvsp[-3]), comment), (yyvsp[0])), tp); - comment = NULL; - } else + /* Put any comments in front of the range expression */ + if ((yyvsp[-1]) != NULL) + (yyval) = list_append(list_merge(list_prepend((yyvsp[-3]), (yyvsp[-1])), (yyvsp[0])), tp); + else (yyval) = list_append(list_merge((yyvsp[-3]), (yyvsp[0])), tp); rule = Rule; } -#line 2082 "awkgram.c" /* yacc.c:1651 */ +#line 2122 "awkgram.c" /* yacc.c:1651 */ break; case 21: -#line 357 "awkgram.y" /* yacc.c:1651 */ +#line 405 "awkgram.y" /* yacc.c:1651 */ { static int begin_seen = 0; @@ -2093,14 +2133,13 @@ yyreduce: (yyvsp[0])->in_rule = rule = BEGIN; (yyvsp[0])->source_file = source; - check_comment(); (yyval) = (yyvsp[0]); } -#line 2100 "awkgram.c" /* yacc.c:1651 */ +#line 2139 "awkgram.c" /* yacc.c:1651 */ break; case 22: -#line 371 "awkgram.y" /* yacc.c:1651 */ +#line 418 "awkgram.y" /* yacc.c:1651 */ { static int end_seen = 0; @@ -2111,116 +2150,101 @@ yyreduce: (yyvsp[0])->in_rule = rule = END; (yyvsp[0])->source_file = source; - check_comment(); (yyval) = (yyvsp[0]); } -#line 2118 "awkgram.c" /* yacc.c:1651 */ +#line 2156 "awkgram.c" /* yacc.c:1651 */ break; case 23: -#line 385 "awkgram.y" /* yacc.c:1651 */ +#line 431 "awkgram.y" /* yacc.c:1651 */ { func_first = false; (yyvsp[0])->in_rule = rule = BEGINFILE; (yyvsp[0])->source_file = source; - check_comment(); (yyval) = (yyvsp[0]); } -#line 2130 "awkgram.c" /* yacc.c:1651 */ +#line 2167 "awkgram.c" /* yacc.c:1651 */ break; case 24: -#line 393 "awkgram.y" /* yacc.c:1651 */ +#line 438 "awkgram.y" /* yacc.c:1651 */ { func_first = false; (yyvsp[0])->in_rule = rule = ENDFILE; (yyvsp[0])->source_file = source; - check_comment(); (yyval) = (yyvsp[0]); } -#line 2142 "awkgram.c" /* yacc.c:1651 */ +#line 2178 "awkgram.c" /* yacc.c:1651 */ break; case 25: -#line 404 "awkgram.y" /* yacc.c:1651 */ +#line 448 "awkgram.y" /* yacc.c:1651 */ { - INSTRUCTION *ip; - if ((yyvsp[-3]) == NULL) - ip = list_create(instruction(Op_no_op)); - else - ip = (yyvsp[-3]); + INSTRUCTION *ip = make_braced_statements((yyvsp[-4]), (yyvsp[-3]), (yyvsp[-2])); + + if ((yyvsp[0]) != NULL) + ip = list_append(ip, (yyvsp[0])); + (yyval) = ip; } -#line 2155 "awkgram.c" /* yacc.c:1651 */ +#line 2191 "awkgram.c" /* yacc.c:1651 */ break; case 26: -#line 416 "awkgram.y" /* yacc.c:1651 */ +#line 460 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 2161 "awkgram.c" /* yacc.c:1651 */ +#line 2197 "awkgram.c" /* yacc.c:1651 */ break; case 27: -#line 418 "awkgram.y" /* yacc.c:1651 */ +#line 462 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 2167 "awkgram.c" /* yacc.c:1651 */ +#line 2203 "awkgram.c" /* yacc.c:1651 */ break; case 28: -#line 420 "awkgram.y" /* yacc.c:1651 */ +#line 464 "awkgram.y" /* yacc.c:1651 */ { yyerror(_("`%s' is a built-in function, it cannot be redefined"), tokstart); YYABORT; } -#line 2177 "awkgram.c" /* yacc.c:1651 */ +#line 2213 "awkgram.c" /* yacc.c:1651 */ break; case 29: -#line 426 "awkgram.y" /* yacc.c:1651 */ +#line 470 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); at_seen = false; } -#line 2186 "awkgram.c" /* yacc.c:1651 */ +#line 2222 "awkgram.c" /* yacc.c:1651 */ break; case 32: -#line 438 "awkgram.y" /* yacc.c:1651 */ +#line 482 "awkgram.y" /* yacc.c:1651 */ { want_param_names = FUNC_HEADER; } -#line 2192 "awkgram.c" /* yacc.c:1651 */ +#line 2228 "awkgram.c" /* yacc.c:1651 */ break; case 33: -#line 439 "awkgram.y" /* yacc.c:1651 */ +#line 483 "awkgram.y" /* yacc.c:1651 */ { - /* - * treat any comments between BOF and the first function - * definition (with no intervening BEGIN etc block) as - * program comments. Special kludge: iff there are more - * than one such comments, treat the last as a function - * comment. - */ - if (prior_comment != NULL) { - comment_to_save = prior_comment; - prior_comment = NULL; - } else if (comment != NULL) { - comment_to_save = comment; - comment = NULL; - } else - comment_to_save = NULL; - - if (comment_to_save != NULL && func_first - && strstr(comment_to_save->memory->stptr, "\n\n") != NULL) - split_comment(); - - /* save any other pre-function comment as function comment */ - if (comment_to_save != NULL) { - function_comment = comment_to_save; - comment_to_save = NULL; + INSTRUCTION *func_comment = NULL; + // Merge any comments found in the parameter list with those + // following the function header, associate the whole shebang + // with the function as one block comment. + if ((yyvsp[-2]) != NULL && (yyvsp[-2])->comment != NULL) { + if ((yyvsp[0]) != NULL) { + merge_comments((yyvsp[-2])->comment, (yyvsp[0])); + } + func_comment = (yyvsp[-2])->comment; + } else if ((yyvsp[0]) != NULL) { + func_comment = (yyvsp[0]); } - func_first = false; + (yyvsp[-6])->source_file = source; + (yyvsp[-6])->comment = func_comment; if (install_function((yyvsp[-5])->lextok, (yyvsp[-6]), (yyvsp[-2])) < 0) YYABORT; in_function = (yyvsp[-5])->lextok; @@ -2230,17 +2254,17 @@ yyreduce: (yyval) = (yyvsp[-6]); want_param_names = FUNC_BODY; } -#line 2234 "awkgram.c" /* yacc.c:1651 */ +#line 2258 "awkgram.c" /* yacc.c:1651 */ break; case 34: -#line 484 "awkgram.y" /* yacc.c:1651 */ +#line 516 "awkgram.y" /* yacc.c:1651 */ { want_regexp = true; } -#line 2240 "awkgram.c" /* yacc.c:1651 */ +#line 2264 "awkgram.c" /* yacc.c:1651 */ break; case 35: -#line 486 "awkgram.y" /* yacc.c:1651 */ +#line 518 "awkgram.y" /* yacc.c:1651 */ { NODE *n, *exp; char *re; @@ -2269,11 +2293,11 @@ yyreduce: (yyval)->opcode = Op_match_rec; (yyval)->memory = n; } -#line 2273 "awkgram.c" /* yacc.c:1651 */ +#line 2297 "awkgram.c" /* yacc.c:1651 */ break; case 36: -#line 518 "awkgram.y" /* yacc.c:1651 */ +#line 550 "awkgram.y" /* yacc.c:1651 */ { char *re; size_t len; @@ -2286,112 +2310,93 @@ yyreduce: (yyval)->opcode = Op_push_re; (yyval)->memory = make_typed_regex(re, len); } -#line 2290 "awkgram.c" /* yacc.c:1651 */ +#line 2314 "awkgram.c" /* yacc.c:1651 */ break; case 37: -#line 533 "awkgram.y" /* yacc.c:1651 */ +#line 565 "awkgram.y" /* yacc.c:1651 */ { bcfree((yyvsp[0])); } -#line 2296 "awkgram.c" /* yacc.c:1651 */ +#line 2320 "awkgram.c" /* yacc.c:1651 */ break; case 39: -#line 539 "awkgram.y" /* yacc.c:1651 */ - { - if (prior_comment != NULL) { - (yyval) = list_create(prior_comment); - prior_comment = NULL; - } else if (comment != NULL) { - (yyval) = list_create(comment); - comment = NULL; - } else - (yyval) = NULL; - } -#line 2311 "awkgram.c" /* yacc.c:1651 */ +#line 571 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = NULL; } +#line 2326 "awkgram.c" /* yacc.c:1651 */ break; case 40: -#line 550 "awkgram.y" /* yacc.c:1651 */ +#line 573 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[0]) == NULL) { - if (prior_comment != NULL) { - (yyval) = list_append((yyvsp[-1]), prior_comment); - prior_comment = NULL; - if (comment != NULL) { - (yyval) = list_append((yyval), comment); - comment = NULL; - } - } else if (comment != NULL) { - (yyval) = list_append((yyvsp[-1]), comment); - comment = NULL; - } else - (yyval) = (yyvsp[-1]); + (yyval) = (yyvsp[-1]); } else { add_lint((yyvsp[0]), LINT_no_effect); if ((yyvsp[-1]) == NULL) { - if (prior_comment != NULL) { - (yyval) = list_append((yyvsp[0]), prior_comment); - prior_comment = NULL; - if (comment != NULL) { - (yyval) = list_append((yyval), comment); - comment = NULL; - } - } else if (comment != NULL) { - (yyval) = list_append((yyvsp[0]), comment); - comment = NULL; - } else - (yyval) = (yyvsp[0]); + (yyval) = (yyvsp[0]); } else { - if (prior_comment != NULL) { - list_append((yyvsp[0]), prior_comment); - prior_comment = NULL; - if (comment != NULL) { - list_append((yyvsp[0]), comment); - comment = NULL; - } - } else if (comment != NULL) { - list_append((yyvsp[0]), comment); - comment = NULL; - } (yyval) = list_merge((yyvsp[-1]), (yyvsp[0])); } } yyerrok; } -#line 2362 "awkgram.c" /* yacc.c:1651 */ +#line 2344 "awkgram.c" /* yacc.c:1651 */ break; case 41: -#line 597 "awkgram.y" /* yacc.c:1651 */ +#line 587 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 2368 "awkgram.c" /* yacc.c:1651 */ +#line 2350 "awkgram.c" /* yacc.c:1651 */ + break; + + case 42: +#line 591 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = (yyvsp[0]); } +#line 2356 "awkgram.c" /* yacc.c:1651 */ + break; + + case 43: +#line 592 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = (yyvsp[0]); } +#line 2362 "awkgram.c" /* yacc.c:1651 */ break; case 44: -#line 607 "awkgram.y" /* yacc.c:1651 */ - { (yyval) = NULL; } -#line 2374 "awkgram.c" /* yacc.c:1651 */ +#line 597 "awkgram.y" /* yacc.c:1651 */ + { + if ((yyvsp[0]) != NULL) { + INSTRUCTION *ip; + + merge_comments((yyvsp[0]), NULL); + ip = list_create(instruction(Op_no_op)); + (yyval) = list_append(ip, (yyvsp[0])); + } else + (yyval) = NULL; + } +#line 2377 "awkgram.c" /* yacc.c:1651 */ break; case 45: -#line 609 "awkgram.y" /* yacc.c:1651 */ - { (yyval) = (yyvsp[-1]); } -#line 2380 "awkgram.c" /* yacc.c:1651 */ +#line 608 "awkgram.y" /* yacc.c:1651 */ + { + (yyval) = make_braced_statements((yyvsp[-2]), (yyvsp[-1]), (yyvsp[0])); + } +#line 2385 "awkgram.c" /* yacc.c:1651 */ break; case 46: -#line 611 "awkgram.y" /* yacc.c:1651 */ +#line 612 "awkgram.y" /* yacc.c:1651 */ { if (do_pretty_print) (yyval) = list_prepend((yyvsp[0]), instruction(Op_exec_count)); else (yyval) = (yyvsp[0]); } -#line 2391 "awkgram.c" /* yacc.c:1651 */ +#line 2396 "awkgram.c" /* yacc.c:1651 */ break; case 47: -#line 618 "awkgram.y" /* yacc.c:1651 */ +#line 619 "awkgram.y" /* yacc.c:1651 */ { INSTRUCTION *dflt, *curr = NULL, *cexp, *cstmt; INSTRUCTION *ip, *nextc, *tbreak; @@ -2409,8 +2414,9 @@ yyreduce: if ((yyvsp[-2]) != NULL) { curr = (yyvsp[-2])->nexti; bcfree((yyvsp[-2])); /* Op_list */ - } /* else - curr = NULL; */ + } + /* else + curr = NULL; */ for (; curr != NULL; curr = nextc) { INSTRUCTION *caseexp = curr->case_exp; @@ -2466,26 +2472,43 @@ yyreduce: ip = (yyvsp[-6]); if (do_pretty_print) { + // first merge comments + INSTRUCTION *head_comment = NULL; + + if ((yyvsp[-4]) != NULL && (yyvsp[-3]) != NULL) { + merge_comments((yyvsp[-4]), (yyvsp[-3])); + head_comment = (yyvsp[-4]); + } else if ((yyvsp[-4]) != NULL) + head_comment = (yyvsp[-4]); + else + head_comment = (yyvsp[-3]); + + (yyvsp[-8])->comment = head_comment; + (void) list_prepend(ip, (yyvsp[-8])); (void) list_prepend(ip, instruction(Op_exec_count)); (yyvsp[-8])->target_break = tbreak; ((yyvsp[-8]) + 1)->switch_start = cexp->nexti; ((yyvsp[-8]) + 1)->switch_end = cexp->lasti; - }/* else - $1 is NULL */ + ((yyvsp[-8]) + 1)->switch_end->comment = (yyvsp[0]); + } + /* else + $1 is NULL */ (void) list_append(cexp, dflt); (void) list_merge(ip, cexp); + if ((yyvsp[-1]) != NULL) + (void) list_append(cstmt, (yyvsp[-1])); (yyval) = list_merge(ip, cstmt); break_allowed--; fix_break_continue(ip, tbreak, NULL); } -#line 2485 "awkgram.c" /* yacc.c:1651 */ +#line 2508 "awkgram.c" /* yacc.c:1651 */ break; case 48: -#line 708 "awkgram.y" /* yacc.c:1651 */ +#line 727 "awkgram.y" /* yacc.c:1651 */ { /* * ----------------- @@ -2514,8 +2537,17 @@ yyreduce: (yyvsp[-5])->target_continue = tcont; ((yyvsp[-5]) + 1)->while_body = ip->lasti; (void) list_prepend(ip, (yyvsp[-5])); - }/* else - $1 is NULL */ + } + /* else + $1 is NULL */ + + if ((yyvsp[-1]) != NULL) { + if ((yyvsp[0]) == NULL) + (yyvsp[0]) = list_create(instruction(Op_no_op)); + + (yyvsp[-1])->memory->comment_type = BLOCK_COMMENT; + (yyvsp[0]) = list_prepend((yyvsp[0]), (yyvsp[-1])); + } if ((yyvsp[0]) != NULL) (void) list_merge(ip, (yyvsp[0])); @@ -2527,11 +2559,11 @@ yyreduce: continue_allowed--; fix_break_continue(ip, tbreak, tcont); } -#line 2531 "awkgram.c" /* yacc.c:1651 */ +#line 2563 "awkgram.c" /* yacc.c:1651 */ break; case 49: -#line 750 "awkgram.y" /* yacc.c:1651 */ +#line 778 "awkgram.y" /* yacc.c:1651 */ { /* * ----------------- @@ -2554,8 +2586,13 @@ yyreduce: ip = list_merge((yyvsp[-5]), (yyvsp[-2])); else ip = list_prepend((yyvsp[-2]), instruction(Op_no_op)); + + if ((yyvsp[-6]) != NULL) + (void) list_prepend(ip, (yyvsp[-6])); + if (do_pretty_print) (void) list_prepend(ip, instruction(Op_exec_count)); + (void) list_append(ip, instruction(Op_jmp_true)); ip->lasti->target_jmp = ip->nexti; (yyval) = list_append(ip, tbreak); @@ -2570,14 +2607,17 @@ yyreduce: ((yyvsp[-7]) + 1)->doloop_cond = tcont; (yyval) = list_prepend(ip, (yyvsp[-7])); bcfree((yyvsp[-4])); - } /* else + if ((yyvsp[0]) != NULL) + (yyvsp[-7])->comment = (yyvsp[0]); + } + /* else $1 and $4 are NULLs */ } -#line 2577 "awkgram.c" /* yacc.c:1651 */ +#line 2617 "awkgram.c" /* yacc.c:1651 */ break; case 50: -#line 792 "awkgram.y" /* yacc.c:1651 */ +#line 828 "awkgram.y" /* yacc.c:1651 */ { INSTRUCTION *ip; char *var_name = (yyvsp[-5])->lextok; @@ -2590,7 +2630,8 @@ yyreduce: && strcmp((yyvsp[0])->nexti->memory->vname, var_name) == 0 ) { - /* Efficiency hack. Recognize the special case of + /* + * Efficiency hack. Recognize the special case of * * for (iggy in foo) * delete foo[iggy] @@ -2622,6 +2663,10 @@ yyreduce: bcfree((yyvsp[-5])); bcfree((yyvsp[-4])); bcfree((yyvsp[-3])); + if ((yyvsp[-1]) != NULL) { + merge_comments((yyvsp[-1]), NULL); + (yyvsp[0]) = list_prepend((yyvsp[0]), (yyvsp[-1])); + } (yyval) = (yyvsp[0]); } else goto regular_loop; @@ -2656,8 +2701,9 @@ regular_loop: (yyvsp[-7])->target_continue = tcont; (yyvsp[-7])->target_break = tbreak; (void) list_append(ip, (yyvsp[-7])); - } /* else - $1 is NULL */ + } + /* else + $1 is NULL */ /* add update_FOO instruction if necessary */ if ((yyvsp[-4])->array_var->type == Node_var && (yyvsp[-4])->array_var->var_update) { @@ -2678,8 +2724,15 @@ regular_loop: ((yyvsp[-7]) + 1)->forloop_body = ip->lasti; } - if ((yyvsp[0]) != NULL) + if ((yyvsp[-1]) != NULL) + merge_comments((yyvsp[-1]), NULL); + + if ((yyvsp[0]) != NULL) { + if ((yyvsp[-1]) != NULL) + (yyvsp[0]) = list_prepend((yyvsp[0]), (yyvsp[-1])); (void) list_merge(ip, (yyvsp[0])); + } else if ((yyvsp[-1]) != NULL) + (void) list_append(ip, (yyvsp[-1])); (void) list_append(ip, instruction(Op_jmp)); ip->lasti->target_jmp = (yyvsp[-4]); @@ -2690,73 +2743,100 @@ regular_loop: break_allowed--; continue_allowed--; } -#line 2694 "awkgram.c" /* yacc.c:1651 */ +#line 2747 "awkgram.c" /* yacc.c:1651 */ break; case 51: -#line 905 "awkgram.y" /* yacc.c:1651 */ +#line 954 "awkgram.y" /* yacc.c:1651 */ { + if ((yyvsp[-7]) != NULL) { + merge_comments((yyvsp[-7]), NULL); + (yyvsp[-11])->comment = (yyvsp[-7]); + } + if ((yyvsp[-4]) != NULL) { + merge_comments((yyvsp[-4]), NULL); + if ((yyvsp[-11])->comment == NULL) { + (yyvsp[-4])->memory->comment_type = FOR_COMMENT; + (yyvsp[-11])->comment = (yyvsp[-4]); + } else + (yyvsp[-11])->comment->comment = (yyvsp[-4]); + } + if ((yyvsp[-1]) != NULL) + (yyvsp[0]) = list_prepend((yyvsp[0]), (yyvsp[-1])); (yyval) = mk_for_loop((yyvsp[-11]), (yyvsp[-9]), (yyvsp[-6]), (yyvsp[-3]), (yyvsp[0])); break_allowed--; continue_allowed--; } -#line 2705 "awkgram.c" /* yacc.c:1651 */ +#line 2772 "awkgram.c" /* yacc.c:1651 */ break; case 52: -#line 912 "awkgram.y" /* yacc.c:1651 */ +#line 975 "awkgram.y" /* yacc.c:1651 */ { + if ((yyvsp[-6]) != NULL) { + merge_comments((yyvsp[-6]), NULL); + (yyvsp[-10])->comment = (yyvsp[-6]); + } + if ((yyvsp[-4]) != NULL) { + merge_comments((yyvsp[-4]), NULL); + if ((yyvsp[-10])->comment == NULL) { + (yyvsp[-4])->memory->comment_type = FOR_COMMENT; + (yyvsp[-10])->comment = (yyvsp[-4]); + } else + (yyvsp[-10])->comment->comment = (yyvsp[-4]); + } + if ((yyvsp[-1]) != NULL) + (yyvsp[0]) = list_prepend((yyvsp[0]), (yyvsp[-1])); (yyval) = mk_for_loop((yyvsp[-10]), (yyvsp[-8]), (INSTRUCTION *) NULL, (yyvsp[-3]), (yyvsp[0])); break_allowed--; continue_allowed--; } -#line 2716 "awkgram.c" /* yacc.c:1651 */ +#line 2797 "awkgram.c" /* yacc.c:1651 */ break; case 53: -#line 919 "awkgram.y" /* yacc.c:1651 */ +#line 996 "awkgram.y" /* yacc.c:1651 */ { if (do_pretty_print) (yyval) = list_prepend((yyvsp[0]), instruction(Op_exec_count)); else (yyval) = (yyvsp[0]); - (yyval) = add_pending_comment((yyval)); } -#line 2728 "awkgram.c" /* yacc.c:1651 */ +#line 2808 "awkgram.c" /* yacc.c:1651 */ break; case 54: -#line 930 "awkgram.y" /* yacc.c:1651 */ +#line 1006 "awkgram.y" /* yacc.c:1651 */ { if (! break_allowed) error_ln((yyvsp[-1])->source_line, _("`break' is not allowed outside a loop or switch")); (yyvsp[-1])->target_jmp = NULL; (yyval) = list_create((yyvsp[-1])); - (yyval) = add_pending_comment((yyval)); - + if ((yyvsp[0]) != NULL) + (yyval) = list_append((yyval), (yyvsp[0])); } -#line 2742 "awkgram.c" /* yacc.c:1651 */ +#line 2822 "awkgram.c" /* yacc.c:1651 */ break; case 55: -#line 940 "awkgram.y" /* yacc.c:1651 */ +#line 1016 "awkgram.y" /* yacc.c:1651 */ { if (! continue_allowed) error_ln((yyvsp[-1])->source_line, _("`continue' is not allowed outside a loop")); (yyvsp[-1])->target_jmp = NULL; (yyval) = list_create((yyvsp[-1])); - (yyval) = add_pending_comment((yyval)); - + if ((yyvsp[0]) != NULL) + (yyval) = list_append((yyval), (yyvsp[0])); } -#line 2756 "awkgram.c" /* yacc.c:1651 */ +#line 2836 "awkgram.c" /* yacc.c:1651 */ break; case 56: -#line 950 "awkgram.y" /* yacc.c:1651 */ +#line 1026 "awkgram.y" /* yacc.c:1651 */ { /* if inside function (rule = 0), resolve context at run-time */ if (rule && rule != Rule) @@ -2764,13 +2844,14 @@ regular_loop: _("`next' used in %s action"), ruletab[rule]); (yyvsp[-1])->target_jmp = ip_rec; (yyval) = list_create((yyvsp[-1])); - (yyval) = add_pending_comment((yyval)); + if ((yyvsp[0]) != NULL) + (yyval) = list_append((yyval), (yyvsp[0])); } -#line 2770 "awkgram.c" /* yacc.c:1651 */ +#line 2851 "awkgram.c" /* yacc.c:1651 */ break; case 57: -#line 960 "awkgram.y" /* yacc.c:1651 */ +#line 1037 "awkgram.y" /* yacc.c:1651 */ { /* if inside function (rule = 0), resolve context at run-time */ if (rule == BEGIN || rule == END || rule == ENDFILE) @@ -2780,13 +2861,14 @@ regular_loop: (yyvsp[-1])->target_newfile = ip_newfile; (yyvsp[-1])->target_endfile = ip_endfile; (yyval) = list_create((yyvsp[-1])); - (yyval) = add_pending_comment((yyval)); + if ((yyvsp[0]) != NULL) + (yyval) = list_append((yyval), (yyvsp[0])); } -#line 2786 "awkgram.c" /* yacc.c:1651 */ +#line 2868 "awkgram.c" /* yacc.c:1651 */ break; case 58: -#line 972 "awkgram.y" /* yacc.c:1651 */ +#line 1050 "awkgram.y" /* yacc.c:1651 */ { /* Initialize the two possible jump targets, the actual target * is resolved at run-time. @@ -2800,22 +2882,23 @@ regular_loop: (yyval)->nexti->memory = dupnode(Nnull_string); } else (yyval) = list_append((yyvsp[-1]), (yyvsp[-2])); - (yyval) = add_pending_comment((yyval)); + if ((yyvsp[0]) != NULL) + (yyval) = list_append((yyval), (yyvsp[0])); } -#line 2806 "awkgram.c" /* yacc.c:1651 */ +#line 2889 "awkgram.c" /* yacc.c:1651 */ break; case 59: -#line 988 "awkgram.y" /* yacc.c:1651 */ +#line 1067 "awkgram.y" /* yacc.c:1651 */ { if (! in_function) yyerror(_("`return' used outside function context")); } -#line 2815 "awkgram.c" /* yacc.c:1651 */ +#line 2898 "awkgram.c" /* yacc.c:1651 */ break; case 60: -#line 991 "awkgram.y" /* yacc.c:1651 */ +#line 1070 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[-1]) == NULL) { (yyval) = list_create((yyvsp[-3])); @@ -2823,20 +2906,31 @@ regular_loop: (yyval)->nexti->memory = dupnode(Nnull_string); } else (yyval) = list_append((yyvsp[-1]), (yyvsp[-3])); + if ((yyvsp[0]) != NULL) + (yyval) = list_append((yyval), (yyvsp[0])); + } +#line 2913 "awkgram.c" /* yacc.c:1651 */ + break; - (yyval) = add_pending_comment((yyval)); + case 61: +#line 1081 "awkgram.y" /* yacc.c:1651 */ + { + if ((yyvsp[0]) != NULL) + (yyval) = list_append((yyvsp[-1]), (yyvsp[0])); + else + (yyval) = (yyvsp[-1]); } -#line 2830 "awkgram.c" /* yacc.c:1651 */ +#line 2924 "awkgram.c" /* yacc.c:1651 */ break; case 62: -#line 1013 "awkgram.y" /* yacc.c:1651 */ +#line 1098 "awkgram.y" /* yacc.c:1651 */ { in_print = true; in_parens = 0; } -#line 2836 "awkgram.c" /* yacc.c:1651 */ +#line 2930 "awkgram.c" /* yacc.c:1651 */ break; case 63: -#line 1014 "awkgram.y" /* yacc.c:1651 */ +#line 1099 "awkgram.y" /* yacc.c:1651 */ { /* * Optimization: plain `print' has no expression list, so $3 is null. @@ -2844,7 +2938,7 @@ regular_loop: * which is faster for these two cases. */ - if ((yyvsp[-3])->opcode == Op_K_print && + if (do_optimize && (yyvsp[-3])->opcode == Op_K_print && ((yyvsp[-1]) == NULL || ((yyvsp[-1])->lasti->opcode == Op_field_spec && (yyvsp[-1])->nexti->nexti->nexti == (yyvsp[-1])->lasti @@ -2932,19 +3026,18 @@ regular_print: } } } - (yyval) = add_pending_comment((yyval)); } -#line 2938 "awkgram.c" /* yacc.c:1651 */ +#line 3031 "awkgram.c" /* yacc.c:1651 */ break; case 64: -#line 1112 "awkgram.y" /* yacc.c:1651 */ +#line 1196 "awkgram.y" /* yacc.c:1651 */ { sub_counter = 0; } -#line 2944 "awkgram.c" /* yacc.c:1651 */ +#line 3037 "awkgram.c" /* yacc.c:1651 */ break; case 65: -#line 1113 "awkgram.y" /* yacc.c:1651 */ +#line 1197 "awkgram.y" /* yacc.c:1651 */ { char *arr = (yyvsp[-2])->lextok; @@ -2976,13 +3069,12 @@ regular_print: (yyvsp[-3])->expr_count = sub_counter; (yyval) = list_append(list_append((yyvsp[0]), (yyvsp[-2])), (yyvsp[-3])); } - (yyval) = add_pending_comment((yyval)); } -#line 2982 "awkgram.c" /* yacc.c:1651 */ +#line 3074 "awkgram.c" /* yacc.c:1651 */ break; case 66: -#line 1151 "awkgram.y" /* yacc.c:1651 */ +#line 1234 "awkgram.y" /* yacc.c:1651 */ { static bool warned = false; char *arr = (yyvsp[-1])->lextok; @@ -3007,57 +3099,55 @@ regular_print: else if ((yyvsp[-1])->memory == func_table) fatal(_("`delete' is not allowed with FUNCTAB")); } - (yyval) = add_pending_comment((yyval)); } -#line 3013 "awkgram.c" /* yacc.c:1651 */ +#line 3104 "awkgram.c" /* yacc.c:1651 */ break; case 67: -#line 1178 "awkgram.y" /* yacc.c:1651 */ +#line 1260 "awkgram.y" /* yacc.c:1651 */ { (yyval) = optimize_assignment((yyvsp[0])); - (yyval) = add_pending_comment((yyval)); } -#line 3022 "awkgram.c" /* yacc.c:1651 */ +#line 3112 "awkgram.c" /* yacc.c:1651 */ break; case 68: -#line 1186 "awkgram.y" /* yacc.c:1651 */ +#line 1267 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3028 "awkgram.c" /* yacc.c:1651 */ +#line 3118 "awkgram.c" /* yacc.c:1651 */ break; case 69: -#line 1188 "awkgram.y" /* yacc.c:1651 */ +#line 1269 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3034 "awkgram.c" /* yacc.c:1651 */ +#line 3124 "awkgram.c" /* yacc.c:1651 */ break; case 70: -#line 1193 "awkgram.y" /* yacc.c:1651 */ +#line 1274 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3040 "awkgram.c" /* yacc.c:1651 */ +#line 3130 "awkgram.c" /* yacc.c:1651 */ break; case 71: -#line 1195 "awkgram.y" /* yacc.c:1651 */ +#line 1276 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[-1]) == NULL) (yyval) = list_create((yyvsp[0])); else (yyval) = list_prepend((yyvsp[-1]), (yyvsp[0])); } -#line 3051 "awkgram.c" /* yacc.c:1651 */ +#line 3141 "awkgram.c" /* yacc.c:1651 */ break; case 72: -#line 1202 "awkgram.y" /* yacc.c:1651 */ +#line 1283 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3057 "awkgram.c" /* yacc.c:1651 */ +#line 3147 "awkgram.c" /* yacc.c:1651 */ break; case 73: -#line 1207 "awkgram.y" /* yacc.c:1651 */ +#line 1288 "awkgram.y" /* yacc.c:1651 */ { INSTRUCTION *casestmt = (yyvsp[0]); if ((yyvsp[0]) == NULL) @@ -3066,14 +3156,15 @@ regular_print: (void) list_prepend(casestmt, instruction(Op_exec_count)); (yyvsp[-4])->case_exp = (yyvsp[-3]); (yyvsp[-4])->case_stmt = casestmt; + (yyvsp[-4])->comment = (yyvsp[-1]); bcfree((yyvsp[-2])); (yyval) = (yyvsp[-4]); } -#line 3073 "awkgram.c" /* yacc.c:1651 */ +#line 3164 "awkgram.c" /* yacc.c:1651 */ break; case 74: -#line 1219 "awkgram.y" /* yacc.c:1651 */ +#line 1301 "awkgram.y" /* yacc.c:1651 */ { INSTRUCTION *casestmt = (yyvsp[0]); if ((yyvsp[0]) == NULL) @@ -3082,19 +3173,20 @@ regular_print: (void) list_prepend(casestmt, instruction(Op_exec_count)); bcfree((yyvsp[-2])); (yyvsp[-3])->case_stmt = casestmt; + (yyvsp[-3])->comment = (yyvsp[-1]); (yyval) = (yyvsp[-3]); } -#line 3088 "awkgram.c" /* yacc.c:1651 */ +#line 3180 "awkgram.c" /* yacc.c:1651 */ break; case 75: -#line 1233 "awkgram.y" /* yacc.c:1651 */ +#line 1316 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3094 "awkgram.c" /* yacc.c:1651 */ +#line 3186 "awkgram.c" /* yacc.c:1651 */ break; case 76: -#line 1235 "awkgram.y" /* yacc.c:1651 */ +#line 1318 "awkgram.y" /* yacc.c:1651 */ { NODE *n = (yyvsp[0])->memory; (void) force_number(n); @@ -3102,28 +3194,28 @@ regular_print: bcfree((yyvsp[-1])); (yyval) = (yyvsp[0]); } -#line 3106 "awkgram.c" /* yacc.c:1651 */ +#line 3198 "awkgram.c" /* yacc.c:1651 */ break; case 77: -#line 1243 "awkgram.y" /* yacc.c:1651 */ +#line 1326 "awkgram.y" /* yacc.c:1651 */ { NODE *n = (yyvsp[0])->lasti->memory; bcfree((yyvsp[-1])); add_sign_to_num(n, '+'); (yyval) = (yyvsp[0]); } -#line 3117 "awkgram.c" /* yacc.c:1651 */ +#line 3209 "awkgram.c" /* yacc.c:1651 */ break; case 78: -#line 1250 "awkgram.y" /* yacc.c:1651 */ +#line 1333 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3123 "awkgram.c" /* yacc.c:1651 */ +#line 3215 "awkgram.c" /* yacc.c:1651 */ break; case 79: -#line 1252 "awkgram.y" /* yacc.c:1651 */ +#line 1335 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[0])->memory->type == Node_regex) (yyvsp[0])->opcode = Op_push_re; @@ -3131,57 +3223,57 @@ regular_print: (yyvsp[0])->opcode = Op_push; (yyval) = (yyvsp[0]); } -#line 3135 "awkgram.c" /* yacc.c:1651 */ +#line 3227 "awkgram.c" /* yacc.c:1651 */ break; case 80: -#line 1260 "awkgram.y" /* yacc.c:1651 */ +#line 1343 "awkgram.y" /* yacc.c:1651 */ { assert(((yyvsp[0])->memory->flags & REGEX) == REGEX); (yyvsp[0])->opcode = Op_push_re; (yyval) = (yyvsp[0]); } -#line 3145 "awkgram.c" /* yacc.c:1651 */ +#line 3237 "awkgram.c" /* yacc.c:1651 */ break; case 81: -#line 1269 "awkgram.y" /* yacc.c:1651 */ +#line 1352 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3151 "awkgram.c" /* yacc.c:1651 */ +#line 3243 "awkgram.c" /* yacc.c:1651 */ break; case 82: -#line 1271 "awkgram.y" /* yacc.c:1651 */ +#line 1354 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3157 "awkgram.c" /* yacc.c:1651 */ +#line 3249 "awkgram.c" /* yacc.c:1651 */ break; case 84: -#line 1281 "awkgram.y" /* yacc.c:1651 */ +#line 1364 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[-1]); } -#line 3165 "awkgram.c" /* yacc.c:1651 */ +#line 3257 "awkgram.c" /* yacc.c:1651 */ break; case 85: -#line 1288 "awkgram.y" /* yacc.c:1651 */ +#line 1371 "awkgram.y" /* yacc.c:1651 */ { in_print = false; in_parens = 0; (yyval) = NULL; } -#line 3175 "awkgram.c" /* yacc.c:1651 */ +#line 3267 "awkgram.c" /* yacc.c:1651 */ break; case 86: -#line 1293 "awkgram.y" /* yacc.c:1651 */ +#line 1376 "awkgram.y" /* yacc.c:1651 */ { in_print = false; in_parens = 0; } -#line 3181 "awkgram.c" /* yacc.c:1651 */ +#line 3273 "awkgram.c" /* yacc.c:1651 */ break; case 87: -#line 1294 "awkgram.y" /* yacc.c:1651 */ +#line 1377 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[-2])->redir_type == redirect_twoway && (yyvsp[0])->lasti->opcode == Op_K_getline_redir @@ -3191,139 +3283,193 @@ regular_print: lintwarn(_("concatenation as I/O `>' redirection target is ambiguous")); (yyval) = list_prepend((yyvsp[0]), (yyvsp[-2])); } -#line 3195 "awkgram.c" /* yacc.c:1651 */ +#line 3287 "awkgram.c" /* yacc.c:1651 */ break; case 88: -#line 1307 "awkgram.y" /* yacc.c:1651 */ +#line 1390 "awkgram.y" /* yacc.c:1651 */ { + if ((yyvsp[-1]) != NULL) + (yyvsp[-5])->comment = (yyvsp[-1]); (yyval) = mk_condition((yyvsp[-3]), (yyvsp[-5]), (yyvsp[0]), NULL, NULL); } -#line 3203 "awkgram.c" /* yacc.c:1651 */ +#line 3297 "awkgram.c" /* yacc.c:1651 */ break; case 89: -#line 1312 "awkgram.y" /* yacc.c:1651 */ +#line 1397 "awkgram.y" /* yacc.c:1651 */ { + if ((yyvsp[-4]) != NULL) + (yyvsp[-8])->comment = (yyvsp[-4]); + if ((yyvsp[-1]) != NULL) + (yyvsp[-2])->comment = (yyvsp[-1]); (yyval) = mk_condition((yyvsp[-6]), (yyvsp[-8]), (yyvsp[-3]), (yyvsp[-2]), (yyvsp[0])); } -#line 3211 "awkgram.c" /* yacc.c:1651 */ +#line 3309 "awkgram.c" /* yacc.c:1651 */ + break; + + case 90: +#line 1407 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = (yyvsp[0]); } +#line 3315 "awkgram.c" /* yacc.c:1651 */ + break; + + case 91: +#line 1409 "awkgram.y" /* yacc.c:1651 */ + { + if ((yyvsp[-1]) != NULL && (yyvsp[0]) != NULL) { + if ((yyvsp[-1])->memory->comment_type == EOL_COMMENT) { + assert((yyvsp[0])->memory->comment_type == BLOCK_COMMENT); + (yyvsp[-1])->comment = (yyvsp[0]); // chain them + } else { + merge_comments((yyvsp[-1]), (yyvsp[0])); + } + + (yyval) = (yyvsp[-1]); + } else if ((yyvsp[-1]) != NULL) { + (yyval) = (yyvsp[-1]); + } else if ((yyvsp[0]) != NULL) { + (yyval) = (yyvsp[0]); + } else + (yyval) = NULL; + } +#line 3337 "awkgram.c" /* yacc.c:1651 */ + break; + + case 92: +#line 1430 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = NULL; } +#line 3343 "awkgram.c" /* yacc.c:1651 */ + break; + + case 93: +#line 1432 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = (yyvsp[0]); } +#line 3349 "awkgram.c" /* yacc.c:1651 */ break; case 94: -#line 1329 "awkgram.y" /* yacc.c:1651 */ +#line 1437 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3217 "awkgram.c" /* yacc.c:1651 */ +#line 3355 "awkgram.c" /* yacc.c:1651 */ break; case 95: -#line 1331 "awkgram.y" /* yacc.c:1651 */ +#line 1439 "awkgram.y" /* yacc.c:1651 */ { bcfree((yyvsp[-1])); (yyval) = (yyvsp[0]); } -#line 3226 "awkgram.c" /* yacc.c:1651 */ +#line 3364 "awkgram.c" /* yacc.c:1651 */ break; case 96: -#line 1339 "awkgram.y" /* yacc.c:1651 */ +#line 1447 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3232 "awkgram.c" /* yacc.c:1651 */ +#line 3370 "awkgram.c" /* yacc.c:1651 */ break; case 97: -#line 1341 "awkgram.y" /* yacc.c:1651 */ +#line 1449 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3238 "awkgram.c" /* yacc.c:1651 */ +#line 3376 "awkgram.c" /* yacc.c:1651 */ break; case 98: -#line 1346 "awkgram.y" /* yacc.c:1651 */ +#line 1454 "awkgram.y" /* yacc.c:1651 */ { (yyvsp[0])->param_count = 0; (yyval) = list_create((yyvsp[0])); } -#line 3247 "awkgram.c" /* yacc.c:1651 */ +#line 3385 "awkgram.c" /* yacc.c:1651 */ break; case 99: -#line 1351 "awkgram.y" /* yacc.c:1651 */ +#line 1459 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[-2]) != NULL && (yyvsp[0]) != NULL) { - (yyvsp[0])->param_count = (yyvsp[-2])->lasti->param_count + 1; + (yyvsp[0])->param_count = (yyvsp[-2])->lasti->param_count + 1; (yyval) = list_append((yyvsp[-2]), (yyvsp[0])); yyerrok; + + // newlines are allowed after commas, catch any comments + if ((yyvsp[-1]) != NULL) { + if ((yyvsp[-2])->comment != NULL) + merge_comments((yyvsp[-2])->comment, (yyvsp[-1])); + else + (yyvsp[-2])->comment = (yyvsp[-1]); + } } else (yyval) = NULL; } -#line 3260 "awkgram.c" /* yacc.c:1651 */ +#line 3406 "awkgram.c" /* yacc.c:1651 */ break; case 100: -#line 1360 "awkgram.y" /* yacc.c:1651 */ +#line 1476 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3266 "awkgram.c" /* yacc.c:1651 */ +#line 3412 "awkgram.c" /* yacc.c:1651 */ break; case 101: -#line 1362 "awkgram.y" /* yacc.c:1651 */ +#line 1478 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[-1]); } -#line 3272 "awkgram.c" /* yacc.c:1651 */ +#line 3418 "awkgram.c" /* yacc.c:1651 */ break; case 102: -#line 1364 "awkgram.y" /* yacc.c:1651 */ +#line 1480 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[-2]); } -#line 3278 "awkgram.c" /* yacc.c:1651 */ +#line 3424 "awkgram.c" /* yacc.c:1651 */ break; case 103: -#line 1370 "awkgram.y" /* yacc.c:1651 */ +#line 1486 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3284 "awkgram.c" /* yacc.c:1651 */ +#line 3430 "awkgram.c" /* yacc.c:1651 */ break; case 104: -#line 1372 "awkgram.y" /* yacc.c:1651 */ +#line 1488 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3290 "awkgram.c" /* yacc.c:1651 */ +#line 3436 "awkgram.c" /* yacc.c:1651 */ break; case 105: -#line 1377 "awkgram.y" /* yacc.c:1651 */ +#line 1493 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3296 "awkgram.c" /* yacc.c:1651 */ +#line 3442 "awkgram.c" /* yacc.c:1651 */ break; case 106: -#line 1379 "awkgram.y" /* yacc.c:1651 */ +#line 1495 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3302 "awkgram.c" /* yacc.c:1651 */ +#line 3448 "awkgram.c" /* yacc.c:1651 */ break; case 107: -#line 1384 "awkgram.y" /* yacc.c:1651 */ +#line 1500 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_expression_list(NULL, (yyvsp[0])); } -#line 3308 "awkgram.c" /* yacc.c:1651 */ +#line 3454 "awkgram.c" /* yacc.c:1651 */ break; case 108: -#line 1386 "awkgram.y" /* yacc.c:1651 */ +#line 1502 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_expression_list((yyvsp[-2]), (yyvsp[0])); yyerrok; } -#line 3317 "awkgram.c" /* yacc.c:1651 */ +#line 3463 "awkgram.c" /* yacc.c:1651 */ break; case 109: -#line 1391 "awkgram.y" /* yacc.c:1651 */ +#line 1507 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3323 "awkgram.c" /* yacc.c:1651 */ +#line 3469 "awkgram.c" /* yacc.c:1651 */ break; case 110: -#line 1393 "awkgram.y" /* yacc.c:1651 */ +#line 1509 "awkgram.y" /* yacc.c:1651 */ { /* * Returning the expression list instead of NULL lets @@ -3331,62 +3477,62 @@ regular_print: */ (yyval) = (yyvsp[-1]); } -#line 3335 "awkgram.c" /* yacc.c:1651 */ +#line 3481 "awkgram.c" /* yacc.c:1651 */ break; case 111: -#line 1401 "awkgram.y" /* yacc.c:1651 */ +#line 1517 "awkgram.y" /* yacc.c:1651 */ { /* Ditto */ (yyval) = mk_expression_list((yyvsp[-2]), (yyvsp[0])); } -#line 3344 "awkgram.c" /* yacc.c:1651 */ +#line 3490 "awkgram.c" /* yacc.c:1651 */ break; case 112: -#line 1406 "awkgram.y" /* yacc.c:1651 */ +#line 1522 "awkgram.y" /* yacc.c:1651 */ { /* Ditto */ (yyval) = (yyvsp[-2]); } -#line 3353 "awkgram.c" /* yacc.c:1651 */ +#line 3499 "awkgram.c" /* yacc.c:1651 */ break; case 113: -#line 1414 "awkgram.y" /* yacc.c:1651 */ +#line 1530 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3359 "awkgram.c" /* yacc.c:1651 */ +#line 3505 "awkgram.c" /* yacc.c:1651 */ break; case 114: -#line 1416 "awkgram.y" /* yacc.c:1651 */ +#line 1532 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3365 "awkgram.c" /* yacc.c:1651 */ +#line 3511 "awkgram.c" /* yacc.c:1651 */ break; case 115: -#line 1421 "awkgram.y" /* yacc.c:1651 */ +#line 1537 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_expression_list(NULL, (yyvsp[0])); } -#line 3371 "awkgram.c" /* yacc.c:1651 */ +#line 3517 "awkgram.c" /* yacc.c:1651 */ break; case 116: -#line 1423 "awkgram.y" /* yacc.c:1651 */ +#line 1539 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_expression_list((yyvsp[-2]), (yyvsp[0])); yyerrok; } -#line 3380 "awkgram.c" /* yacc.c:1651 */ +#line 3526 "awkgram.c" /* yacc.c:1651 */ break; case 117: -#line 1428 "awkgram.y" /* yacc.c:1651 */ +#line 1544 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 3386 "awkgram.c" /* yacc.c:1651 */ +#line 3532 "awkgram.c" /* yacc.c:1651 */ break; case 118: -#line 1430 "awkgram.y" /* yacc.c:1651 */ +#line 1546 "awkgram.y" /* yacc.c:1651 */ { /* * Returning the expression list instead of NULL lets @@ -3394,72 +3540,72 @@ regular_print: */ (yyval) = (yyvsp[-1]); } -#line 3398 "awkgram.c" /* yacc.c:1651 */ +#line 3544 "awkgram.c" /* yacc.c:1651 */ break; case 119: -#line 1438 "awkgram.y" /* yacc.c:1651 */ +#line 1554 "awkgram.y" /* yacc.c:1651 */ { /* Ditto */ (yyval) = mk_expression_list((yyvsp[-2]), (yyvsp[0])); } -#line 3407 "awkgram.c" /* yacc.c:1651 */ +#line 3553 "awkgram.c" /* yacc.c:1651 */ break; case 120: -#line 1443 "awkgram.y" /* yacc.c:1651 */ +#line 1559 "awkgram.y" /* yacc.c:1651 */ { /* Ditto */ (yyval) = (yyvsp[-2]); } -#line 3416 "awkgram.c" /* yacc.c:1651 */ +#line 3562 "awkgram.c" /* yacc.c:1651 */ break; case 121: -#line 1450 "awkgram.y" /* yacc.c:1651 */ +#line 1566 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3422 "awkgram.c" /* yacc.c:1651 */ +#line 3568 "awkgram.c" /* yacc.c:1651 */ break; case 122: -#line 1451 "awkgram.y" /* yacc.c:1651 */ +#line 1567 "awkgram.y" /* yacc.c:1651 */ { (yyval) = list_create((yyvsp[0])); } -#line 3428 "awkgram.c" /* yacc.c:1651 */ +#line 3574 "awkgram.c" /* yacc.c:1651 */ break; case 123: -#line 1457 "awkgram.y" /* yacc.c:1651 */ +#line 1573 "awkgram.y" /* yacc.c:1651 */ { if (do_lint && (yyvsp[0])->lasti->opcode == Op_match_rec) lintwarn_ln((yyvsp[-1])->source_line, _("regular expression on right of assignment")); (yyval) = mk_assignment((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3439 "awkgram.c" /* yacc.c:1651 */ +#line 3585 "awkgram.c" /* yacc.c:1651 */ break; case 124: -#line 1464 "awkgram.y" /* yacc.c:1651 */ +#line 1580 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_assignment((yyvsp[-2]), list_create((yyvsp[0])), (yyvsp[-1])); } -#line 3447 "awkgram.c" /* yacc.c:1651 */ +#line 3593 "awkgram.c" /* yacc.c:1651 */ break; case 125: -#line 1468 "awkgram.y" /* yacc.c:1651 */ +#line 1584 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_boolean((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3453 "awkgram.c" /* yacc.c:1651 */ +#line 3599 "awkgram.c" /* yacc.c:1651 */ break; case 126: -#line 1470 "awkgram.y" /* yacc.c:1651 */ +#line 1586 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_boolean((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3459 "awkgram.c" /* yacc.c:1651 */ +#line 3605 "awkgram.c" /* yacc.c:1651 */ break; case 127: -#line 1472 "awkgram.y" /* yacc.c:1651 */ +#line 1588 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[-2])->lasti->opcode == Op_match_rec) warning_ln((yyvsp[-1])->source_line, @@ -3472,11 +3618,11 @@ regular_print: bcfree((yyvsp[0])); (yyval) = list_append((yyvsp[-2]), (yyvsp[-1])); } -#line 3476 "awkgram.c" /* yacc.c:1651 */ +#line 3622 "awkgram.c" /* yacc.c:1651 */ break; case 128: -#line 1485 "awkgram.y" /* yacc.c:1651 */ +#line 1601 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[-2])->lasti->opcode == Op_match_rec) warning_ln((yyvsp[-1])->source_line, @@ -3493,11 +3639,11 @@ regular_print: (yyval) = list_append(list_merge((yyvsp[-2]), (yyvsp[0])), (yyvsp[-1])); } } -#line 3497 "awkgram.c" /* yacc.c:1651 */ +#line 3643 "awkgram.c" /* yacc.c:1651 */ break; case 129: -#line 1502 "awkgram.y" /* yacc.c:1651 */ +#line 1618 "awkgram.y" /* yacc.c:1651 */ { if (do_lint_old) warning_ln((yyvsp[-1])->source_line, @@ -3507,91 +3653,91 @@ regular_print: (yyvsp[-1])->expr_count = 1; (yyval) = list_append(list_merge((yyvsp[-2]), (yyvsp[0])), (yyvsp[-1])); } -#line 3511 "awkgram.c" /* yacc.c:1651 */ +#line 3657 "awkgram.c" /* yacc.c:1651 */ break; case 130: -#line 1512 "awkgram.y" /* yacc.c:1651 */ +#line 1628 "awkgram.y" /* yacc.c:1651 */ { if (do_lint && (yyvsp[0])->lasti->opcode == Op_match_rec) lintwarn_ln((yyvsp[-1])->source_line, _("regular expression on right of comparison")); (yyval) = list_append(list_merge((yyvsp[-2]), (yyvsp[0])), (yyvsp[-1])); } -#line 3522 "awkgram.c" /* yacc.c:1651 */ +#line 3668 "awkgram.c" /* yacc.c:1651 */ break; case 131: -#line 1519 "awkgram.y" /* yacc.c:1651 */ +#line 1635 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_condition((yyvsp[-4]), (yyvsp[-3]), (yyvsp[-2]), (yyvsp[-1]), (yyvsp[0])); } -#line 3528 "awkgram.c" /* yacc.c:1651 */ +#line 3674 "awkgram.c" /* yacc.c:1651 */ break; case 132: -#line 1521 "awkgram.y" /* yacc.c:1651 */ +#line 1637 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3534 "awkgram.c" /* yacc.c:1651 */ +#line 3680 "awkgram.c" /* yacc.c:1651 */ break; case 133: -#line 1526 "awkgram.y" /* yacc.c:1651 */ +#line 1642 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3540 "awkgram.c" /* yacc.c:1651 */ +#line 3686 "awkgram.c" /* yacc.c:1651 */ break; case 134: -#line 1528 "awkgram.y" /* yacc.c:1651 */ +#line 1644 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3546 "awkgram.c" /* yacc.c:1651 */ +#line 3692 "awkgram.c" /* yacc.c:1651 */ break; case 135: -#line 1530 "awkgram.y" /* yacc.c:1651 */ +#line 1646 "awkgram.y" /* yacc.c:1651 */ { (yyvsp[0])->opcode = Op_assign_quotient; (yyval) = (yyvsp[0]); } -#line 3555 "awkgram.c" /* yacc.c:1651 */ +#line 3701 "awkgram.c" /* yacc.c:1651 */ break; case 136: -#line 1538 "awkgram.y" /* yacc.c:1651 */ +#line 1654 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3561 "awkgram.c" /* yacc.c:1651 */ +#line 3707 "awkgram.c" /* yacc.c:1651 */ break; case 137: -#line 1540 "awkgram.y" /* yacc.c:1651 */ +#line 1656 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3567 "awkgram.c" /* yacc.c:1651 */ +#line 3713 "awkgram.c" /* yacc.c:1651 */ break; case 138: -#line 1545 "awkgram.y" /* yacc.c:1651 */ +#line 1661 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3573 "awkgram.c" /* yacc.c:1651 */ +#line 3719 "awkgram.c" /* yacc.c:1651 */ break; case 139: -#line 1547 "awkgram.y" /* yacc.c:1651 */ +#line 1663 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3579 "awkgram.c" /* yacc.c:1651 */ +#line 3725 "awkgram.c" /* yacc.c:1651 */ break; case 140: -#line 1552 "awkgram.y" /* yacc.c:1651 */ +#line 1668 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3585 "awkgram.c" /* yacc.c:1651 */ +#line 3731 "awkgram.c" /* yacc.c:1651 */ break; case 141: -#line 1554 "awkgram.y" /* yacc.c:1651 */ +#line 1670 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 3591 "awkgram.c" /* yacc.c:1651 */ +#line 3737 "awkgram.c" /* yacc.c:1651 */ break; case 142: -#line 1556 "awkgram.y" /* yacc.c:1651 */ +#line 1672 "awkgram.y" /* yacc.c:1651 */ { int count = 2; bool is_simple_var = false; @@ -3645,47 +3791,47 @@ regular_print: max_args = count; } } -#line 3649 "awkgram.c" /* yacc.c:1651 */ +#line 3795 "awkgram.c" /* yacc.c:1651 */ break; case 144: -#line 1615 "awkgram.y" /* yacc.c:1651 */ +#line 1731 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3655 "awkgram.c" /* yacc.c:1651 */ +#line 3801 "awkgram.c" /* yacc.c:1651 */ break; case 145: -#line 1617 "awkgram.y" /* yacc.c:1651 */ +#line 1733 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3661 "awkgram.c" /* yacc.c:1651 */ +#line 3807 "awkgram.c" /* yacc.c:1651 */ break; case 146: -#line 1619 "awkgram.y" /* yacc.c:1651 */ +#line 1735 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3667 "awkgram.c" /* yacc.c:1651 */ +#line 3813 "awkgram.c" /* yacc.c:1651 */ break; case 147: -#line 1621 "awkgram.y" /* yacc.c:1651 */ +#line 1737 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3673 "awkgram.c" /* yacc.c:1651 */ +#line 3819 "awkgram.c" /* yacc.c:1651 */ break; case 148: -#line 1623 "awkgram.y" /* yacc.c:1651 */ +#line 1739 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3679 "awkgram.c" /* yacc.c:1651 */ +#line 3825 "awkgram.c" /* yacc.c:1651 */ break; case 149: -#line 1625 "awkgram.y" /* yacc.c:1651 */ +#line 1741 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3685 "awkgram.c" /* yacc.c:1651 */ +#line 3831 "awkgram.c" /* yacc.c:1651 */ break; case 150: -#line 1627 "awkgram.y" /* yacc.c:1651 */ +#line 1743 "awkgram.y" /* yacc.c:1651 */ { /* * In BEGINFILE/ENDFILE, allow `getline [var] < file' @@ -3699,29 +3845,29 @@ regular_print: _("non-redirected `getline' undefined inside END action")); (yyval) = mk_getline((yyvsp[-2]), (yyvsp[-1]), (yyvsp[0]), redirect_input); } -#line 3703 "awkgram.c" /* yacc.c:1651 */ +#line 3849 "awkgram.c" /* yacc.c:1651 */ break; case 151: -#line 1641 "awkgram.y" /* yacc.c:1651 */ +#line 1757 "awkgram.y" /* yacc.c:1651 */ { (yyvsp[0])->opcode = Op_postincrement; (yyval) = mk_assignment((yyvsp[-1]), NULL, (yyvsp[0])); } -#line 3712 "awkgram.c" /* yacc.c:1651 */ +#line 3858 "awkgram.c" /* yacc.c:1651 */ break; case 152: -#line 1646 "awkgram.y" /* yacc.c:1651 */ +#line 1762 "awkgram.y" /* yacc.c:1651 */ { (yyvsp[0])->opcode = Op_postdecrement; (yyval) = mk_assignment((yyvsp[-1]), NULL, (yyvsp[0])); } -#line 3721 "awkgram.c" /* yacc.c:1651 */ +#line 3867 "awkgram.c" /* yacc.c:1651 */ break; case 153: -#line 1651 "awkgram.y" /* yacc.c:1651 */ +#line 1767 "awkgram.y" /* yacc.c:1651 */ { if (do_lint_old) { warning_ln((yyvsp[-1])->source_line, @@ -3741,64 +3887,64 @@ regular_print: (yyval) = list_append(list_merge(t, (yyvsp[0])), (yyvsp[-1])); } } -#line 3745 "awkgram.c" /* yacc.c:1651 */ +#line 3891 "awkgram.c" /* yacc.c:1651 */ break; case 154: -#line 1676 "awkgram.y" /* yacc.c:1651 */ +#line 1792 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_getline((yyvsp[-1]), (yyvsp[0]), (yyvsp[-3]), (yyvsp[-2])->redir_type); bcfree((yyvsp[-2])); } -#line 3754 "awkgram.c" /* yacc.c:1651 */ +#line 3900 "awkgram.c" /* yacc.c:1651 */ break; case 155: -#line 1682 "awkgram.y" /* yacc.c:1651 */ +#line 1798 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3760 "awkgram.c" /* yacc.c:1651 */ +#line 3906 "awkgram.c" /* yacc.c:1651 */ break; case 156: -#line 1684 "awkgram.y" /* yacc.c:1651 */ +#line 1800 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3766 "awkgram.c" /* yacc.c:1651 */ +#line 3912 "awkgram.c" /* yacc.c:1651 */ break; case 157: -#line 1686 "awkgram.y" /* yacc.c:1651 */ +#line 1802 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3772 "awkgram.c" /* yacc.c:1651 */ +#line 3918 "awkgram.c" /* yacc.c:1651 */ break; case 158: -#line 1688 "awkgram.y" /* yacc.c:1651 */ +#line 1804 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3778 "awkgram.c" /* yacc.c:1651 */ +#line 3924 "awkgram.c" /* yacc.c:1651 */ break; case 159: -#line 1690 "awkgram.y" /* yacc.c:1651 */ +#line 1806 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3784 "awkgram.c" /* yacc.c:1651 */ +#line 3930 "awkgram.c" /* yacc.c:1651 */ break; case 160: -#line 1692 "awkgram.y" /* yacc.c:1651 */ +#line 1808 "awkgram.y" /* yacc.c:1651 */ { (yyval) = mk_binary((yyvsp[-2]), (yyvsp[0]), (yyvsp[-1])); } -#line 3790 "awkgram.c" /* yacc.c:1651 */ +#line 3936 "awkgram.c" /* yacc.c:1651 */ break; case 161: -#line 1697 "awkgram.y" /* yacc.c:1651 */ +#line 1813 "awkgram.y" /* yacc.c:1651 */ { (yyval) = list_create((yyvsp[0])); } -#line 3798 "awkgram.c" /* yacc.c:1651 */ +#line 3944 "awkgram.c" /* yacc.c:1651 */ break; case 162: -#line 1701 "awkgram.y" /* yacc.c:1651 */ +#line 1817 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[0])->opcode == Op_match_rec) { (yyvsp[0])->opcode = Op_nomatch; @@ -3830,11 +3976,11 @@ regular_print: } } } -#line 3834 "awkgram.c" /* yacc.c:1651 */ +#line 3980 "awkgram.c" /* yacc.c:1651 */ break; case 163: -#line 1733 "awkgram.y" /* yacc.c:1651 */ +#line 1849 "awkgram.y" /* yacc.c:1651 */ { // Always include. Allows us to lint warn on // print "foo" > "bar" 1 @@ -3842,31 +3988,31 @@ regular_print: // print "foo" > ("bar" 1) (yyval) = list_append((yyvsp[-1]), bcalloc(Op_parens, 1, sourceline)); } -#line 3846 "awkgram.c" /* yacc.c:1651 */ +#line 3992 "awkgram.c" /* yacc.c:1651 */ break; case 164: -#line 1741 "awkgram.y" /* yacc.c:1651 */ +#line 1857 "awkgram.y" /* yacc.c:1651 */ { (yyval) = snode((yyvsp[-1]), (yyvsp[-3])); if ((yyval) == NULL) YYABORT; } -#line 3856 "awkgram.c" /* yacc.c:1651 */ +#line 4002 "awkgram.c" /* yacc.c:1651 */ break; case 165: -#line 1747 "awkgram.y" /* yacc.c:1651 */ +#line 1863 "awkgram.y" /* yacc.c:1651 */ { (yyval) = snode((yyvsp[-1]), (yyvsp[-3])); if ((yyval) == NULL) YYABORT; } -#line 3866 "awkgram.c" /* yacc.c:1651 */ +#line 4012 "awkgram.c" /* yacc.c:1651 */ break; case 166: -#line 1753 "awkgram.y" /* yacc.c:1651 */ +#line 1869 "awkgram.y" /* yacc.c:1651 */ { static bool warned = false; @@ -3879,45 +4025,45 @@ regular_print: if ((yyval) == NULL) YYABORT; } -#line 3883 "awkgram.c" /* yacc.c:1651 */ +#line 4029 "awkgram.c" /* yacc.c:1651 */ break; case 169: -#line 1768 "awkgram.y" /* yacc.c:1651 */ +#line 1884 "awkgram.y" /* yacc.c:1651 */ { (yyvsp[-1])->opcode = Op_preincrement; (yyval) = mk_assignment((yyvsp[0]), NULL, (yyvsp[-1])); } -#line 3892 "awkgram.c" /* yacc.c:1651 */ +#line 4038 "awkgram.c" /* yacc.c:1651 */ break; case 170: -#line 1773 "awkgram.y" /* yacc.c:1651 */ +#line 1889 "awkgram.y" /* yacc.c:1651 */ { (yyvsp[-1])->opcode = Op_predecrement; (yyval) = mk_assignment((yyvsp[0]), NULL, (yyvsp[-1])); } -#line 3901 "awkgram.c" /* yacc.c:1651 */ +#line 4047 "awkgram.c" /* yacc.c:1651 */ break; case 171: -#line 1778 "awkgram.y" /* yacc.c:1651 */ +#line 1894 "awkgram.y" /* yacc.c:1651 */ { (yyval) = list_create((yyvsp[0])); } -#line 3909 "awkgram.c" /* yacc.c:1651 */ +#line 4055 "awkgram.c" /* yacc.c:1651 */ break; case 172: -#line 1782 "awkgram.y" /* yacc.c:1651 */ +#line 1898 "awkgram.y" /* yacc.c:1651 */ { (yyval) = list_create((yyvsp[0])); } -#line 3917 "awkgram.c" /* yacc.c:1651 */ +#line 4063 "awkgram.c" /* yacc.c:1651 */ break; case 173: -#line 1786 "awkgram.y" /* yacc.c:1651 */ +#line 1902 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[0])->lasti->opcode == Op_push_i && ((yyvsp[0])->lasti->memory->flags & STRING) == 0 @@ -3932,11 +4078,11 @@ regular_print: (yyval) = list_append((yyvsp[0]), (yyvsp[-1])); } } -#line 3936 "awkgram.c" /* yacc.c:1651 */ +#line 4082 "awkgram.c" /* yacc.c:1651 */ break; case 174: -#line 1801 "awkgram.y" /* yacc.c:1651 */ +#line 1917 "awkgram.y" /* yacc.c:1651 */ { if ((yyvsp[0])->lasti->opcode == Op_push_i && ((yyvsp[0])->lasti->memory->flags & STRING) == 0 @@ -3954,20 +4100,20 @@ regular_print: (yyval) = list_append((yyvsp[0]), (yyvsp[-1])); } } -#line 3958 "awkgram.c" /* yacc.c:1651 */ +#line 4104 "awkgram.c" /* yacc.c:1651 */ break; case 175: -#line 1822 "awkgram.y" /* yacc.c:1651 */ +#line 1938 "awkgram.y" /* yacc.c:1651 */ { func_use((yyvsp[0])->lasti->func_name, FUNC_USE); (yyval) = (yyvsp[0]); } -#line 3967 "awkgram.c" /* yacc.c:1651 */ +#line 4113 "awkgram.c" /* yacc.c:1651 */ break; case 176: -#line 1827 "awkgram.y" /* yacc.c:1651 */ +#line 1943 "awkgram.y" /* yacc.c:1651 */ { /* indirect function call */ INSTRUCTION *f, *t; @@ -4001,11 +4147,11 @@ regular_print: (yyval) = list_prepend((yyvsp[0]), t); at_seen = false; } -#line 4005 "awkgram.c" /* yacc.c:1651 */ +#line 4151 "awkgram.c" /* yacc.c:1651 */ break; case 177: -#line 1864 "awkgram.y" /* yacc.c:1651 */ +#line 1980 "awkgram.y" /* yacc.c:1651 */ { NODE *n; @@ -4030,49 +4176,49 @@ regular_print: (yyval) = list_append(t, (yyvsp[-3])); } } -#line 4034 "awkgram.c" /* yacc.c:1651 */ +#line 4180 "awkgram.c" /* yacc.c:1651 */ break; case 178: -#line 1892 "awkgram.y" /* yacc.c:1651 */ +#line 2008 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 4040 "awkgram.c" /* yacc.c:1651 */ +#line 4186 "awkgram.c" /* yacc.c:1651 */ break; case 179: -#line 1894 "awkgram.y" /* yacc.c:1651 */ +#line 2010 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 4046 "awkgram.c" /* yacc.c:1651 */ +#line 4192 "awkgram.c" /* yacc.c:1651 */ break; case 180: -#line 1899 "awkgram.y" /* yacc.c:1651 */ +#line 2015 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 4052 "awkgram.c" /* yacc.c:1651 */ +#line 4198 "awkgram.c" /* yacc.c:1651 */ break; case 181: -#line 1901 "awkgram.y" /* yacc.c:1651 */ +#line 2017 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[-1]); } -#line 4058 "awkgram.c" /* yacc.c:1651 */ +#line 4204 "awkgram.c" /* yacc.c:1651 */ break; case 182: -#line 1906 "awkgram.y" /* yacc.c:1651 */ +#line 2022 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 4064 "awkgram.c" /* yacc.c:1651 */ +#line 4210 "awkgram.c" /* yacc.c:1651 */ break; case 183: -#line 1908 "awkgram.y" /* yacc.c:1651 */ +#line 2024 "awkgram.y" /* yacc.c:1651 */ { (yyval) = list_merge((yyvsp[-1]), (yyvsp[0])); } -#line 4072 "awkgram.c" /* yacc.c:1651 */ +#line 4218 "awkgram.c" /* yacc.c:1651 */ break; case 184: -#line 1915 "awkgram.y" /* yacc.c:1651 */ +#line 2031 "awkgram.y" /* yacc.c:1651 */ { INSTRUCTION *ip = (yyvsp[0])->lasti; int count = ip->sub_count; /* # of SUBSEP-seperated expressions */ @@ -4086,11 +4232,11 @@ regular_print: sub_counter++; /* count # of dimensions */ (yyval) = (yyvsp[0]); } -#line 4090 "awkgram.c" /* yacc.c:1651 */ +#line 4236 "awkgram.c" /* yacc.c:1651 */ break; case 185: -#line 1932 "awkgram.y" /* yacc.c:1651 */ +#line 2048 "awkgram.y" /* yacc.c:1651 */ { INSTRUCTION *t = (yyvsp[-1]); if ((yyvsp[-1]) == NULL) { @@ -4104,31 +4250,31 @@ regular_print: (yyvsp[0])->sub_count = count_expressions(&t, false); (yyval) = list_append(t, (yyvsp[0])); } -#line 4108 "awkgram.c" /* yacc.c:1651 */ +#line 4254 "awkgram.c" /* yacc.c:1651 */ break; case 186: -#line 1949 "awkgram.y" /* yacc.c:1651 */ +#line 2065 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); } -#line 4114 "awkgram.c" /* yacc.c:1651 */ +#line 4260 "awkgram.c" /* yacc.c:1651 */ break; case 187: -#line 1951 "awkgram.y" /* yacc.c:1651 */ +#line 2067 "awkgram.y" /* yacc.c:1651 */ { (yyval) = list_merge((yyvsp[-1]), (yyvsp[0])); } -#line 4122 "awkgram.c" /* yacc.c:1651 */ +#line 4268 "awkgram.c" /* yacc.c:1651 */ break; case 188: -#line 1958 "awkgram.y" /* yacc.c:1651 */ +#line 2074 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[-1]); } -#line 4128 "awkgram.c" /* yacc.c:1651 */ +#line 4274 "awkgram.c" /* yacc.c:1651 */ break; case 189: -#line 1963 "awkgram.y" /* yacc.c:1651 */ +#line 2079 "awkgram.y" /* yacc.c:1651 */ { char *var_name = (yyvsp[0])->lextok; @@ -4136,22 +4282,22 @@ regular_print: (yyvsp[0])->memory = variable((yyvsp[0])->source_line, var_name, Node_var_new); (yyval) = list_create((yyvsp[0])); } -#line 4140 "awkgram.c" /* yacc.c:1651 */ +#line 4286 "awkgram.c" /* yacc.c:1651 */ break; case 190: -#line 1971 "awkgram.y" /* yacc.c:1651 */ +#line 2087 "awkgram.y" /* yacc.c:1651 */ { char *arr = (yyvsp[-1])->lextok; (yyvsp[-1])->memory = variable((yyvsp[-1])->source_line, arr, Node_var_new); (yyvsp[-1])->opcode = Op_push_array; (yyval) = list_prepend((yyvsp[0]), (yyvsp[-1])); } -#line 4151 "awkgram.c" /* yacc.c:1651 */ +#line 4297 "awkgram.c" /* yacc.c:1651 */ break; case 191: -#line 1981 "awkgram.y" /* yacc.c:1651 */ +#line 2097 "awkgram.y" /* yacc.c:1651 */ { INSTRUCTION *ip = (yyvsp[0])->nexti; if (ip->opcode == Op_push @@ -4163,73 +4309,85 @@ regular_print: } else (yyval) = (yyvsp[0]); } -#line 4167 "awkgram.c" /* yacc.c:1651 */ +#line 4313 "awkgram.c" /* yacc.c:1651 */ break; case 192: -#line 1993 "awkgram.y" /* yacc.c:1651 */ +#line 2109 "awkgram.y" /* yacc.c:1651 */ { (yyval) = list_append((yyvsp[-1]), (yyvsp[-2])); if ((yyvsp[0]) != NULL) mk_assignment((yyvsp[-1]), NULL, (yyvsp[0])); } -#line 4177 "awkgram.c" /* yacc.c:1651 */ +#line 4323 "awkgram.c" /* yacc.c:1651 */ break; case 193: -#line 2002 "awkgram.y" /* yacc.c:1651 */ +#line 2118 "awkgram.y" /* yacc.c:1651 */ { (yyvsp[0])->opcode = Op_postincrement; } -#line 4185 "awkgram.c" /* yacc.c:1651 */ +#line 4331 "awkgram.c" /* yacc.c:1651 */ break; case 194: -#line 2006 "awkgram.y" /* yacc.c:1651 */ +#line 2122 "awkgram.y" /* yacc.c:1651 */ { (yyvsp[0])->opcode = Op_postdecrement; } -#line 4193 "awkgram.c" /* yacc.c:1651 */ +#line 4339 "awkgram.c" /* yacc.c:1651 */ break; case 195: -#line 2009 "awkgram.y" /* yacc.c:1651 */ +#line 2126 "awkgram.y" /* yacc.c:1651 */ { (yyval) = NULL; } -#line 4199 "awkgram.c" /* yacc.c:1651 */ +#line 4345 "awkgram.c" /* yacc.c:1651 */ + break; + + case 196: +#line 2130 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = (yyvsp[0]); } +#line 4351 "awkgram.c" /* yacc.c:1651 */ break; case 197: -#line 2017 "awkgram.y" /* yacc.c:1651 */ - { yyerrok; } -#line 4205 "awkgram.c" /* yacc.c:1651 */ +#line 2134 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = (yyvsp[0]); yyerrok; } +#line 4357 "awkgram.c" /* yacc.c:1651 */ break; case 198: -#line 2021 "awkgram.y" /* yacc.c:1651 */ +#line 2138 "awkgram.y" /* yacc.c:1651 */ { yyerrok; } -#line 4211 "awkgram.c" /* yacc.c:1651 */ +#line 4363 "awkgram.c" /* yacc.c:1651 */ + break; + + case 199: +#line 2143 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = NULL; } +#line 4369 "awkgram.c" /* yacc.c:1651 */ break; case 201: -#line 2030 "awkgram.y" /* yacc.c:1651 */ +#line 2148 "awkgram.y" /* yacc.c:1651 */ { yyerrok; } -#line 4217 "awkgram.c" /* yacc.c:1651 */ +#line 4375 "awkgram.c" /* yacc.c:1651 */ break; case 202: -#line 2034 "awkgram.y" /* yacc.c:1651 */ +#line 2152 "awkgram.y" /* yacc.c:1651 */ { (yyval) = (yyvsp[0]); yyerrok; } -#line 4223 "awkgram.c" /* yacc.c:1651 */ +#line 4381 "awkgram.c" /* yacc.c:1651 */ break; case 203: -#line 2038 "awkgram.y" /* yacc.c:1651 */ - { yyerrok; } -#line 4229 "awkgram.c" /* yacc.c:1651 */ +#line 2156 "awkgram.y" /* yacc.c:1651 */ + { (yyval) = (yyvsp[0]); yyerrok; } +#line 4387 "awkgram.c" /* yacc.c:1651 */ break; -#line 4233 "awkgram.c" /* yacc.c:1651 */ +#line 4391 "awkgram.c" /* yacc.c:1651 */ default: break; } /* User semantic actions sometimes alter yychar, and that requires @@ -4457,7 +4615,7 @@ yyreturn: #endif return yyresult; } -#line 2040 "awkgram.y" /* yacc.c:1910 */ +#line 2158 "awkgram.y" /* yacc.c:1910 */ struct token { @@ -4536,8 +4694,8 @@ static const struct token tokentab[] = { {"exp", Op_builtin, LEX_BUILTIN, A(1), do_exp, MPF(exp)}, {"fflush", Op_builtin, LEX_BUILTIN, A(0)|A(1), do_fflush, 0}, {"for", Op_K_for, LEX_FOR, BREAK|CONTINUE, 0, 0}, -{"func", Op_func, LEX_FUNCTION, NOT_POSIX|NOT_OLD, 0, 0}, -{"function",Op_func, LEX_FUNCTION, NOT_OLD, 0, 0}, +{"func", Op_func, LEX_FUNCTION, NOT_POSIX|NOT_OLD, 0, 0}, +{"function", Op_func, LEX_FUNCTION, NOT_OLD, 0, 0}, {"gensub", Op_sub_builtin, LEX_BUILTIN, GAWKX|A(3)|A(4), 0, 0}, {"getline", Op_K_getline_redir, LEX_GETLINE, NOT_OLD, 0, 0}, {"gsub", Op_sub_builtin, LEX_BUILTIN, NOT_OLD|A(2)|A(3), 0, 0}, @@ -4896,11 +5054,6 @@ mk_program() cp = end_block; else cp = list_merge(begin_block, end_block); - if (program_comment != NULL) { - (void) list_prepend(cp, program_comment); - } - if (comment != NULL) - (void) list_append(cp, comment); (void) list_append(cp, ip_atexit); (void) list_append(cp, instruction(Op_stop)); @@ -4933,12 +5086,6 @@ mk_program() if (begin_block != NULL) cp = list_merge(begin_block, cp); - if (program_comment != NULL) { - (void) list_prepend(cp, program_comment); - } - if (comment != NULL) { - (void) list_append(cp, comment); - } (void) list_append(cp, ip_atexit); (void) list_append(cp, instruction(Op_stop)); @@ -4946,10 +5093,6 @@ out: /* delete the Op_list, not needed */ tmp = cp->nexti; bcfree(cp); - /* these variables are not used again but zap them anyway. */ - comment = NULL; - function_comment = NULL; - program_comment = NULL; return tmp; #undef begin_block @@ -5124,7 +5267,7 @@ add_srcfile(enum srctype stype, char *src, SRCFILE *thisfile, bool *already_incl /* include_source --- read program from source included using `@include' */ -static int +static bool include_source(INSTRUCTION *file) { SRCFILE *s; @@ -5134,23 +5277,23 @@ include_source(INSTRUCTION *file) if (do_traditional || do_posix) { error_ln(file->source_line, _("@include is a gawk extension")); - return -1; + return false; } if (strlen(src) == 0) { if (do_lint) lintwarn_ln(file->source_line, _("empty filename after @include")); - return 0; + return true; } s = add_srcfile(SRC_INC, src, sourcefile, &already_included, &errcode); if (s == NULL) { if (already_included) - return 0; + return true; error_ln(file->source_line, _("can't open source file `%s' for reading (%s)"), src, errcode ? strerror(errcode) : _("reason unknown")); - return -1; + return false; } /* save scanner state for the current sourcefile */ @@ -5169,42 +5312,45 @@ include_source(INSTRUCTION *file) lasttok = 0; lexeof = false; eof_warned = false; - return 0; + return true; } /* load_library --- load a shared library */ -static int -load_library(INSTRUCTION *file) +static bool +load_library(INSTRUCTION *file, void **srcfile_p) { SRCFILE *s; char *src = file->lextok; int errcode; bool already_included; + *srcfile_p = NULL; + if (do_traditional || do_posix) { error_ln(file->source_line, _("@load is a gawk extension")); - return -1; + return false; } if (strlen(src) == 0) { if (do_lint) lintwarn_ln(file->source_line, _("empty filename after @load")); - return 0; + return true; } s = add_srcfile(SRC_EXTLIB, src, sourcefile, &already_included, &errcode); if (s == NULL) { if (already_included) - return 0; + return true; error_ln(file->source_line, _("can't open shared library `%s' for reading (%s)"), src, errcode ? strerror(errcode) : _("reason unknown")); - return -1; + return false; } load_ext(s->fullpath); - return 0; + *srcfile_p = (void *) s; + return true; } /* next_sourcefile --- read program from the next source in srcfiles */ @@ -5612,37 +5758,23 @@ pushback(void) (! lexeof && lexptr && lexptr > lexptr_begin ? lexptr-- : lexptr); } -/* check_comment --- check for block comment */ - -void -check_comment(void) -{ - if (comment != NULL) { - if (first_rule) { - program_comment = comment; - } else - block_comment = comment; - comment = NULL; - } - first_rule = false; -} - /* * get_comment --- collect comment text. * Flag = EOL_COMMENT for end-of-line comments. - * Flag = FULL_COMMENT for self-contained comments. + * Flag = BLOCK_COMMENT for self-contained comments. */ -int -get_comment(int flag) +static int +get_comment(enum commenttype flag, INSTRUCTION **comment_instruction) { int c; int sl; + char *p1; + char *p2; + tok = tokstart; tokadd('#'); sl = sourceline; - char *p1; - char *p2; while (true) { while ((c = nextc(false)) != '\n' && c != END_FILE) { @@ -5678,9 +5810,6 @@ get_comment(int flag) break; } - if (comment != NULL) - prior_comment = comment; - /* remove any trailing blank lines (consecutive \n) from comment */ p1 = tok - 1; p2 = tok - 2; @@ -5690,49 +5819,18 @@ get_comment(int flag) tok--; } - comment = bcalloc(Op_comment, 1, sl); - comment->source_file = source; - comment->memory = make_str_node(tokstart, tok - tokstart, 0); - comment->memory->comment_type = flag; + (*comment_instruction) = bcalloc(Op_comment, 1, sl); + (*comment_instruction)->source_file = source; + (*comment_instruction)->memory = make_str_node(tokstart, tok - tokstart, 0); + (*comment_instruction)->memory->comment_type = flag; return c; } -/* split_comment --- split initial comment text into program and function parts */ - -static void -split_comment(void) -{ - char *p; - int l; - NODE *n; - - p = comment_to_save->memory->stptr; - l = comment_to_save->memory->stlen - 3; - /* have at least two comments so split at last blank line (\n\n) */ - while (l >= 0) { - if (p[l] == '\n' && p[l+1] == '\n') { - function_comment = comment_to_save; - n = function_comment->memory; - function_comment->memory = make_string(p + l + 2, n->stlen - l - 2); - /* create program comment */ - program_comment = bcalloc(Op_comment, 1, sourceline); - program_comment->source_file = comment_to_save->source_file; - p[l + 2] = 0; - program_comment->memory = make_str_node(p, l + 2, 0); - comment_to_save = NULL; - freenode(n); - break; - } - else - l--; - } -} - /* allow_newline --- allow newline after &&, ||, ? and : */ static void -allow_newline(void) +allow_newline(INSTRUCTION **new_comment) { int c; @@ -5744,8 +5842,8 @@ allow_newline(void) } if (c == '#') { if (do_pretty_print && ! do_profile) { - /* collect comment byte code iff doing pretty print but not profiling. */ - c = get_comment(EOL_COMMENT); + /* collect comment byte code iff doing pretty print but not profiling. */ + c = get_comment(EOL_COMMENT, new_comment); } else { while ((c = nextc(false)) != '\n' && c != END_FILE) continue; @@ -5812,6 +5910,7 @@ yylex(void) bool intlstr = false; AWKNUM d; bool collecting_typed_regexp = false; + static int qm_col_count = 0; #define GET_INSTRUCTION(op) bcalloc(op, 1, sourceline) @@ -5976,18 +6075,25 @@ retry: return lasttok = NEWLINE; case '#': /* it's a comment */ + yylval = NULL; if (do_pretty_print && ! do_profile) { /* * Collect comment byte code iff doing pretty print * but not profiling. */ + INSTRUCTION *new_comment; + if (lasttok == NEWLINE || lasttok == 0) - c = get_comment(FULL_COMMENT); + c = get_comment(BLOCK_COMMENT, & new_comment); else - c = get_comment(EOL_COMMENT); + c = get_comment(EOL_COMMENT, & new_comment); - if (c == END_FILE) - return lasttok = NEWLINE_EOF; + yylval = new_comment; + + if (c == END_FILE) { + pushback(); + return lasttok = NEWLINE; + } } else { while ((c = nextc(false)) != '\n') { if (c == END_FILE) @@ -6016,7 +6122,10 @@ retry: * Use it at your own risk. We think it's a bad idea, which * is why it's not on by default. */ + yylval = NULL; if (! do_traditional) { + INSTRUCTION *new_comment; + /* strip trailing white-space and/or comment */ while ((c = nextc(true)) == ' ' || c == '\t' || c == '\r') continue; @@ -6028,9 +6137,11 @@ retry: lintwarn( _("use of `\\ #...' line continuation is not portable")); } - if (do_pretty_print && ! do_profile) - c = get_comment(EOL_COMMENT); - else { + if (do_pretty_print && ! do_profile) { + c = get_comment(EOL_COMMENT, & new_comment); + yylval = new_comment; + return lasttok = c; + } else { while ((c = nextc(false)) != '\n') if (c == END_FILE) break; @@ -6051,11 +6162,19 @@ retry: } break; - case ':': case '?': + qm_col_count++; + // fall through + case ':': yylval = GET_INSTRUCTION(Op_cond_exp); - if (! do_posix) - allow_newline(); + if (c == ':' && qm_col_count > 0) { + if (do_posix) { + INSTRUCTION *new_comment = NULL; + allow_newline(& new_comment); + yylval->comment = new_comment; + } + qm_col_count--; + } return lasttok = c; /* @@ -6477,7 +6596,10 @@ retry: case '&': if ((c = nextc(true)) == '&') { yylval = GET_INSTRUCTION(Op_and); - allow_newline(); + INSTRUCTION *new_comment = NULL; + allow_newline(& new_comment); + yylval->comment = new_comment; + return lasttok = LEX_AND; } pushback(); @@ -6487,11 +6609,15 @@ retry: case '|': if ((c = nextc(true)) == '|') { yylval = GET_INSTRUCTION(Op_or); - allow_newline(); + INSTRUCTION *new_comment = NULL; + allow_newline(& new_comment); + yylval->comment = new_comment; + return lasttok = LEX_OR; } else if (! do_traditional && c == '&') { yylval = GET_INSTRUCTION(Op_symbol); yylval->redir_type = redirect_twoway; + return lasttok = (in_print && in_parens == 0 ? IO_OUT : IO_IN); } pushback(); @@ -6681,8 +6807,11 @@ out: yylval->lextok = tokkey; #define SMART_ALECK 1 - if (SMART_ALECK && do_lint - && ! goto_warned && strcasecmp(tokkey, "goto") == 0) { + if (SMART_ALECK + && do_lint + && ! goto_warned + && tolower(tokkey[0]) == 'g' + && strcasecmp(tokkey, "goto") == 0) { goto_warned = true; lintwarn(_("`goto' considered harmful!")); } @@ -7153,15 +7282,8 @@ mk_function(INSTRUCTION *fi, INSTRUCTION *def) thisfunc = fi->func_body; assert(thisfunc != NULL); - /* add any pre-function comment to start of action for profile.c */ - - if (function_comment != NULL) { - function_comment->source_line = 0; - (void) list_prepend(def, function_comment); - function_comment = NULL; - } - - /* add an implicit return at end; + /* + * Add an implicit return at end; * also used by 'return' command in debugger */ @@ -7872,12 +7994,7 @@ append_rule(INSTRUCTION *pattern, INSTRUCTION *action) (rp + 1)->lasti = action->lasti; (rp + 2)->first_line = pattern->source_line; (rp + 2)->last_line = lastline; - if (block_comment != NULL) { - ip = list_prepend(list_prepend(action, block_comment), rp); - block_comment = NULL; - } else - ip = list_prepend(action, rp); - + ip = list_prepend(action, rp); } else { rp = bcalloc(Op_rule, 3, 0); rp->in_rule = Rule; @@ -8282,8 +8399,9 @@ mk_for_loop(INSTRUCTION *forp, INSTRUCTION *init, INSTRUCTION *cond, forp->target_break = tbreak; forp->target_continue = tcont; ret = list_prepend(ret, forp); - } /* else - forp is NULL */ + } + /* else + forp is NULL */ return ret; } @@ -8497,26 +8615,6 @@ list_merge(INSTRUCTION *l1, INSTRUCTION *l2) return l1; } -/* add_pending_comment --- add a pending comment to a statement */ - -static inline INSTRUCTION * -add_pending_comment(INSTRUCTION *stmt) -{ - INSTRUCTION *ret = stmt; - - if (prior_comment != NULL) { - if (function_comment != prior_comment) - ret = list_append(stmt, prior_comment); - prior_comment = NULL; - } else if (comment != NULL && comment->memory->comment_type == EOL_COMMENT) { - if (function_comment != comment) - ret = list_append(stmt, comment); - comment = NULL; - } - - return ret; -} - /* See if name is a special token. */ int @@ -8756,3 +8854,125 @@ set_profile_text(NODE *n, const char *str, size_t len) return n; } + +/* + * merge_comments --- merge c2 into c1 and free c2 if successful. + * Allow c2 to be NULL, in which case just merged chained + * comments in c1. + */ + +static void +merge_comments(INSTRUCTION *c1, INSTRUCTION *c2) +{ + assert(c1->opcode == Op_comment); + + if (c1->comment == NULL && c2 == NULL) // nothing to do + return; + + size_t total = c1->memory->stlen; + if (c1->comment != NULL) + total += 1 /* \n */ + c1->comment->memory->stlen; + + if (c2 != NULL) { + assert(c2->opcode == Op_comment); + total += 1 /* \n */ + c2->memory->stlen; + if (c2->comment != NULL) + total += c2->comment->memory->stlen + 1; + } + + char *buffer; + emalloc(buffer, char *, total + 1, "merge_comments"); + + strcpy(buffer, c1->memory->stptr); + if (c1->comment != NULL) { + strcat(buffer, "\n"); + strcat(buffer, c1->comment->memory->stptr); + } + + if (c2 != NULL) { + strcat(buffer, "\n"); + strcat(buffer, c2->memory->stptr); + if (c2->comment != NULL) { + strcat(buffer, "\n"); + strcat(buffer, c2->comment->memory->stptr); + } + + unref(c2->memory); + if (c2->comment != NULL) { + unref(c2->comment->memory); + bcfree(c2->comment); + c2->comment = NULL; + } + bcfree(c2); + } + + c1->memory->comment_type = BLOCK_COMMENT; + free(c1->memory->stptr); + c1->memory->stptr = buffer; + c1->memory->stlen = strlen(buffer); + + // now free everything else + if (c1->comment != NULL) { + unref(c1->comment->memory); + bcfree(c1->comment); + c1->comment = NULL; + } +} + +/* make_braced_statements --- handle `l_brace statements r_brace' with comments */ + +static INSTRUCTION * +make_braced_statements(INSTRUCTION *lbrace, INSTRUCTION *stmts, INSTRUCTION *rbrace) +{ + INSTRUCTION *ip; + + if (stmts == NULL) + ip = list_create(instruction(Op_no_op)); + else + ip = stmts; + + if (lbrace != NULL) { + INSTRUCTION *comment2 = lbrace->comment; + if (comment2 != NULL) { + ip = list_prepend(ip, comment2); + lbrace->comment = NULL; + } + ip = list_prepend(ip, lbrace); + } + + /* Tack any comment onto the end. */ + if (rbrace != NULL) { + INSTRUCTION *comment2 = rbrace->comment; + rbrace->comment = NULL; + if (rbrace->memory->comment_type == EOL_COMMENT) + rbrace->memory->comment_type = BLOCK_COMMENT; + ip = list_append(ip, rbrace); + if (comment2 != NULL) + ip = list_append(ip, comment2); + } + + return ip; +} + +/* make_include_comment --- create a commented @include statement */ + +static INSTRUCTION * +make_include_comment(const char *filename) +{ + assert(do_pretty_print); + + static char format[] = "# @include \"%s\"\n"; + static size_t formatlen = sizeof(format); + + size_t count = formatlen + strlen(filename); + char *buffer; + + emalloc(buffer, char *, count + 1, "make_include_comment"); + sprintf(buffer, format, filename); + + NODE *mem = make_str_node(buffer, strlen(buffer), ALREADY_MALLOCED); + INSTRUCTION *com = instruction(Op_comment); + com->memory = mem; + + return com; +} @@ -1,3 +1,22 @@ +/* working on statement_term and opt_nls */ +/* +TODO: +-- Comments after commas in expressions lists in print/f and function calls +-- Get comments from all instances of opt_nls +-- Get comments from all instances of l_brace +-- Get comments from all instances of r_brace +-- Review statement lists and handling of statement_term +DONE: +-- Get comments from all instances of nls +-- After , in parameter list +-- After ? and : +-- switch statement +-- After , in a range expression in a pattern +-- After && and || +-- case part of switch statement +-- for(;;) statement +-- for(iggy in fo) statement +*/ /* * awkgram.y --- yacc/bison parser */ @@ -53,8 +72,8 @@ static int isnoeffect(OPCODE type); static INSTRUCTION *make_assignable(INSTRUCTION *ip); static void dumpintlstr(const char *str, size_t len); static void dumpintlstr2(const char *str1, size_t len1, const char *str2, size_t len2); -static int include_source(INSTRUCTION *file); -static int load_library(INSTRUCTION *file); +static bool include_source(INSTRUCTION *file); +static bool load_library(INSTRUCTION *file, void **comment_p); static void next_sourcefile(void); static char *tokexpand(void); static NODE *set_profile_text(NODE *n, const char *str, size_t len); @@ -84,8 +103,9 @@ static void check_funcs(void); static ssize_t read_one_line(int fd, void *buffer, size_t count); static int one_line_close(int fd); -static void split_comment(void); -static void check_comment(void); +static void merge_comments(INSTRUCTION *c1, INSTRUCTION *c2); +static INSTRUCTION *make_include_comment(const char *filename); +static INSTRUCTION *make_braced_statements(INSTRUCTION *lbrace, INSTRUCTION *stmts, INSTRUCTION *rbrace); static void add_sign_to_num(NODE *n, char sign); static bool at_seen = false; @@ -152,21 +172,13 @@ static INSTRUCTION *ip_endfile; static INSTRUCTION *ip_beginfile; INSTRUCTION *main_beginfile; -static INSTRUCTION *comment = NULL; -static INSTRUCTION *prior_comment = NULL; -static INSTRUCTION *comment_to_save = NULL; -static INSTRUCTION *program_comment = NULL; -static INSTRUCTION *function_comment = NULL; -static INSTRUCTION *block_comment = NULL; - -static bool func_first = true; +static bool func_first = true; // can nuke static bool first_rule = true; static inline INSTRUCTION *list_create(INSTRUCTION *x); static inline INSTRUCTION *list_append(INSTRUCTION *l, INSTRUCTION *x); static inline INSTRUCTION *list_prepend(INSTRUCTION *l, INSTRUCTION *x); static inline INSTRUCTION *list_merge(INSTRUCTION *l1, INSTRUCTION *l2); -static inline INSTRUCTION *add_pending_comment(INSTRUCTION *stmt); extern double fmod(double x, double y); @@ -214,12 +226,20 @@ extern double fmod(double x, double y); program : /* empty */ + { $$ = NULL; } | program rule { rule = 0; yyerrok; } | program nls + { + if ($2 != NULL) { + merge_comments($2, NULL); + $$ = list_append(rule_list, $2); + } else + $$ = $1; + } | program LEX_EOF { next_sourcefile(); @@ -249,8 +269,11 @@ rule } else if ($1 == NULL) { msg(_("each rule must have a pattern or an action part")); errcount++; - } else /* pattern rule with non-empty pattern */ + } else { /* pattern rule with non-empty pattern */ + if ($2 != NULL) + list_append($1, $2); (void) append_rule($1, NULL); + } } | function_prologue action { @@ -263,12 +286,41 @@ rule { want_source = false; at_seen = false; +#if 1 + if ($4 != NULL) { + assert($4->opcode == Op_comment); + warning(_("comments on `@include' statements will be lost")); + unref($4->memory); + bcfree($4); + } +#else + if ($3 != NULL && $4 != NULL) { + size_t end; + + // remove trailing newline + end = --($3->memory->stlen); + $3->memory->stptr[end] = '\0'; + + merge_comments($3, $4); + + // tweak embedded newline + $3->memory->stptr[end] = '\t'; + + // FIXME: how to get this into the program? + // list_append(rule_list, $3); + // rule_list = list_prepend(rule_list, list_create($3)); + } +#endif yyerrok; } | '@' LEX_LOAD library statement_term { want_source = false; at_seen = false; + if ($3 != NULL && $4 != NULL) { + SRCFILE *s = (SRCFILE *) $3; + s->comment = $4; + } yyerrok; } ; @@ -276,11 +328,15 @@ rule source : FILENAME { - if (include_source($1) < 0) + if (! include_source($1)) YYABORT; + if (do_pretty_print) { + $$ = make_include_comment($1->lextok); + } else { + $$ = NULL; + } efree($1->lextok); bcfree($1); - $$ = NULL; } | FILENAME error { $$ = NULL; } @@ -291,11 +347,13 @@ source library : FILENAME { - if (load_library($1) < 0) + void *srcfile; + + if (! load_library($1, & srcfile)) YYABORT; efree($1->lextok); bcfree($1); - $$ = NULL; + $$ = (INSTRUCTION *) srcfile; } | FILENAME error { $$ = NULL; } @@ -307,20 +365,11 @@ pattern : /* empty */ { rule = Rule; - if (comment != NULL) { - $$ = list_create(comment); - comment = NULL; - } else - $$ = NULL; + $$ = NULL; } | exp { rule = Rule; - if (comment != NULL) { - $$ = list_prepend($1, comment); - comment = NULL; - } else - $$ = $1; } | exp ',' opt_nls exp @@ -346,10 +395,10 @@ pattern ($1->nexti + 1)->condpair_left = $1->lasti; ($1->nexti + 1)->condpair_right = $4->lasti; } - if (comment != NULL) { - $$ = list_append(list_merge(list_prepend($1, comment), $4), tp); - comment = NULL; - } else + /* Put any comments in front of the range expression */ + if ($3 != NULL) + $$ = list_append(list_merge(list_prepend($1, $3), $4), tp); + else $$ = list_append(list_merge($1, $4), tp); rule = Rule; } @@ -364,7 +413,6 @@ pattern $1->in_rule = rule = BEGIN; $1->source_file = source; - check_comment(); $$ = $1; } | LEX_END @@ -378,7 +426,6 @@ pattern $1->in_rule = rule = END; $1->source_file = source; - check_comment(); $$ = $1; } | LEX_BEGINFILE @@ -386,7 +433,6 @@ pattern func_first = false; $1->in_rule = rule = BEGINFILE; $1->source_file = source; - check_comment(); $$ = $1; } | LEX_ENDFILE @@ -394,7 +440,6 @@ pattern func_first = false; $1->in_rule = rule = ENDFILE; $1->source_file = source; - check_comment(); $$ = $1; } ; @@ -402,11 +447,11 @@ pattern action : l_brace statements r_brace opt_semi opt_nls { - INSTRUCTION *ip; - if ($2 == NULL) - ip = list_create(instruction(Op_no_op)); - else - ip = $2; + INSTRUCTION *ip = make_braced_statements($1, $2, $3); + + if ($5 != NULL) + ip = list_append(ip, $5); + $$ = ip; } ; @@ -437,33 +482,21 @@ lex_builtin function_prologue : LEX_FUNCTION func_name '(' { want_param_names = FUNC_HEADER; } opt_param_list r_paren opt_nls { - /* - * treat any comments between BOF and the first function - * definition (with no intervening BEGIN etc block) as - * program comments. Special kludge: iff there are more - * than one such comments, treat the last as a function - * comment. - */ - if (prior_comment != NULL) { - comment_to_save = prior_comment; - prior_comment = NULL; - } else if (comment != NULL) { - comment_to_save = comment; - comment = NULL; - } else - comment_to_save = NULL; - - if (comment_to_save != NULL && func_first - && strstr(comment_to_save->memory->stptr, "\n\n") != NULL) - split_comment(); - - /* save any other pre-function comment as function comment */ - if (comment_to_save != NULL) { - function_comment = comment_to_save; - comment_to_save = NULL; + INSTRUCTION *func_comment = NULL; + // Merge any comments found in the parameter list with those + // following the function header, associate the whole shebang + // with the function as one block comment. + if ($5 != NULL && $5->comment != NULL) { + if ($7 != NULL) { + merge_comments($5->comment, $7); + } + func_comment = $5->comment; + } else if ($7 != NULL) { + func_comment = $7; } - func_first = false; + $1->source_file = source; + $1->comment = func_comment; if (install_function($2->lextok, $1, $5) < 0) YYABORT; in_function = $2->lextok; @@ -536,58 +569,16 @@ a_slash statements : /* empty */ - { - if (prior_comment != NULL) { - $$ = list_create(prior_comment); - prior_comment = NULL; - } else if (comment != NULL) { - $$ = list_create(comment); - comment = NULL; - } else - $$ = NULL; - } + { $$ = NULL; } | statements statement { if ($2 == NULL) { - if (prior_comment != NULL) { - $$ = list_append($1, prior_comment); - prior_comment = NULL; - if (comment != NULL) { - $$ = list_append($$, comment); - comment = NULL; - } - } else if (comment != NULL) { - $$ = list_append($1, comment); - comment = NULL; - } else - $$ = $1; + $$ = $1; } else { add_lint($2, LINT_no_effect); if ($1 == NULL) { - if (prior_comment != NULL) { - $$ = list_append($2, prior_comment); - prior_comment = NULL; - if (comment != NULL) { - $$ = list_append($$, comment); - comment = NULL; - } - } else if (comment != NULL) { - $$ = list_append($2, comment); - comment = NULL; - } else - $$ = $2; + $$ = $2; } else { - if (prior_comment != NULL) { - list_append($2, prior_comment); - prior_comment = NULL; - if (comment != NULL) { - list_append($2, comment); - comment = NULL; - } - } else if (comment != NULL) { - list_append($2, comment); - comment = NULL; - } $$ = list_merge($1, $2); } } @@ -598,15 +589,26 @@ statements ; statement_term - : nls - | semi opt_nls + : nls { $$ = $1; } + | semi opt_nls { $$ = $2; } ; statement : semi opt_nls - { $$ = NULL; } + { + if ($2 != NULL) { + INSTRUCTION *ip; + + merge_comments($2, NULL); + ip = list_create(instruction(Op_no_op)); + $$ = list_append(ip, $2); + } else + $$ = NULL; + } | l_brace statements r_brace - { $$ = $2; } + { + $$ = make_braced_statements($1, $2, $3); + } | if_statement { if (do_pretty_print) @@ -632,8 +634,9 @@ statement if ($7 != NULL) { curr = $7->nexti; bcfree($7); /* Op_list */ - } /* else - curr = NULL; */ + } + /* else + curr = NULL; */ for (; curr != NULL; curr = nextc) { INSTRUCTION *caseexp = curr->case_exp; @@ -689,16 +692,33 @@ statement ip = $3; if (do_pretty_print) { + // first merge comments + INSTRUCTION *head_comment = NULL; + + if ($5 != NULL && $6 != NULL) { + merge_comments($5, $6); + head_comment = $5; + } else if ($5 != NULL) + head_comment = $5; + else + head_comment = $6; + + $1->comment = head_comment; + (void) list_prepend(ip, $1); (void) list_prepend(ip, instruction(Op_exec_count)); $1->target_break = tbreak; ($1 + 1)->switch_start = cexp->nexti; ($1 + 1)->switch_end = cexp->lasti; - }/* else - $1 is NULL */ + ($1 + 1)->switch_end->comment = $9; + } + /* else + $1 is NULL */ (void) list_append(cexp, dflt); (void) list_merge(ip, cexp); + if ($8 != NULL) + (void) list_append(cstmt, $8); $$ = list_merge(ip, cstmt); break_allowed--; @@ -733,8 +753,17 @@ statement $1->target_continue = tcont; ($1 + 1)->while_body = ip->lasti; (void) list_prepend(ip, $1); - }/* else - $1 is NULL */ + } + /* else + $1 is NULL */ + + if ($5 != NULL) { + if ($6 == NULL) + $6 = list_create(instruction(Op_no_op)); + + $5->memory->comment_type = BLOCK_COMMENT; + $6 = list_prepend($6, $5); + } if ($6 != NULL) (void) list_merge(ip, $6); @@ -769,8 +798,13 @@ statement ip = list_merge($3, $6); else ip = list_prepend($6, instruction(Op_no_op)); + + if ($2 != NULL) + (void) list_prepend(ip, $2); + if (do_pretty_print) (void) list_prepend(ip, instruction(Op_exec_count)); + (void) list_append(ip, instruction(Op_jmp_true)); ip->lasti->target_jmp = ip->nexti; $$ = list_append(ip, tbreak); @@ -785,7 +819,10 @@ statement ($1 + 1)->doloop_cond = tcont; $$ = list_prepend(ip, $1); bcfree($4); - } /* else + if ($8 != NULL) + $1->comment = $8; + } + /* else $1 and $4 are NULLs */ } | LEX_FOR '(' NAME LEX_IN simple_variable r_paren opt_nls statement @@ -801,7 +838,8 @@ statement && strcmp($8->nexti->memory->vname, var_name) == 0 ) { - /* Efficiency hack. Recognize the special case of + /* + * Efficiency hack. Recognize the special case of * * for (iggy in foo) * delete foo[iggy] @@ -833,6 +871,10 @@ statement bcfree($3); bcfree($4); bcfree($5); + if ($7 != NULL) { + merge_comments($7, NULL); + $8 = list_prepend($8, $7); + } $$ = $8; } else goto regular_loop; @@ -867,8 +909,9 @@ regular_loop: $1->target_continue = tcont; $1->target_break = tbreak; (void) list_append(ip, $1); - } /* else - $1 is NULL */ + } + /* else + $1 is NULL */ /* add update_FOO instruction if necessary */ if ($4->array_var->type == Node_var && $4->array_var->var_update) { @@ -889,8 +932,15 @@ regular_loop: ($1 + 1)->forloop_body = ip->lasti; } - if ($8 != NULL) + if ($7 != NULL) + merge_comments($7, NULL); + + if ($8 != NULL) { + if ($7 != NULL) + $8 = list_prepend($8, $7); (void) list_merge(ip, $8); + } else if ($7 != NULL) + (void) list_append(ip, $7); (void) list_append(ip, instruction(Op_jmp)); ip->lasti->target_jmp = $4; @@ -903,6 +953,20 @@ regular_loop: } | LEX_FOR '(' opt_simple_stmt semi opt_nls exp semi opt_nls opt_simple_stmt r_paren opt_nls statement { + if ($5 != NULL) { + merge_comments($5, NULL); + $1->comment = $5; + } + if ($8 != NULL) { + merge_comments($8, NULL); + if ($1->comment == NULL) { + $8->memory->comment_type = FOR_COMMENT; + $1->comment = $8; + } else + $1->comment->comment = $8; + } + if ($11 != NULL) + $12 = list_prepend($12, $11); $$ = mk_for_loop($1, $3, $6, $9, $12); break_allowed--; @@ -910,6 +974,20 @@ regular_loop: } | LEX_FOR '(' opt_simple_stmt semi opt_nls semi opt_nls opt_simple_stmt r_paren opt_nls statement { + if ($5 != NULL) { + merge_comments($5, NULL); + $1->comment = $5; + } + if ($7 != NULL) { + merge_comments($7, NULL); + if ($1->comment == NULL) { + $7->memory->comment_type = FOR_COMMENT; + $1->comment = $7; + } else + $1->comment->comment = $7; + } + if ($10 != NULL) + $11 = list_prepend($11, $10); $$ = mk_for_loop($1, $3, (INSTRUCTION *) NULL, $8, $11); break_allowed--; @@ -921,7 +999,6 @@ regular_loop: $$ = list_prepend($1, instruction(Op_exec_count)); else $$ = $1; - $$ = add_pending_comment($$); } ; @@ -933,8 +1010,8 @@ non_compound_stmt _("`break' is not allowed outside a loop or switch")); $1->target_jmp = NULL; $$ = list_create($1); - $$ = add_pending_comment($$); - + if ($2 != NULL) + $$ = list_append($$, $2); } | LEX_CONTINUE statement_term { @@ -943,8 +1020,8 @@ non_compound_stmt _("`continue' is not allowed outside a loop")); $1->target_jmp = NULL; $$ = list_create($1); - $$ = add_pending_comment($$); - + if ($2 != NULL) + $$ = list_append($$, $2); } | LEX_NEXT statement_term { @@ -954,7 +1031,8 @@ non_compound_stmt _("`next' used in %s action"), ruletab[rule]); $1->target_jmp = ip_rec; $$ = list_create($1); - $$ = add_pending_comment($$); + if ($2 != NULL) + $$ = list_append($$, $2); } | LEX_NEXTFILE statement_term { @@ -966,7 +1044,8 @@ non_compound_stmt $1->target_newfile = ip_newfile; $1->target_endfile = ip_endfile; $$ = list_create($1); - $$ = add_pending_comment($$); + if ($2 != NULL) + $$ = list_append($$, $2); } | LEX_EXIT opt_exp statement_term { @@ -982,7 +1061,8 @@ non_compound_stmt $$->nexti->memory = dupnode(Nnull_string); } else $$ = list_append($2, $1); - $$ = add_pending_comment($$); + if ($3 != NULL) + $$ = list_append($$, $3); } | LEX_RETURN { @@ -995,10 +1075,16 @@ non_compound_stmt $$->nexti->memory = dupnode(Nnull_string); } else $$ = list_append($3, $1); - - $$ = add_pending_comment($$); + if ($4 != NULL) + $$ = list_append($$, $4); } | simple_stmt statement_term + { + if ($2 != NULL) + $$ = list_append($1, $2); + else + $$ = $1; + } ; /* @@ -1018,7 +1104,7 @@ simple_stmt * which is faster for these two cases. */ - if ($1->opcode == Op_K_print && + if (do_optimize && $1->opcode == Op_K_print && ($3 == NULL || ($3->lasti->opcode == Op_field_spec && $3->nexti->nexti->nexti == $3->lasti @@ -1106,7 +1192,6 @@ regular_print: } } } - $$ = add_pending_comment($$); } | LEX_DELETE NAME { sub_counter = 0; } delete_subscript_list @@ -1141,7 +1226,6 @@ regular_print: $1->expr_count = sub_counter; $$ = list_append(list_append($4, $2), $1); } - $$ = add_pending_comment($$); } | LEX_DELETE '(' NAME ')' /* @@ -1172,12 +1256,10 @@ regular_print: else if ($3->memory == func_table) fatal(_("`delete' is not allowed with FUNCTAB")); } - $$ = add_pending_comment($$); } | exp { $$ = optimize_assignment($1); - $$ = add_pending_comment($$); } ; @@ -1212,6 +1294,7 @@ case_statement (void) list_prepend(casestmt, instruction(Op_exec_count)); $1->case_exp = $2; $1->case_stmt = casestmt; + $1->comment = $4; bcfree($3); $$ = $1; } @@ -1224,6 +1307,7 @@ case_statement (void) list_prepend(casestmt, instruction(Op_exec_count)); bcfree($2); $1->case_stmt = casestmt; + $1->comment = $3; $$ = $1; } ; @@ -1305,23 +1389,48 @@ output_redir if_statement : LEX_IF '(' exp r_paren opt_nls statement { + if ($5 != NULL) + $1->comment = $5; $$ = mk_condition($3, $1, $6, NULL, NULL); } | LEX_IF '(' exp r_paren opt_nls statement LEX_ELSE opt_nls statement { + if ($5 != NULL) + $1->comment = $5; + if ($8 != NULL) + $7->comment = $8; $$ = mk_condition($3, $1, $6, $7, $9); } ; nls - : NEWLINE + : NEWLINE { $$ = $1; } | nls NEWLINE + { + if ($1 != NULL && $2 != NULL) { + if ($1->memory->comment_type == EOL_COMMENT) { + assert($2->memory->comment_type == BLOCK_COMMENT); + $1->comment = $2; // chain them + } else { + merge_comments($1, $2); + } + + $$ = $1; + } else if ($1 != NULL) { + $$ = $1; + } else if ($2 != NULL) { + $$ = $2; + } else + $$ = NULL; + } ; opt_nls : /* empty */ + { $$ = NULL; } | nls + { $$ = $1; } ; input_redir @@ -1350,9 +1459,17 @@ param_list | param_list comma NAME { if ($1 != NULL && $3 != NULL) { - $3->param_count = $1->lasti->param_count + 1; + $3->param_count = $1->lasti->param_count + 1; $$ = list_append($1, $3); yyerrok; + + // newlines are allowed after commas, catch any comments + if ($2 != NULL) { + if ($1->comment != NULL) + merge_comments($1->comment, $2); + else + $1->comment = $2; + } } else $$ = NULL; } @@ -2006,15 +2123,16 @@ opt_incdec { $1->opcode = Op_postdecrement; } - | /* empty */ { $$ = NULL; } + | /* empty */ + { $$ = NULL; } ; l_brace - : '{' opt_nls + : '{' opt_nls { $$ = $2; } ; r_brace - : '}' opt_nls { yyerrok; } + : '}' opt_nls { $$ = $2; yyerrok; } ; r_paren @@ -2023,6 +2141,7 @@ r_paren opt_semi : /* empty */ + { $$ = NULL; } | semi ; @@ -2035,7 +2154,7 @@ colon ; comma - : ',' opt_nls { yyerrok; } + : ',' opt_nls { $$ = $2; yyerrok; } ; %% @@ -2115,8 +2234,8 @@ static const struct token tokentab[] = { {"exp", Op_builtin, LEX_BUILTIN, A(1), do_exp, MPF(exp)}, {"fflush", Op_builtin, LEX_BUILTIN, A(0)|A(1), do_fflush, 0}, {"for", Op_K_for, LEX_FOR, BREAK|CONTINUE, 0, 0}, -{"func", Op_func, LEX_FUNCTION, NOT_POSIX|NOT_OLD, 0, 0}, -{"function",Op_func, LEX_FUNCTION, NOT_OLD, 0, 0}, +{"func", Op_func, LEX_FUNCTION, NOT_POSIX|NOT_OLD, 0, 0}, +{"function", Op_func, LEX_FUNCTION, NOT_OLD, 0, 0}, {"gensub", Op_sub_builtin, LEX_BUILTIN, GAWKX|A(3)|A(4), 0, 0}, {"getline", Op_K_getline_redir, LEX_GETLINE, NOT_OLD, 0, 0}, {"gsub", Op_sub_builtin, LEX_BUILTIN, NOT_OLD|A(2)|A(3), 0, 0}, @@ -2475,11 +2594,6 @@ mk_program() cp = end_block; else cp = list_merge(begin_block, end_block); - if (program_comment != NULL) { - (void) list_prepend(cp, program_comment); - } - if (comment != NULL) - (void) list_append(cp, comment); (void) list_append(cp, ip_atexit); (void) list_append(cp, instruction(Op_stop)); @@ -2512,12 +2626,6 @@ mk_program() if (begin_block != NULL) cp = list_merge(begin_block, cp); - if (program_comment != NULL) { - (void) list_prepend(cp, program_comment); - } - if (comment != NULL) { - (void) list_append(cp, comment); - } (void) list_append(cp, ip_atexit); (void) list_append(cp, instruction(Op_stop)); @@ -2525,10 +2633,6 @@ out: /* delete the Op_list, not needed */ tmp = cp->nexti; bcfree(cp); - /* these variables are not used again but zap them anyway. */ - comment = NULL; - function_comment = NULL; - program_comment = NULL; return tmp; #undef begin_block @@ -2703,7 +2807,7 @@ add_srcfile(enum srctype stype, char *src, SRCFILE *thisfile, bool *already_incl /* include_source --- read program from source included using `@include' */ -static int +static bool include_source(INSTRUCTION *file) { SRCFILE *s; @@ -2713,23 +2817,23 @@ include_source(INSTRUCTION *file) if (do_traditional || do_posix) { error_ln(file->source_line, _("@include is a gawk extension")); - return -1; + return false; } if (strlen(src) == 0) { if (do_lint) lintwarn_ln(file->source_line, _("empty filename after @include")); - return 0; + return true; } s = add_srcfile(SRC_INC, src, sourcefile, &already_included, &errcode); if (s == NULL) { if (already_included) - return 0; + return true; error_ln(file->source_line, _("can't open source file `%s' for reading (%s)"), src, errcode ? strerror(errcode) : _("reason unknown")); - return -1; + return false; } /* save scanner state for the current sourcefile */ @@ -2748,42 +2852,45 @@ include_source(INSTRUCTION *file) lasttok = 0; lexeof = false; eof_warned = false; - return 0; + return true; } /* load_library --- load a shared library */ -static int -load_library(INSTRUCTION *file) +static bool +load_library(INSTRUCTION *file, void **srcfile_p) { SRCFILE *s; char *src = file->lextok; int errcode; bool already_included; + *srcfile_p = NULL; + if (do_traditional || do_posix) { error_ln(file->source_line, _("@load is a gawk extension")); - return -1; + return false; } if (strlen(src) == 0) { if (do_lint) lintwarn_ln(file->source_line, _("empty filename after @load")); - return 0; + return true; } s = add_srcfile(SRC_EXTLIB, src, sourcefile, &already_included, &errcode); if (s == NULL) { if (already_included) - return 0; + return true; error_ln(file->source_line, _("can't open shared library `%s' for reading (%s)"), src, errcode ? strerror(errcode) : _("reason unknown")); - return -1; + return false; } load_ext(s->fullpath); - return 0; + *srcfile_p = (void *) s; + return true; } /* next_sourcefile --- read program from the next source in srcfiles */ @@ -3191,37 +3298,23 @@ pushback(void) (! lexeof && lexptr && lexptr > lexptr_begin ? lexptr-- : lexptr); } -/* check_comment --- check for block comment */ - -void -check_comment(void) -{ - if (comment != NULL) { - if (first_rule) { - program_comment = comment; - } else - block_comment = comment; - comment = NULL; - } - first_rule = false; -} - /* * get_comment --- collect comment text. * Flag = EOL_COMMENT for end-of-line comments. - * Flag = FULL_COMMENT for self-contained comments. + * Flag = BLOCK_COMMENT for self-contained comments. */ -int -get_comment(int flag) +static int +get_comment(enum commenttype flag, INSTRUCTION **comment_instruction) { int c; int sl; + char *p1; + char *p2; + tok = tokstart; tokadd('#'); sl = sourceline; - char *p1; - char *p2; while (true) { while ((c = nextc(false)) != '\n' && c != END_FILE) { @@ -3257,9 +3350,6 @@ get_comment(int flag) break; } - if (comment != NULL) - prior_comment = comment; - /* remove any trailing blank lines (consecutive \n) from comment */ p1 = tok - 1; p2 = tok - 2; @@ -3269,49 +3359,18 @@ get_comment(int flag) tok--; } - comment = bcalloc(Op_comment, 1, sl); - comment->source_file = source; - comment->memory = make_str_node(tokstart, tok - tokstart, 0); - comment->memory->comment_type = flag; + (*comment_instruction) = bcalloc(Op_comment, 1, sl); + (*comment_instruction)->source_file = source; + (*comment_instruction)->memory = make_str_node(tokstart, tok - tokstart, 0); + (*comment_instruction)->memory->comment_type = flag; return c; } -/* split_comment --- split initial comment text into program and function parts */ - -static void -split_comment(void) -{ - char *p; - int l; - NODE *n; - - p = comment_to_save->memory->stptr; - l = comment_to_save->memory->stlen - 3; - /* have at least two comments so split at last blank line (\n\n) */ - while (l >= 0) { - if (p[l] == '\n' && p[l+1] == '\n') { - function_comment = comment_to_save; - n = function_comment->memory; - function_comment->memory = make_string(p + l + 2, n->stlen - l - 2); - /* create program comment */ - program_comment = bcalloc(Op_comment, 1, sourceline); - program_comment->source_file = comment_to_save->source_file; - p[l + 2] = 0; - program_comment->memory = make_str_node(p, l + 2, 0); - comment_to_save = NULL; - freenode(n); - break; - } - else - l--; - } -} - /* allow_newline --- allow newline after &&, ||, ? and : */ static void -allow_newline(void) +allow_newline(INSTRUCTION **new_comment) { int c; @@ -3323,8 +3382,8 @@ allow_newline(void) } if (c == '#') { if (do_pretty_print && ! do_profile) { - /* collect comment byte code iff doing pretty print but not profiling. */ - c = get_comment(EOL_COMMENT); + /* collect comment byte code iff doing pretty print but not profiling. */ + c = get_comment(EOL_COMMENT, new_comment); } else { while ((c = nextc(false)) != '\n' && c != END_FILE) continue; @@ -3391,6 +3450,7 @@ yylex(void) bool intlstr = false; AWKNUM d; bool collecting_typed_regexp = false; + static int qm_col_count = 0; #define GET_INSTRUCTION(op) bcalloc(op, 1, sourceline) @@ -3555,18 +3615,25 @@ retry: return lasttok = NEWLINE; case '#': /* it's a comment */ + yylval = NULL; if (do_pretty_print && ! do_profile) { /* * Collect comment byte code iff doing pretty print * but not profiling. */ + INSTRUCTION *new_comment; + if (lasttok == NEWLINE || lasttok == 0) - c = get_comment(FULL_COMMENT); + c = get_comment(BLOCK_COMMENT, & new_comment); else - c = get_comment(EOL_COMMENT); + c = get_comment(EOL_COMMENT, & new_comment); - if (c == END_FILE) - return lasttok = NEWLINE_EOF; + yylval = new_comment; + + if (c == END_FILE) { + pushback(); + return lasttok = NEWLINE; + } } else { while ((c = nextc(false)) != '\n') { if (c == END_FILE) @@ -3595,7 +3662,10 @@ retry: * Use it at your own risk. We think it's a bad idea, which * is why it's not on by default. */ + yylval = NULL; if (! do_traditional) { + INSTRUCTION *new_comment; + /* strip trailing white-space and/or comment */ while ((c = nextc(true)) == ' ' || c == '\t' || c == '\r') continue; @@ -3607,9 +3677,11 @@ retry: lintwarn( _("use of `\\ #...' line continuation is not portable")); } - if (do_pretty_print && ! do_profile) - c = get_comment(EOL_COMMENT); - else { + if (do_pretty_print && ! do_profile) { + c = get_comment(EOL_COMMENT, & new_comment); + yylval = new_comment; + return lasttok = c; + } else { while ((c = nextc(false)) != '\n') if (c == END_FILE) break; @@ -3630,11 +3702,19 @@ retry: } break; - case ':': case '?': + qm_col_count++; + // fall through + case ':': yylval = GET_INSTRUCTION(Op_cond_exp); - if (! do_posix) - allow_newline(); + if (c == ':' && qm_col_count > 0) { + if (do_posix) { + INSTRUCTION *new_comment = NULL; + allow_newline(& new_comment); + yylval->comment = new_comment; + } + qm_col_count--; + } return lasttok = c; /* @@ -4056,7 +4136,10 @@ retry: case '&': if ((c = nextc(true)) == '&') { yylval = GET_INSTRUCTION(Op_and); - allow_newline(); + INSTRUCTION *new_comment = NULL; + allow_newline(& new_comment); + yylval->comment = new_comment; + return lasttok = LEX_AND; } pushback(); @@ -4066,11 +4149,15 @@ retry: case '|': if ((c = nextc(true)) == '|') { yylval = GET_INSTRUCTION(Op_or); - allow_newline(); + INSTRUCTION *new_comment = NULL; + allow_newline(& new_comment); + yylval->comment = new_comment; + return lasttok = LEX_OR; } else if (! do_traditional && c == '&') { yylval = GET_INSTRUCTION(Op_symbol); yylval->redir_type = redirect_twoway; + return lasttok = (in_print && in_parens == 0 ? IO_OUT : IO_IN); } pushback(); @@ -4260,8 +4347,11 @@ out: yylval->lextok = tokkey; #define SMART_ALECK 1 - if (SMART_ALECK && do_lint - && ! goto_warned && strcasecmp(tokkey, "goto") == 0) { + if (SMART_ALECK + && do_lint + && ! goto_warned + && tolower(tokkey[0]) == 'g' + && strcasecmp(tokkey, "goto") == 0) { goto_warned = true; lintwarn(_("`goto' considered harmful!")); } @@ -4732,15 +4822,8 @@ mk_function(INSTRUCTION *fi, INSTRUCTION *def) thisfunc = fi->func_body; assert(thisfunc != NULL); - /* add any pre-function comment to start of action for profile.c */ - - if (function_comment != NULL) { - function_comment->source_line = 0; - (void) list_prepend(def, function_comment); - function_comment = NULL; - } - - /* add an implicit return at end; + /* + * Add an implicit return at end; * also used by 'return' command in debugger */ @@ -5451,12 +5534,7 @@ append_rule(INSTRUCTION *pattern, INSTRUCTION *action) (rp + 1)->lasti = action->lasti; (rp + 2)->first_line = pattern->source_line; (rp + 2)->last_line = lastline; - if (block_comment != NULL) { - ip = list_prepend(list_prepend(action, block_comment), rp); - block_comment = NULL; - } else - ip = list_prepend(action, rp); - + ip = list_prepend(action, rp); } else { rp = bcalloc(Op_rule, 3, 0); rp->in_rule = Rule; @@ -5861,8 +5939,9 @@ mk_for_loop(INSTRUCTION *forp, INSTRUCTION *init, INSTRUCTION *cond, forp->target_break = tbreak; forp->target_continue = tcont; ret = list_prepend(ret, forp); - } /* else - forp is NULL */ + } + /* else + forp is NULL */ return ret; } @@ -6076,26 +6155,6 @@ list_merge(INSTRUCTION *l1, INSTRUCTION *l2) return l1; } -/* add_pending_comment --- add a pending comment to a statement */ - -static inline INSTRUCTION * -add_pending_comment(INSTRUCTION *stmt) -{ - INSTRUCTION *ret = stmt; - - if (prior_comment != NULL) { - if (function_comment != prior_comment) - ret = list_append(stmt, prior_comment); - prior_comment = NULL; - } else if (comment != NULL && comment->memory->comment_type == EOL_COMMENT) { - if (function_comment != comment) - ret = list_append(stmt, comment); - comment = NULL; - } - - return ret; -} - /* See if name is a special token. */ int @@ -6335,3 +6394,125 @@ set_profile_text(NODE *n, const char *str, size_t len) return n; } + +/* + * merge_comments --- merge c2 into c1 and free c2 if successful. + * Allow c2 to be NULL, in which case just merged chained + * comments in c1. + */ + +static void +merge_comments(INSTRUCTION *c1, INSTRUCTION *c2) +{ + assert(c1->opcode == Op_comment); + + if (c1->comment == NULL && c2 == NULL) // nothing to do + return; + + size_t total = c1->memory->stlen; + if (c1->comment != NULL) + total += 1 /* \n */ + c1->comment->memory->stlen; + + if (c2 != NULL) { + assert(c2->opcode == Op_comment); + total += 1 /* \n */ + c2->memory->stlen; + if (c2->comment != NULL) + total += c2->comment->memory->stlen + 1; + } + + char *buffer; + emalloc(buffer, char *, total + 1, "merge_comments"); + + strcpy(buffer, c1->memory->stptr); + if (c1->comment != NULL) { + strcat(buffer, "\n"); + strcat(buffer, c1->comment->memory->stptr); + } + + if (c2 != NULL) { + strcat(buffer, "\n"); + strcat(buffer, c2->memory->stptr); + if (c2->comment != NULL) { + strcat(buffer, "\n"); + strcat(buffer, c2->comment->memory->stptr); + } + + unref(c2->memory); + if (c2->comment != NULL) { + unref(c2->comment->memory); + bcfree(c2->comment); + c2->comment = NULL; + } + bcfree(c2); + } + + c1->memory->comment_type = BLOCK_COMMENT; + free(c1->memory->stptr); + c1->memory->stptr = buffer; + c1->memory->stlen = strlen(buffer); + + // now free everything else + if (c1->comment != NULL) { + unref(c1->comment->memory); + bcfree(c1->comment); + c1->comment = NULL; + } +} + +/* make_braced_statements --- handle `l_brace statements r_brace' with comments */ + +static INSTRUCTION * +make_braced_statements(INSTRUCTION *lbrace, INSTRUCTION *stmts, INSTRUCTION *rbrace) +{ + INSTRUCTION *ip; + + if (stmts == NULL) + ip = list_create(instruction(Op_no_op)); + else + ip = stmts; + + if (lbrace != NULL) { + INSTRUCTION *comment2 = lbrace->comment; + if (comment2 != NULL) { + ip = list_prepend(ip, comment2); + lbrace->comment = NULL; + } + ip = list_prepend(ip, lbrace); + } + + /* Tack any comment onto the end. */ + if (rbrace != NULL) { + INSTRUCTION *comment2 = rbrace->comment; + rbrace->comment = NULL; + if (rbrace->memory->comment_type == EOL_COMMENT) + rbrace->memory->comment_type = BLOCK_COMMENT; + ip = list_append(ip, rbrace); + if (comment2 != NULL) + ip = list_append(ip, comment2); + } + + return ip; +} + +/* make_include_comment --- create a commented @include statement */ + +static INSTRUCTION * +make_include_comment(const char *filename) +{ + assert(do_pretty_print); + + static char format[] = "# @include \"%s\"\n"; + static size_t formatlen = sizeof(format); + + size_t count = formatlen + strlen(filename); + char *buffer; + + emalloc(buffer, char *, count + 1, "make_include_comment"); + sprintf(buffer, format, filename); + + NODE *mem = make_str_node(buffer, strlen(buffer), ALREADY_MALLOCED); + INSTRUCTION *com = instruction(Op_comment); + com->memory = mem; + + return com; +} @@ -3807,7 +3807,12 @@ print_instruction(INSTRUCTION *pc, Func_print print_func, FILE *fp, int in_dump) break; case Op_K_do: - print_func(fp, "[doloop_cond = %p] [target_break = %p]\n", (pc+1)->doloop_cond, pc->target_break); + print_func(fp, "[doloop_cond = %p] [target_break = %p]", (pc+1)->doloop_cond, pc->target_break); + if (pc->comment) + print_func(fp, " [comment = %p]", pc->comment); + print_func(fp, "\n"); + if (pc->comment) + print_instruction(pc->comment, print_func, fp, in_dump); break; case Op_K_for: @@ -3815,15 +3820,44 @@ print_instruction(INSTRUCTION *pc, Func_print print_func, FILE *fp, int in_dump) /* fall through */ case Op_K_arrayfor: print_func(fp, "[forloop_body = %p] ", (pc+1)->forloop_body); - print_func(fp, "[target_break = %p] [target_continue = %p]\n", pc->target_break, pc->target_continue); + print_func(fp, "[target_break = %p] [target_continue = %p]", pc->target_break, pc->target_continue); + if (pc->comment != NULL) { + print_func(fp, " [comment = %p]\n", (pc)->comment); + print_instruction(pc->comment, print_func, fp, in_dump); + } else + print_func(fp, "\n"); break; case Op_K_switch: + { + bool need_newline = false; print_func(fp, "[switch_start = %p] [switch_end = %p]\n", (pc+1)->switch_start, (pc+1)->switch_end); + if (pc->comment || (pc+1)->switch_end->comment) + print_func(fp, "%*s", noffset, ""); + if (pc->comment) { + print_func(fp, "[start_comment = %p]", pc->comment); + need_newline = true; + } + if ((pc+1)->switch_end->comment) { + print_func(fp, "[end_comment = %p]", (pc + 1)->switch_end->comment); + need_newline = true; + } + if (need_newline) + print_func(fp, "\n"); + if (pc->comment) + print_instruction(pc->comment, print_func, fp, in_dump); + if ((pc+1)->switch_end->comment) + print_instruction((pc+1)->switch_end->comment, print_func, fp, in_dump); + } break; case Op_K_default: - print_func(fp, "[stmt_start = %p] [stmt_end = %p]\n", pc->stmt_start, pc->stmt_end); + print_func(fp, "[stmt_start = %p] [stmt_end = %p]", pc->stmt_start, pc->stmt_end); + if (pc->comment) { + print_func(fp, " [comment = %p]\n", pc->comment); + print_instruction(pc->comment, print_func, fp, in_dump); + } else + print_func(fp, "\n"); break; case Op_var_update: @@ -3915,8 +3949,13 @@ print_instruction(INSTRUCTION *pc, Func_print print_func, FILE *fp, int in_dump) break; case Op_K_case: - print_func(fp, "[target_jmp = %p] [match_exp = %s]\n", + print_func(fp, "[target_jmp = %p] [match_exp = %s]", pc->target_jmp, (pc + 1)->match_exp ? "true" : "false"); + if (pc->comment) { + print_func(fp, " [comment = %p]\n", pc->comment); + print_instruction(pc->comment, print_func, fp, in_dump); + } else + print_func(fp, "\n"); break; case Op_arrayfor_incr: @@ -4032,9 +4071,14 @@ print_instruction(INSTRUCTION *pc, Func_print print_func, FILE *fp, int in_dump) case Op_comment: print_memory(pc->memory, func, print_func, fp); - print_func(fp, " [comment_type = %s]\n", + print_func(fp, " [comment_type = %s]", pc->memory->comment_type == EOL_COMMENT ? - "EOL" : "FULL"); + "EOL" : "BLOCK"); + if (pc->comment) { + print_func(fp, " [comment = %p]\n", pc->comment); + print_instruction(pc->comment, print_func, fp, in_dump); + } else + print_func(fp, "\n"); break; case Op_push_i: diff --git a/doc/ChangeLog b/doc/ChangeLog index ff7a56d0..0db90da7 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -9,6 +9,12 @@ Communications Guidelines, with URL. * texinfo.tex: Updated from GNULIB. +2018-10-17 Arnold D. Robbins <arnold@skeeve.com> + + * gawktexi.in (Profiling): Revise example for pattern without + action and note that the profiler distinguishes `print' and + `print $0'. + 2018-09-23 Arnold D. Robbins <arnold@skeeve.com> * gawktexi.in (Extracting): Note that patch levels above diff --git a/doc/gawk.info b/doc/gawk.info index b0c5b3c5..c36c34ea 100644 --- a/doc/gawk.info +++ b/doc/gawk.info @@ -20781,10 +20781,11 @@ representation. Also, things such as: come out as: /foo/ { - print $0 + print } -which is correct, but possibly unexpected. +which is correct, but possibly unexpected. (If a program uses both +'print $0' and plain 'print', that distinction is retained.) Besides creating profiles when a program has completed, 'gawk' can produce a profile while it is running. This is useful if your 'awk' @@ -34143,7 +34144,7 @@ Index * dump debugger command: Miscellaneous Debugger Commands. (line 9) * dupword.awk program: Dupword Program. (line 31) -* dynamic profiling: Profiling. (line 177) +* dynamic profiling: Profiling. (line 178) * dynamically loaded extensions: Dynamic Extensions. (line 6) * e debugger command (alias for enable): Breakpoint Control. (line 73) * EBCDIC: Ordinal Functions. (line 45) @@ -34532,7 +34533,7 @@ Index * G., Daniel Richard: Acknowledgments. (line 60) * G., Daniel Richard <1>: Maintainers. (line 14) * Garfinkle, Scott: Contributors. (line 35) -* gawk program, dynamic profiling: Profiling. (line 177) +* gawk program, dynamic profiling: Profiling. (line 178) * gawk version: Auto-set. (line 241) * gawk, ARGIND variable in: Other Arguments. (line 15) * gawk, awk and: Preface. (line 21) @@ -34737,7 +34738,7 @@ Index * history expansion, in debugger: Readline Support. (line 6) * histsort.awk program: History Sorting. (line 25) * Hughes, Phil: Acknowledgments. (line 43) -* HUP signal, for dynamic profiling: Profiling. (line 209) +* HUP signal, for dynamic profiling: Profiling. (line 210) * hyphen (-), - operator: Precedence. (line 51) * hyphen (-), - operator <1>: Precedence. (line 57) * hyphen (-), -- operator: Increment Ops. (line 48) @@ -34819,7 +34820,7 @@ Index * installing gawk: Installation. (line 6) * instruction tracing, in debugger: Debugger Info. (line 90) * int: Numeric Functions. (line 24) -* INT signal (MS-Windows): Profiling. (line 212) +* INT signal (MS-Windows): Profiling. (line 213) * integer array indices: Numeric Array Subscripts. (line 31) * integers, arbitrary precision: Arbitrary Precision Integers. @@ -34875,7 +34876,7 @@ Index * Kernighan, Brian <8>: Other Versions. (line 13) * Kernighan, Brian <9>: Basic Data Typing. (line 54) * Kernighan, Brian <10>: Glossary. (line 204) -* kill command, dynamic profiling: Profiling. (line 186) +* kill command, dynamic profiling: Profiling. (line 187) * Knights, jedi: Undocumented. (line 6) * Kwok, Conrad: Contributors. (line 35) * l debugger command (alias for list): Miscellaneous Debugger Commands. @@ -35389,7 +35390,7 @@ Index * PROCINFO, values of sorted_in: Controlling Scanning. (line 26) * profiling awk programs: Profiling. (line 6) -* profiling awk programs, dynamically: Profiling. (line 177) +* profiling awk programs, dynamically: Profiling. (line 178) * program identifiers: Auto-set. (line 193) * program, definition of: Getting Started. (line 21) * programming conventions, --non-decimal-data option: Nondecimal Data. @@ -35426,7 +35427,7 @@ Index * QuikTrim Awk: Other Versions. (line 135) * quit debugger command: Miscellaneous Debugger Commands. (line 100) -* QUIT signal (MS-Windows): Profiling. (line 212) +* QUIT signal (MS-Windows): Profiling. (line 213) * quoting in gawk command lines: Long. (line 26) * quoting in gawk command lines, tricks for: Quoting. (line 91) * quoting, for small awk programs: Comments. (line 27) @@ -35716,15 +35717,15 @@ Index (line 130) * sidebar, Using \n in Bracket Expressions of Dynamic Regexps: Computed Regexps. (line 58) -* SIGHUP signal, for dynamic profiling: Profiling. (line 209) -* SIGINT signal (MS-Windows): Profiling. (line 212) -* signals, HUP/SIGHUP, for profiling: Profiling. (line 209) -* signals, INT/SIGINT (MS-Windows): Profiling. (line 212) -* signals, QUIT/SIGQUIT (MS-Windows): Profiling. (line 212) -* signals, USR1/SIGUSR1, for profiling: Profiling. (line 186) +* SIGHUP signal, for dynamic profiling: Profiling. (line 210) +* SIGINT signal (MS-Windows): Profiling. (line 213) +* signals, HUP/SIGHUP, for profiling: Profiling. (line 210) +* signals, INT/SIGINT (MS-Windows): Profiling. (line 213) +* signals, QUIT/SIGQUIT (MS-Windows): Profiling. (line 213) +* signals, USR1/SIGUSR1, for profiling: Profiling. (line 187) * signature program: Signature Program. (line 6) -* SIGQUIT signal (MS-Windows): Profiling. (line 212) -* SIGUSR1 signal, for dynamic profiling: Profiling. (line 186) +* SIGQUIT signal (MS-Windows): Profiling. (line 213) +* SIGUSR1 signal, for dynamic profiling: Profiling. (line 187) * silent debugger command: Debugger Execution Control. (line 10) * sin: Numeric Functions. (line 75) @@ -36004,7 +36005,7 @@ Index * user-modifiable variables: User-modified. (line 6) * users, information about, printing: Id Program. (line 6) * users, information about, retrieving: Passwd Functions. (line 16) -* USR1 signal, for dynamic profiling: Profiling. (line 186) +* USR1 signal, for dynamic profiling: Profiling. (line 187) * values, numeric: Basic Data Typing. (line 13) * values, string: Basic Data Typing. (line 13) * variable assignments and input files: Other Arguments. (line 26) @@ -36472,218 +36473,218 @@ Ref: Two-way I/O-Footnote-1835052 Ref: Two-way I/O-Footnote-2835239 Node: TCP/IP Networking835321 Node: Profiling838439 -Ref: Profiling-Footnote-1847111 -Node: Advanced Features Summary847434 -Node: Internationalization849278 -Node: I18N and L10N850758 -Node: Explaining gettext851445 -Ref: Explaining gettext-Footnote-1857337 -Ref: Explaining gettext-Footnote-2857522 -Node: Programmer i18n857687 -Ref: Programmer i18n-Footnote-1862636 -Node: Translator i18n862685 -Node: String Extraction863479 -Ref: String Extraction-Footnote-1864611 -Node: Printf Ordering864697 -Ref: Printf Ordering-Footnote-1867483 -Node: I18N Portability867547 -Ref: I18N Portability-Footnote-1870003 -Node: I18N Example870066 -Ref: I18N Example-Footnote-1872872 -Node: Gawk I18N872945 -Node: I18N Summary873590 -Node: Debugger874931 -Node: Debugging875954 -Node: Debugging Concepts876395 -Node: Debugging Terms878204 -Node: Awk Debugging880779 -Node: Sample Debugging Session881685 -Node: Debugger Invocation882219 -Node: Finding The Bug883605 -Node: List of Debugger Commands890083 -Node: Breakpoint Control891416 -Node: Debugger Execution Control895110 -Node: Viewing And Changing Data898472 -Node: Execution Stack901846 -Node: Debugger Info903483 -Node: Miscellaneous Debugger Commands907554 -Node: Readline Support912616 -Node: Limitations913512 -Node: Debugging Summary915621 -Node: Arbitrary Precision Arithmetic916900 -Node: Computer Arithmetic918385 -Ref: table-numeric-ranges922151 -Ref: table-floating-point-ranges922644 -Ref: Computer Arithmetic-Footnote-1923302 -Node: Math Definitions923359 -Ref: table-ieee-formats926675 -Ref: Math Definitions-Footnote-1927278 -Node: MPFR features927383 -Node: FP Math Caution929101 -Ref: FP Math Caution-Footnote-1930173 -Node: Inexactness of computations930542 -Node: Inexact representation931502 -Node: Comparing FP Values932862 -Node: Errors accumulate934103 -Node: Getting Accuracy935536 -Node: Try To Round938246 -Node: Setting precision939145 -Ref: table-predefined-precision-strings939842 -Node: Setting the rounding mode941672 -Ref: table-gawk-rounding-modes942046 -Ref: Setting the rounding mode-Footnote-1945977 -Node: Arbitrary Precision Integers946156 -Ref: Arbitrary Precision Integers-Footnote-1949331 -Node: Checking for MPFR949480 -Node: POSIX Floating Point Problems950954 -Ref: POSIX Floating Point Problems-Footnote-1955239 -Node: Floating point summary955277 -Node: Dynamic Extensions957467 -Node: Extension Intro959020 -Node: Plugin License960286 -Node: Extension Mechanism Outline961083 -Ref: figure-load-extension961522 -Ref: figure-register-new-function963087 -Ref: figure-call-new-function964179 -Node: Extension API Description966241 -Node: Extension API Functions Introduction967883 -Node: General Data Types973423 -Ref: General Data Types-Footnote-1981784 -Node: Memory Allocation Functions982083 -Ref: Memory Allocation Functions-Footnote-1986293 -Node: Constructor Functions986392 -Node: Registration Functions989978 -Node: Extension Functions990663 -Node: Exit Callback Functions995878 -Node: Extension Version String997128 -Node: Input Parsers997791 -Node: Output Wrappers1010512 -Node: Two-way processors1015024 -Node: Printing Messages1017289 -Ref: Printing Messages-Footnote-11018460 -Node: Updating ERRNO1018613 -Node: Requesting Values1019352 -Ref: table-value-types-returned1020089 -Node: Accessing Parameters1021025 -Node: Symbol Table Access1022260 -Node: Symbol table by name1022772 -Node: Symbol table by cookie1024561 -Ref: Symbol table by cookie-Footnote-11028746 -Node: Cached values1028810 -Ref: Cached values-Footnote-11032346 -Node: Array Manipulation1032499 -Ref: Array Manipulation-Footnote-11033590 -Node: Array Data Types1033627 -Ref: Array Data Types-Footnote-11036285 -Node: Array Functions1036377 -Node: Flattening Arrays1040875 -Node: Creating Arrays1047851 -Node: Redirection API1052618 -Node: Extension API Variables1055451 -Node: Extension Versioning1056162 -Ref: gawk-api-version1056591 -Node: Extension GMP/MPFR Versioning1058322 -Node: Extension API Informational Variables1059950 -Node: Extension API Boilerplate1061023 -Node: Changes from API V11064997 -Node: Finding Extensions1066569 -Node: Extension Example1067128 -Node: Internal File Description1067926 -Node: Internal File Ops1072006 -Ref: Internal File Ops-Footnote-11083356 -Node: Using Internal File Ops1083496 -Ref: Using Internal File Ops-Footnote-11085879 -Node: Extension Samples1086153 -Node: Extension Sample File Functions1087682 -Node: Extension Sample Fnmatch1095331 -Node: Extension Sample Fork1096818 -Node: Extension Sample Inplace1098036 -Node: Extension Sample Ord1101253 -Node: Extension Sample Readdir1102089 -Ref: table-readdir-file-types1102978 -Node: Extension Sample Revout1103783 -Node: Extension Sample Rev2way1104372 -Node: Extension Sample Read write array1105112 -Node: Extension Sample Readfile1107054 -Node: Extension Sample Time1108149 -Node: Extension Sample API Tests1109497 -Node: gawkextlib1109989 -Node: Extension summary1112907 -Node: Extension Exercises1116609 -Node: Language History1118107 -Node: V7/SVR3.11119763 -Node: SVR41121915 -Node: POSIX1123349 -Node: BTL1124729 -Node: POSIX/GNU1125458 -Node: Feature History1131236 -Node: Common Extensions1147095 -Node: Ranges and Locales1148378 -Ref: Ranges and Locales-Footnote-11152994 -Ref: Ranges and Locales-Footnote-21153021 -Ref: Ranges and Locales-Footnote-31153256 -Node: Contributors1153477 -Node: History summary1159422 -Node: Installation1160802 -Node: Gawk Distribution1161746 -Node: Getting1162230 -Node: Extracting1163193 -Node: Distribution contents1164831 -Node: Unix Installation1171311 -Node: Quick Installation1171993 -Node: Shell Startup Files1174407 -Node: Additional Configuration Options1175496 -Node: Configuration Philosophy1177661 -Node: Non-Unix Installation1180030 -Node: PC Installation1180490 -Node: PC Binary Installation1181328 -Node: PC Compiling1181763 -Node: PC Using1182880 -Node: Cygwin1186095 -Node: MSYS1187194 -Node: VMS Installation1187695 -Node: VMS Compilation1188486 -Ref: VMS Compilation-Footnote-11189715 -Node: VMS Dynamic Extensions1189773 -Node: VMS Installation Details1191458 -Node: VMS Running1193711 -Node: VMS GNV1197990 -Node: VMS Old Gawk1198725 -Node: Bugs1199196 -Node: Bug address1199859 -Node: Usenet1202841 -Node: Maintainers1203845 -Node: Other Versions1205106 -Node: Installation summary1211664 -Node: Notes1212866 -Node: Compatibility Mode1213660 -Node: Additions1214442 -Node: Accessing The Source1215367 -Node: Adding Code1216804 -Node: New Ports1223023 -Node: Derived Files1227511 -Ref: Derived Files-Footnote-11233157 -Ref: Derived Files-Footnote-21233192 -Ref: Derived Files-Footnote-31233790 -Node: Future Extensions1233904 -Node: Implementation Limitations1234562 -Node: Extension Design1235745 -Node: Old Extension Problems1236889 -Ref: Old Extension Problems-Footnote-11238407 -Node: Extension New Mechanism Goals1238464 -Ref: Extension New Mechanism Goals-Footnote-11241828 -Node: Extension Other Design Decisions1242017 -Node: Extension Future Growth1244130 -Node: Notes summary1244966 -Node: Basic Concepts1246141 -Node: Basic High Level1246822 -Ref: figure-general-flow1247104 -Ref: figure-process-flow1247789 -Ref: Basic High Level-Footnote-11251090 -Node: Basic Data Typing1251275 -Node: Glossary1254603 -Node: Copying1286441 -Node: GNU Free Documentation License1323984 -Node: Index1349104 +Ref: Profiling-Footnote-1847194 +Node: Advanced Features Summary847517 +Node: Internationalization849361 +Node: I18N and L10N850841 +Node: Explaining gettext851528 +Ref: Explaining gettext-Footnote-1857420 +Ref: Explaining gettext-Footnote-2857605 +Node: Programmer i18n857770 +Ref: Programmer i18n-Footnote-1862719 +Node: Translator i18n862768 +Node: String Extraction863562 +Ref: String Extraction-Footnote-1864694 +Node: Printf Ordering864780 +Ref: Printf Ordering-Footnote-1867566 +Node: I18N Portability867630 +Ref: I18N Portability-Footnote-1870086 +Node: I18N Example870149 +Ref: I18N Example-Footnote-1872955 +Node: Gawk I18N873028 +Node: I18N Summary873673 +Node: Debugger875014 +Node: Debugging876037 +Node: Debugging Concepts876478 +Node: Debugging Terms878287 +Node: Awk Debugging880862 +Node: Sample Debugging Session881768 +Node: Debugger Invocation882302 +Node: Finding The Bug883688 +Node: List of Debugger Commands890166 +Node: Breakpoint Control891499 +Node: Debugger Execution Control895193 +Node: Viewing And Changing Data898555 +Node: Execution Stack901929 +Node: Debugger Info903566 +Node: Miscellaneous Debugger Commands907637 +Node: Readline Support912699 +Node: Limitations913595 +Node: Debugging Summary915704 +Node: Arbitrary Precision Arithmetic916983 +Node: Computer Arithmetic918468 +Ref: table-numeric-ranges922234 +Ref: table-floating-point-ranges922727 +Ref: Computer Arithmetic-Footnote-1923385 +Node: Math Definitions923442 +Ref: table-ieee-formats926758 +Ref: Math Definitions-Footnote-1927361 +Node: MPFR features927466 +Node: FP Math Caution929184 +Ref: FP Math Caution-Footnote-1930256 +Node: Inexactness of computations930625 +Node: Inexact representation931585 +Node: Comparing FP Values932945 +Node: Errors accumulate934186 +Node: Getting Accuracy935619 +Node: Try To Round938329 +Node: Setting precision939228 +Ref: table-predefined-precision-strings939925 +Node: Setting the rounding mode941755 +Ref: table-gawk-rounding-modes942129 +Ref: Setting the rounding mode-Footnote-1946060 +Node: Arbitrary Precision Integers946239 +Ref: Arbitrary Precision Integers-Footnote-1949414 +Node: Checking for MPFR949563 +Node: POSIX Floating Point Problems951037 +Ref: POSIX Floating Point Problems-Footnote-1955322 +Node: Floating point summary955360 +Node: Dynamic Extensions957550 +Node: Extension Intro959103 +Node: Plugin License960369 +Node: Extension Mechanism Outline961166 +Ref: figure-load-extension961605 +Ref: figure-register-new-function963170 +Ref: figure-call-new-function964262 +Node: Extension API Description966324 +Node: Extension API Functions Introduction967966 +Node: General Data Types973506 +Ref: General Data Types-Footnote-1981867 +Node: Memory Allocation Functions982166 +Ref: Memory Allocation Functions-Footnote-1986376 +Node: Constructor Functions986475 +Node: Registration Functions990061 +Node: Extension Functions990746 +Node: Exit Callback Functions995961 +Node: Extension Version String997211 +Node: Input Parsers997874 +Node: Output Wrappers1010595 +Node: Two-way processors1015107 +Node: Printing Messages1017372 +Ref: Printing Messages-Footnote-11018543 +Node: Updating ERRNO1018696 +Node: Requesting Values1019435 +Ref: table-value-types-returned1020172 +Node: Accessing Parameters1021108 +Node: Symbol Table Access1022343 +Node: Symbol table by name1022855 +Node: Symbol table by cookie1024644 +Ref: Symbol table by cookie-Footnote-11028829 +Node: Cached values1028893 +Ref: Cached values-Footnote-11032429 +Node: Array Manipulation1032582 +Ref: Array Manipulation-Footnote-11033673 +Node: Array Data Types1033710 +Ref: Array Data Types-Footnote-11036368 +Node: Array Functions1036460 +Node: Flattening Arrays1040958 +Node: Creating Arrays1047934 +Node: Redirection API1052701 +Node: Extension API Variables1055534 +Node: Extension Versioning1056245 +Ref: gawk-api-version1056674 +Node: Extension GMP/MPFR Versioning1058405 +Node: Extension API Informational Variables1060033 +Node: Extension API Boilerplate1061106 +Node: Changes from API V11065080 +Node: Finding Extensions1066652 +Node: Extension Example1067211 +Node: Internal File Description1068009 +Node: Internal File Ops1072089 +Ref: Internal File Ops-Footnote-11083439 +Node: Using Internal File Ops1083579 +Ref: Using Internal File Ops-Footnote-11085962 +Node: Extension Samples1086236 +Node: Extension Sample File Functions1087765 +Node: Extension Sample Fnmatch1095414 +Node: Extension Sample Fork1096901 +Node: Extension Sample Inplace1098119 +Node: Extension Sample Ord1101336 +Node: Extension Sample Readdir1102172 +Ref: table-readdir-file-types1103061 +Node: Extension Sample Revout1103866 +Node: Extension Sample Rev2way1104455 +Node: Extension Sample Read write array1105195 +Node: Extension Sample Readfile1107137 +Node: Extension Sample Time1108232 +Node: Extension Sample API Tests1109580 +Node: gawkextlib1110072 +Node: Extension summary1112990 +Node: Extension Exercises1116692 +Node: Language History1118190 +Node: V7/SVR3.11119846 +Node: SVR41121998 +Node: POSIX1123432 +Node: BTL1124812 +Node: POSIX/GNU1125541 +Node: Feature History1131319 +Node: Common Extensions1147178 +Node: Ranges and Locales1148461 +Ref: Ranges and Locales-Footnote-11153077 +Ref: Ranges and Locales-Footnote-21153104 +Ref: Ranges and Locales-Footnote-31153339 +Node: Contributors1153560 +Node: History summary1159505 +Node: Installation1160885 +Node: Gawk Distribution1161829 +Node: Getting1162313 +Node: Extracting1163276 +Node: Distribution contents1164914 +Node: Unix Installation1171394 +Node: Quick Installation1172076 +Node: Shell Startup Files1174490 +Node: Additional Configuration Options1175579 +Node: Configuration Philosophy1177744 +Node: Non-Unix Installation1180113 +Node: PC Installation1180573 +Node: PC Binary Installation1181411 +Node: PC Compiling1181846 +Node: PC Using1182963 +Node: Cygwin1186178 +Node: MSYS1187277 +Node: VMS Installation1187778 +Node: VMS Compilation1188569 +Ref: VMS Compilation-Footnote-11189798 +Node: VMS Dynamic Extensions1189856 +Node: VMS Installation Details1191541 +Node: VMS Running1193794 +Node: VMS GNV1198073 +Node: VMS Old Gawk1198808 +Node: Bugs1199279 +Node: Bug address1199942 +Node: Usenet1202924 +Node: Maintainers1203928 +Node: Other Versions1205189 +Node: Installation summary1211747 +Node: Notes1212949 +Node: Compatibility Mode1213743 +Node: Additions1214525 +Node: Accessing The Source1215450 +Node: Adding Code1216887 +Node: New Ports1223106 +Node: Derived Files1227594 +Ref: Derived Files-Footnote-11233240 +Ref: Derived Files-Footnote-21233275 +Ref: Derived Files-Footnote-31233873 +Node: Future Extensions1233987 +Node: Implementation Limitations1234645 +Node: Extension Design1235828 +Node: Old Extension Problems1236972 +Ref: Old Extension Problems-Footnote-11238490 +Node: Extension New Mechanism Goals1238547 +Ref: Extension New Mechanism Goals-Footnote-11241911 +Node: Extension Other Design Decisions1242100 +Node: Extension Future Growth1244213 +Node: Notes summary1245049 +Node: Basic Concepts1246224 +Node: Basic High Level1246905 +Ref: figure-general-flow1247187 +Ref: figure-process-flow1247872 +Ref: Basic High Level-Footnote-11251173 +Node: Basic Data Typing1251358 +Node: Glossary1254686 +Node: Copying1286524 +Node: GNU Free Documentation License1324067 +Node: Index1349187 End Tag Table diff --git a/doc/gawk.texi b/doc/gawk.texi index ea7dd7c6..bbba6ae2 100644 --- a/doc/gawk.texi +++ b/doc/gawk.texi @@ -29118,12 +29118,14 @@ come out as: @example /foo/ @{ - print $0 + print @} @end example @noindent which is correct, but possibly unexpected. +(If a program uses both @samp{print $0} and plain +@samp{print}, that distinction is retained.) @cindex profiling @command{awk} programs, dynamically @cindex @command{gawk} program, dynamic profiling diff --git a/doc/gawktexi.in b/doc/gawktexi.in index e3dbc89d..a021e139 100644 --- a/doc/gawktexi.in +++ b/doc/gawktexi.in @@ -28131,12 +28131,14 @@ come out as: @example /foo/ @{ - print $0 + print @} @end example @noindent which is correct, but possibly unexpected. +(If a program uses both @samp{print $0} and plain +@samp{print}, that distinction is retained.) @cindex profiling @command{awk} programs, dynamically @cindex @command{gawk} program, dynamic profiling @@ -208,6 +208,14 @@ pprint(INSTRUCTION *startp, INSTRUCTION *endp, int flags) int rule; static int rule_count[MAXRULE]; static bool skip_comment = false; + static const char tabs[] = "\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t"; + static const size_t tabs_len = sizeof(tabs) - 1; + +#define check_indent_level() + if (indent_level + 1 > tabs_len) \ + /* We're allowed to be snarky, occasionally. */ \ + fatal(_("Program indentation level too deep. Consider refactoring your code")); + for (pc = startp; pc != endp; pc = pc->nexti) { if (pc->source_line > 0) @@ -238,9 +246,9 @@ pprint(INSTRUCTION *startp, INSTRUCTION *endp, int flags) if (rule != Rule) { /* Allow for pre-non-rule-block comment */ - if (pc->nexti != (pc +1)->firsti + if (pc->nexti != (pc+1)->firsti && pc->nexti->opcode == Op_comment - && pc->nexti->memory->comment_type == FULL_COMMENT) + && pc->nexti->memory->comment_type == BLOCK_COMMENT) print_comment(pc->nexti, -1); ip1 = (pc + 1)->firsti; ip2 = (pc + 1)->lasti; @@ -399,7 +407,21 @@ cleanup: t2 = pp_pop(); t1 = pp_pop(); parenthesize(pc->opcode, t1, t2); - str = pp_group3(t1->pp_str, op2str(pc->opcode), t2->pp_str); + if (pc->comment == NULL) + str = pp_group3(t1->pp_str, op2str(pc->opcode), t2->pp_str); + else { + check_indent_level(); + + size_t len = strlen(t1->pp_str) + + strlen(op2str(pc->opcode)) + strlen(t2->pp_str) // foo && bar + + indent_level + 1 // indent + + pc->comment->memory->stlen + 3; // tab comment + + emalloc(str, char *, len, "pprint"); + sprintf(str, "%s%s%s%.*s %s", t1->pp_str, op2str(pc->opcode), + pc->comment->memory->stptr, + (int) indent_level + 1, tabs, t2->pp_str); + } pp_free(t1); pp_free(t2); pp_push(pc->opcode, str, CAN_FREE); @@ -624,7 +646,8 @@ cleanup: case Op_K_printf: case Op_K_print_rec: if (pc->opcode == Op_K_print_rec) - tmp = pp_group3(" ", op2str(Op_field_spec), "0"); + // instead of `print $0', just `print' + tmp = strdup(""); else if (pc->redir_type != 0) tmp = pp_list(pc->expr_count, "()", ", "); else { @@ -820,13 +843,34 @@ cleanup: indent(SPACEOVER); t1 = pp_pop(); fprintf(prof_fp, "} %s (%s)", op2str(Op_K_while), t1->pp_str); + if (pc->comment) + fprintf(prof_fp, "\t%s", pc->comment->memory->stptr); + else { + end_line(pc->target_break); + skip_comment = true; + } pp_free(t1); - end_line(pc->target_break); - skip_comment = true; pc = pc->target_break; break; case Op_K_for: + { + INSTRUCTION *comment1 = NULL, *comment2 = NULL; + + if (pc->comment != NULL) { + comment1 = pc->comment; + pc->comment = NULL; + if (comment1 != NULL && comment1->comment != NULL) { + comment2 = comment1->comment; + comment1->comment = NULL; + } + if (comment2 == NULL && comment1->memory->comment_type == FOR_COMMENT) { + comment2 = comment1; + comment2->memory->comment_type = EOL_COMMENT; + comment1 = NULL; + } + } + ip1 = pc + 1; indent(ip1->forloop_body->exec_count); fprintf(prof_fp, "%s (", op2str(pc->opcode)); @@ -834,12 +878,19 @@ cleanup: /* If empty for looop header, print it a little more nicely. */ if ( pc->nexti->opcode == Op_no_op && ip1->forloop_cond == pc->nexti - && pc->target_continue->opcode == Op_jmp) { + && pc->target_continue->opcode == Op_jmp + && comment1 == NULL && comment2 == NULL) { fprintf(prof_fp, ";;"); } else { pprint(pc->nexti, ip1->forloop_cond, IN_FOR_HEADER); fprintf(prof_fp, "; "); + if (comment1 != NULL) { + print_comment(comment1, 0); + indent(ip1->forloop_body->exec_count); + indent(1); + } + if (ip1->forloop_cond->opcode == Op_no_op && ip1->forloop_cond->nexti == ip1->forloop_body) fprintf(prof_fp, "; "); @@ -850,6 +901,12 @@ cleanup: pp_free(t1); } + if (comment2 != NULL) { + print_comment(comment2, 0); + indent(ip1->forloop_body->exec_count); + indent(1); + } + pprint(pc->target_continue, pc->target_break, IN_FOR_HEADER); } fprintf(prof_fp, ") {"); @@ -863,6 +920,7 @@ cleanup: end_line(pc->target_break); skip_comment = true; pc = pc->target_break; + } break; case Op_K_arrayfor: @@ -901,10 +959,14 @@ cleanup: pprint(pc->nexti, ip1->switch_start, NO_PPRINT_FLAGS); t1 = pp_pop(); fprintf(prof_fp, "%s) {\n", t1->pp_str); + if (pc->comment) + print_comment(pc->comment, 0); pp_free(t1); pprint(ip1->switch_start, ip1->switch_end, NO_PPRINT_FLAGS); indent(SPACEOVER); fprintf(prof_fp, "}\n"); + if (ip1->switch_end->comment) + print_comment(ip1->switch_end->comment, 0); pc = pc->target_break; break; @@ -914,13 +976,20 @@ cleanup: if (pc->opcode == Op_K_case) { t1 = pp_pop(); fprintf(prof_fp, "%s %s:", op2str(pc->opcode), t1->pp_str); - pc = end_line(pc); pp_free(t1); - } else { + } else fprintf(prof_fp, "%s:", op2str(pc->opcode)); - pc = end_line(pc); - } + indent_in(); + if (pc->comment != NULL) { + if (pc->comment->memory->comment_type == EOL_COMMENT) + fprintf(prof_fp, "\t%s", pc->comment->memory->stptr); + else { + fprintf(prof_fp, "\n"); + print_comment(pc->comment, indent_level); + } + } else + fprintf(prof_fp, "\n"); pprint(pc->stmt_start->nexti, pc->stmt_end->nexti, NO_PPRINT_FLAGS); indent_out(); break; @@ -937,6 +1006,8 @@ cleanup: fprintf(prof_fp, " # %ld", ip1->exec_count); ip1 = end_line(ip1); indent_in(); + if (pc->comment != NULL) + print_comment(pc->comment, indent_level); pprint(ip1->nexti, pc->branch_else, NO_PPRINT_FLAGS); indent_out(); pc = pc->branch_else; @@ -944,7 +1015,7 @@ cleanup: indent(SPACEOVER); fprintf(prof_fp, "}"); if (pc->nexti->nexti->opcode != Op_comment - || pc->nexti->nexti->memory->comment_type == FULL_COMMENT) + || pc->nexti->nexti->memory->comment_type == BLOCK_COMMENT) fprintf(prof_fp, "\n"); /* else It will be printed at the top. */ @@ -980,6 +1051,8 @@ cleanup: end_line(pc); skip_comment = true; indent_in(); + if (pc->comment != NULL) + print_comment(pc->comment, indent_level); pprint(pc->nexti, pc->branch_end, NO_PPRINT_FLAGS); indent_out(); indent(SPACEOVER); @@ -999,6 +1072,9 @@ cleanup: { NODE *f, *t, *cond; size_t len; + INSTRUCTION *qm_comment = NULL, *colon_comment = NULL; + + qm_comment = pc->comment; pprint(pc->nexti, pc->branch_if, NO_PPRINT_FLAGS); ip1 = pc->branch_if; @@ -1006,6 +1082,7 @@ cleanup: ip1 = pc->branch_else->nexti; pc = ip1->nexti; + colon_comment = pc->comment; assert(pc->opcode == Op_cond_exp); pprint(pc->nexti, pc->branch_end, NO_PPRINT_FLAGS); @@ -1013,9 +1090,72 @@ cleanup: t = pp_pop(); cond = pp_pop(); - len = f->pp_len + t->pp_len + cond->pp_len + 12; - emalloc(str, char *, len, "pprint"); - sprintf(str, "%s ? %s : %s", cond->pp_str, t->pp_str, f->pp_str); + /* + * This stuff handles comments that come after a ?, :, or both. + * Allowing newlines after ? and : is a gawk extension. + * Theoretically this is fragile, since ?: expressions can be nested. + * In practice, it's not, since if there was a comment following ? or : + * in the original code, then it wasn't nested. + */ + + len = f->pp_len + t->pp_len + cond->pp_len + 12; + if (qm_comment == NULL && colon_comment == NULL) { + // easy case + emalloc(str, char *, len, "pprint"); + sprintf(str, "%s ? %s : %s", cond->pp_str, t->pp_str, f->pp_str); + } else if (qm_comment != NULL && colon_comment != NULL) { + check_indent_level(); + len += qm_comment->memory->stlen + // comments + colon_comment->memory->stlen + + 2 * (indent_level + 1) + 3 + // indentation + t->pp_len + 6; + emalloc(str, char *, len, "pprint"); + sprintf(str, + "%s ? %s" // cond ? comment + "%.*s %s" // indent true-part + " : %s" // : comment + "%.*s %s", // indent false-part + cond->pp_str, // condition + qm_comment->memory->stptr, // comment + (int) indent_level + 1, tabs, // indent + t->pp_str, // true part + colon_comment->memory->stptr, // comment + (int) indent_level + 1, tabs, // indent + f->pp_str // false part + ); + } else if (qm_comment != NULL) { + check_indent_level(); + len += qm_comment->memory->stlen + // comment + 1 * (indent_level + 1) + 3 + // indentation + t->pp_len + 3; + emalloc(str, char *, len, "pprint"); + sprintf(str, + "%s ? %s" // cond ? comment + "%.*s %s" // indent true-part + " : %s", // : false-part + cond->pp_str, // condition + qm_comment->memory->stptr, // comment + (int) indent_level + 1, tabs, // indent + t->pp_str, // true part + f->pp_str // false part + ); + } else { + check_indent_level(); + len += colon_comment->memory->stlen + // comment + 1 * (indent_level + 1) + 3 + // indentation + t->pp_len + 3; + emalloc(str, char *, len, "pprint"); + sprintf(str, + "%s ? %s" // cond ? true-part + " : %s" // : comment + "%.*s %s", // indent false-part + cond->pp_str, // condition + t->pp_str, // true part + colon_comment->memory->stptr, // comment + (int) indent_level + 1, tabs, // indent + f->pp_str // false part + ); + } pp_free(cond); pp_free(t); @@ -1065,7 +1205,7 @@ end_line(INSTRUCTION *ip) return ret; } -/* pp_string_fp --- printy print a string to the fp */ +/* pp_string_fp --- pretty print a string to the fp */ /* * This routine concentrates string pretty printing in one place, @@ -1124,17 +1264,28 @@ print_lib_list(FILE *prof_fp) { SRCFILE *s; static bool printed_header = false; + const char *indent = ""; + bool found = false; + + if (do_profile) + indent = "\t"; for (s = srcfiles->next; s != srcfiles; s = s->next) { if (s->stype == SRC_EXTLIB) { - if (! printed_header) { + if (do_profile && ! printed_header) { printed_header = true; - fprintf(prof_fp, _("\t# Loaded extensions (-l and/or @load)\n\n")); + fprintf(prof_fp, _("%s# Loaded extensions (-l and/or @load)\n\n"), indent); } - fprintf(prof_fp, "\t@load \"%s\"\n", s->src); + found = true; + fprintf(prof_fp, "%s@load \"%s\"", indent, s->src); + if (s->comment != NULL) { + fprintf(prof_fp, "\t"); + print_comment(s->comment, indent_level + 1); + } else + fprintf(prof_fp, "\n"); } } - if (printed_header) /* we found some */ + if (found) /* we found some */ fprintf(prof_fp, "\n"); } @@ -1158,8 +1309,13 @@ print_comment(INSTRUCTION* pc, long in) after_newline = false; } putc(*text, prof_fp); - if (*text == '\n') - after_newline = true; + after_newline = (*text == '\n'); + } + + if (pc->comment) { + // chaining should only be two deep + assert(pc->comment->comment == NULL); + print_comment(pc->comment, in); } } @@ -1736,10 +1892,8 @@ pp_func(INSTRUCTION *pc, void *data ATTRIBUTE_UNUSED) fprintf(prof_fp, "\n"); /* print any function comment */ - if (fp->opcode == Op_comment && fp->source_line == 0) { - print_comment(fp, -1); /* -1 ==> don't indent */ - fp = fp->nexti; - } + if (pc->comment != NULL) + print_comment(pc->comment, -1); /* -1 ==> don't indent */ indent(pc->nexti->exec_count); fprintf(prof_fp, "%s %s(", op2str(Op_K_function), func->vname); diff --git a/test/ChangeLog b/test/ChangeLog index a331619e..9530e000 100644 --- a/test/ChangeLog +++ b/test/ChangeLog @@ -1,3 +1,7 @@ +2018-10-14 Arnold D. Robbins <arnold@skeeve.com> + + * profile0.ok: Updated after code change. + 2018-10-10 Arnold D. Robbins <arnold@skeeve.com> * Makefile.am (profile1): Add minus to ignore errors on final diff --git a/test/profile0.ok b/test/profile0.ok index 2e3c5728..42c464ba 100644 --- a/test/profile0.ok +++ b/test/profile0.ok @@ -1,6 +1,6 @@ # Rule(s) 2 NR == 1 { # 1 - 1 print $0 + 1 print } |