diff options
| -rw-r--r-- | winsup/cygwin/ChangeLog | 5 | ||||
| -rw-r--r-- | winsup/cygwin/syscalls.cc | 7 |
2 files changed, 12 insertions, 0 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 0805a1b51..2be62f2f3 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,8 @@ +2006-12-09 Corinna Vinschen <corinna@vinschen.de> + + * syscalls.cc (try_to_bin): Add comment that this is not possibly + the final version. + 2006-12-07 Corinna Vinschen <corinna@vinschen.de> * syscalls.cc (unlink_nt): Open native symlinks with diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 928e1c64b..e126588cb 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -149,6 +149,13 @@ dup2 (int oldfd, int newfd) static void try_to_bin (const char *win32_path) { +/* TODO: Using SHFileOperation for this functionality is incredibly slow. + Given the fact that we have an open handle to the file at this + point, there must be some quicker way to move the file to the + bin or something bin-like. I keep this activated to remind me + by its slowness, that this can't go into a release version as + is. Back to the drawing board. */ + /* The op.pFrom parameter must be double \0 terminated since it's not just a filename, but a list of filenames. If the double \0 is missing, SHFileOperationA returns with error number 1026 (which is |