summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Turney <jon.turney@dronecode.org.uk>2017-01-30 15:04:28 +0000
committerJon Turney <jon.turney@dronecode.org.uk>2017-01-31 19:55:38 +0000
commita15297381df27a5e53eab42fe5c475e2aa55f559 (patch)
treed0f663e64ae6c39467e32b2b33c7d2cab6d60e16
parentaade9a4fe1cba9176e371abc50ee382319bfcef0 (diff)
downloadcygnal-a15297381df27a5e53eab42fe5c475e2aa55f559.tar.gz
cygnal-a15297381df27a5e53eab42fe5c475e2aa55f559.tar.bz2
cygnal-a15297381df27a5e53eab42fe5c475e2aa55f559.zip
Fix handling of '+' by 'cygcheck -p'
The form data sent to the server should be application/x-www-form-urlencoded This replaces spaces with '+' before being RFC 1738 encoded, so a literal '+' must be %-encoded also. See https://cygwin.com/ml/cygwin/2014-01/msg00287.html et seq. Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
-rw-r--r--winsup/utils/cygcheck.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/winsup/utils/cygcheck.cc b/winsup/utils/cygcheck.cc
index d1e27b7e9..e745b20e5 100644
--- a/winsup/utils/cygcheck.cc
+++ b/winsup/utils/cygcheck.cc
@@ -2009,8 +2009,8 @@ check_keys ()
return 0;
}
-/* RFC1738 says that these do not need to be escaped. */
-static const char safe_chars[] = "$-_.+!*'(),";
+/* These do not need to be escaped in application/x-www-form-urlencoded */
+static const char safe_chars[] = "$-_.!*'(),";
/* the URL to query. */
static const char base_url[] =