summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Yano <takashi.yano@nifty.ne.jp>2020-01-02 22:17:16 +0900
committerCorinna Vinschen <corinna@vinschen.de>2020-01-14 17:18:25 +0100
commit783eaa888feaf4f76df3d3449e29aa20aa78c802 (patch)
tree620084913b232882d3065679c373466295c6f88a
parentf03806b68a556323f858f816e391fadb01b287bb (diff)
downloadcygnal-783eaa888feaf4f76df3d3449e29aa20aa78c802.tar.gz
cygnal-783eaa888feaf4f76df3d3449e29aa20aa78c802.tar.bz2
cygnal-783eaa888feaf4f76df3d3449e29aa20aa78c802.zip
Cygwin: console: Add code to restore console mode on close.
- The console with 24bit color support has a problem that console mode is changed if cygwin process is executed in cmd.exe which started in cygwin shell. For example, cursor keys become not working if bash -> cmd -> true are executed in this order. This patch fixes the issue.
-rw-r--r--winsup/cygwin/fhandler_console.cc21
1 files changed, 21 insertions, 0 deletions
diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 337331be2..b3f2cb65a 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -53,6 +53,9 @@ fhandler_console::console_state NO_COPY *fhandler_console::shared_console_info;
bool NO_COPY fhandler_console::invisible_console;
+static DWORD orig_conin_mode = (DWORD) -1;
+static DWORD orig_conout_mode = (DWORD) -1;
+
static void
beep ()
{
@@ -1010,6 +1013,11 @@ fhandler_console::open (int flags, mode_t)
get_ttyp ()->rstcons (false);
set_open_status ();
+ if (orig_conin_mode == (DWORD) -1)
+ GetConsoleMode (get_handle (), &orig_conin_mode);
+ if (orig_conout_mode == (DWORD) -1)
+ GetConsoleMode (get_output_handle (), &orig_conout_mode);
+
if (getpid () == con.owner && wincap.has_con_24bit_colors ())
{
DWORD dwMode;
@@ -1079,6 +1087,19 @@ fhandler_console::close ()
SetConsoleMode (get_output_handle (), dwMode);
}
+ /* Restore console mode if this is the last closure. */
+ OBJECT_BASIC_INFORMATION obi;
+ NTSTATUS status;
+ status = NtQueryObject (get_handle (), ObjectBasicInformation,
+ &obi, sizeof obi, NULL);
+ if (NT_SUCCESS (status) && obi.HandleCount == 1)
+ {
+ if (orig_conin_mode != (DWORD) -1)
+ SetConsoleMode (get_handle (), orig_conin_mode);
+ if (orig_conout_mode != (DWORD) -1)
+ SetConsoleMode (get_handle (), orig_conout_mode);
+ }
+
CloseHandle (get_handle ());
CloseHandle (get_output_handle ());