diff options
| author | Corinna Vinschen <corinna@vinschen.de> | 2014-07-30 14:23:53 +0000 |
|---|---|---|
| committer | Corinna Vinschen <corinna@vinschen.de> | 2014-07-30 14:23:53 +0000 |
| commit | 1721a38efdccef14eff57a6520104b0101af2689 (patch) | |
| tree | 7117bc1975f0932c5de9dd172250984aa61f4381 | |
| parent | dea309cf1f50eefaf989965e4946e98cef8cff65 (diff) | |
| download | cygnal-1721a38efdccef14eff57a6520104b0101af2689.tar.gz cygnal-1721a38efdccef14eff57a6520104b0101af2689.tar.bz2 cygnal-1721a38efdccef14eff57a6520104b0101af2689.zip | |
* uinfo.cc (pwdgrp::fetch_account_from_windows): Fix comment.
| -rw-r--r-- | winsup/cygwin/ChangeLog | 4 | ||||
| -rw-r--r-- | winsup/cygwin/uinfo.cc | 15 |
2 files changed, 11 insertions, 8 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index c793266e9..18790fe70 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,7 @@ +2014-07-30 Corinna Vinschen <corinna@vinschen.de> + + * uinfo.cc (pwdgrp::fetch_account_from_windows): Fix comment. + 2014-07-29 Corinna Vinschen <corinna@vinschen.de> * cygheap.h (class cygheap_domain_info): Remove lowest_tdo_posix_offset. diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc index ed533bd8a..0ba86278e 100644 --- a/winsup/cygwin/uinfo.cc +++ b/winsup/cygwin/uinfo.cc @@ -1530,14 +1530,13 @@ pwdgrp::fetch_account_from_windows (fetch_user_arg_t &arg, cyg_ldap *pldap) { posix_offset = PRIMARY_POSIX_OFFSET; /* In theory domain should have been set to - cygheap->dom.primary_dns_name (), but it turns out - that not setting the domain here has advantages. - We open the ldap connection to NULL (== some domain - control of our primary domain) anyway. So the domain - is only used - later on. So, don't set domain here to non-NULL, unless - you're sure you have also changed subsequent assumptions - that domain is NULL if it's a primary domain account. */ + cygheap->dom.primary_dns_name (), but it turns out that + not setting the domain here has advantages. We open the + ldap connection to NULL (== some DC of our primary domain) + anyway. So the domain is only used later on. So, don't + set domain here to non-NULL, unless you're sure you have + also changed subsequent assumptions that domain is NULL + if it's a primary domain account. */ if (!cygheap->pg.nss_prefix_auto ()) name_style = fully_qualified; } |