summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCorinna Vinschen <corinna@vinschen.de>2014-07-09 10:41:11 +0000
committerCorinna Vinschen <corinna@vinschen.de>2014-07-09 10:41:11 +0000
commit3dab1e488aae1787e1ada0bfbda2fb71bd449687 (patch)
tree5f8b5e935492a0325656d45ab7d251fd1932f7b7
parent64cfc4ac5a48901873612c1b1da8b17f58128932 (diff)
downloadcygnal-3dab1e488aae1787e1ada0bfbda2fb71bd449687.tar.gz
cygnal-3dab1e488aae1787e1ada0bfbda2fb71bd449687.tar.bz2
cygnal-3dab1e488aae1787e1ada0bfbda2fb71bd449687.zip
* exceptions.cc (exception::myfault_handle): Rephrase comment.
-rw-r--r--winsup/cygwin/ChangeLog4
-rw-r--r--winsup/cygwin/exceptions.cc5
2 files changed, 8 insertions, 1 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 82fc1d366..d940017fe 100644
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,5 +1,9 @@
2014-07-09 Corinna Vinschen <corinna@vinschen.de>
+ * exceptions.cc (exception::myfault_handle): Rephrase comment.
+
+2014-07-09 Corinna Vinschen <corinna@vinschen.de>
+
* exceptions.cc (exception::myfault_handle): Fix typo in comment.
2014-07-07 Corinna Vinschen <corinna@vinschen.de>
diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc
index 60cef57ab..0e8a977d4 100644
--- a/winsup/cygwin/exceptions.cc
+++ b/winsup/cygwin/exceptions.cc
@@ -564,7 +564,10 @@ exception::myfault_handle (LPEXCEPTION_POINTERS ep)
case STATUS_ACCESS_VIOLATION:
case STATUS_DATATYPE_MISALIGNMENT:
#if 0
- /* Short-circuiting STATUS_STACK_OVERFLOW disables stack commits. */
+ /* PAGE_GUARD-based stack commits are based on structured exception
+ handling. Short-circuiting STATUS_STACK_OVERFLOW in a vectored
+ exception handler disables that, which can ultimately result in
+ a spurious SEGV. */
case STATUS_STACK_OVERFLOW:
#endif
case STATUS_ARRAY_BOUNDS_EXCEEDED: