summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCorinna Vinschen <corinna@vinschen.de>2021-02-10 10:33:36 +0100
committerCorinna Vinschen <corinna@vinschen.de>2021-02-10 10:42:38 +0100
commitc875ed3744968b19f7dd8ed6335710be55617d36 (patch)
tree2832f8bbd30ff2a6d264085f7feaf82ef7c41b4f
parent89b3833211a850a165a3c844acb19a66524c3cc2 (diff)
downloadcygnal-c875ed3744968b19f7dd8ed6335710be55617d36.tar.gz
cygnal-c875ed3744968b19f7dd8ed6335710be55617d36.tar.bz2
cygnal-c875ed3744968b19f7dd8ed6335710be55617d36.zip
Cygwin: don't copy path_conv in fhandler_base::reset
There's a slim chance that duplicating fhandlers may end up duplicating path_conv_handle handles twice ending up with a handle leak, due to fhandler_base::reset calling path_conv::operator<< after the only caller, fhandler::copyto, already called path_conv::operator=. Just drop the call which basically duplicates what path_conv::operator= already did. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
-rw-r--r--winsup/cygwin/fhandler.cc1
1 files changed, 0 insertions, 1 deletions
diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc
index 5dbbd4068..ee0047ea0 100644
--- a/winsup/cygwin/fhandler.cc
+++ b/winsup/cygwin/fhandler.cc
@@ -43,7 +43,6 @@ LONG NO_COPY fhandler_base_overlapped::asio_close_counter;
void
fhandler_base::reset (const fhandler_base *from)
{
- pc << from->pc;
ra.rabuf = NULL;
ra.ralen = 0;
ra.raixget = 0;