summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Schindelin <johannes.schindelin@gmx.de>2021-03-22 16:51:48 +0100
committerCorinna Vinschen <corinna@vinschen.de>2021-03-23 16:54:33 +0100
commit2533912fc76c08af9e386a371fc6b3eb194d56be (patch)
treee0074bd9dc08d335c0972312e71f89f4e3863215
parentef05e8bdae87b9a72a709a7a7054543aab45992a (diff)
downloadcygnal-2533912fc76c08af9e386a371fc6b3eb194d56be.tar.gz
cygnal-2533912fc76c08af9e386a371fc6b3eb194d56be.tar.bz2
cygnal-2533912fc76c08af9e386a371fc6b3eb194d56be.zip
Cygwin: Allow executing Windows Store's "app execution aliases"
The Windows Store version of Python (and apparently other Windows Store applications) install a special reparse point called "app execution alias" into the user's `PATH`. These applications can be executed without any problem, but they cannot be read as if they were files. This trips up Cygwin's beautiful logic that tries to determine whether we're about to execute a Cygwin executable or not: instead of executing the application, it will fail, saying "Permission denied". Let's detect this situation (`NtOpenFile()` helpfully says that this operation is not supported on this reparse point type), and simply skip the logic: Windows Store apps are not Cygwin executables (and even if they were, it is unlikely that they would come with a compatible `cygwin1.dll` or `msys-2.0.dll`). This fixes https://github.com/msys2/MSYS2-packages/issues/1943 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
-rw-r--r--winsup/cygwin/spawn.cc7
1 files changed, 7 insertions, 0 deletions
diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 7a585392a..ec0cdd408 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -1276,6 +1276,13 @@ av::setup (const char *prog_arg, path_conv& real_path, const char *ext,
FILE_SYNCHRONOUS_IO_NONALERT
| FILE_OPEN_FOR_BACKUP_INTENT
| FILE_NON_DIRECTORY_FILE);
+ if (status == STATUS_IO_REPARSE_TAG_NOT_HANDLED)
+ {
+ /* This is most likely an app execution alias (such as the
+ Windows Store version of Python, i.e. not a Cygwin program */
+ real_path.set_cygexec (false);
+ break;
+ }
if (!NT_SUCCESS (status))
{
/* File is not readable? Doesn't mean it's not executable.