From e7f65d97c80d3604f8aedf67b057c7b79ea3b183 Mon Sep 17 00:00:00 2001 From: Kaz Kylheku Date: Fri, 30 Dec 2022 19:08:37 -0800 Subject: crypt: fix for platforms that lack crypt_r. * sysif.c (crypt_wrap): Don't call free(cd) on platforms where we don't have crypt_r and have not defined the cd variable. * test/018/crypt.tl: Move the (crypt "a" "b") test case to be GNU/Linux-only. On Solaris, it yields a valid-looking hash instead of failing. That hash will not validate the password though; i.e. (crypt "a" (crypt "a" "b")) is not equal to (crypt "a" "b"). --- sysif.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'sysif.c') diff --git a/sysif.c b/sysif.c index 5af269d5..00354a10 100644 --- a/sysif.c +++ b/sysif.c @@ -2083,11 +2083,15 @@ static val crypt_wrap(val wkey, val wsalt) if (hash != 0) { val ret = string_utf8(hash); +#if HAVE_CRYPT_R free(cd); +#endif return ret; } +#if HAVE_CRYPT_R free(cd); +#endif uw_ethrowf(error_s, lit("crypt failed: ~d/~s"), num(errno), errno_to_str(errno), nao); -- cgit v1.2.3