From f597ee8f9ac128f88f85639ffbce6d7248776f75 Mon Sep 17 00:00:00 2001 From: "Arnold D. Robbins" Date: Sun, 26 Sep 2021 20:56:19 +0300 Subject: Update FIXME and comments and builtin.c:do_mktime. --- builtin.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'builtin.c') diff --git a/builtin.c b/builtin.c index cf0c98e3..d7ba82c9 100644 --- a/builtin.c +++ b/builtin.c @@ -2121,10 +2121,12 @@ do_mktime(int nargs) & hour, & minute, & second, & dst); + // 9/2021: I've been told that according to the ISO 8601-1:2019 spec, + // hour cannot be 24. So the check for hour > 23 is valid. if ( do_lint /* Ready? Set! Go: */ && ( (second < 0 || second > 60) || (minute < 0 || minute > 59) - || (hour < 0 || hour > 23) /* FIXME ISO 8601 allows 24 ? */ + || (hour < 0 || hour > 23) || (day < 1 || day > 31) || (month < 1 || month > 12) )) lintwarn(_("mktime: at least one of the values is out of the default range")); -- cgit v1.2.3